ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/OpenMD/branches/development/src/brains/ForceManager.cpp
(Generate patch)

Comparing branches/development/src/brains/ForceManager.cpp (file contents):
Revision 1569 by gezelter, Thu May 26 13:55:04 2011 UTC vs.
Revision 1597 by gezelter, Tue Jul 26 15:49:24 2011 UTC

# Line 47 | Line 47
47   * @version 1.0
48   */
49  
50 +
51   #include "brains/ForceManager.hpp"
52   #include "primitives/Molecule.hpp"
53   #define __OPENMD_C
# Line 58 | Line 59
59   #include "nonbonded/NonBondedInteraction.hpp"
60   #include "parallel/ForceMatrixDecomposition.hpp"
61  
62 + #include <cstdio>
63 + #include <iostream>
64 + #include <iomanip>
65 +
66   using namespace std;
67   namespace OpenMD {
68    
69    ForceManager::ForceManager(SimInfo * info) : info_(info) {
70 <
71 < #ifdef IS_MPI
72 <    fDecomp_ = new ForceMatrixDecomposition(info_);
68 < #else
69 <    // fDecomp_ = new ForceSerialDecomposition(info);
70 < #endif
70 >    forceField_ = info_->getForceField();
71 >    interactionMan_ = new InteractionManager();
72 >    fDecomp_ = new ForceMatrixDecomposition(info_, interactionMan_);
73    }
74 +
75 +  /**
76 +   * setupCutoffs
77 +   *
78 +   * Sets the values of cutoffRadius, switchingRadius, cutoffMethod,
79 +   * and cutoffPolicy
80 +   *
81 +   * cutoffRadius : realType
82 +   *  If the cutoffRadius was explicitly set, use that value.
83 +   *  If the cutoffRadius was not explicitly set:
84 +   *      Are there electrostatic atoms?  Use 12.0 Angstroms.
85 +   *      No electrostatic atoms?  Poll the atom types present in the
86 +   *      simulation for suggested cutoff values (e.g. 2.5 * sigma).
87 +   *      Use the maximum suggested value that was found.
88 +   *
89 +   * cutoffMethod : (one of HARD, SWITCHED, SHIFTED_FORCE,
90 +   *                        or SHIFTED_POTENTIAL)
91 +   *      If cutoffMethod was explicitly set, use that choice.
92 +   *      If cutoffMethod was not explicitly set, use SHIFTED_FORCE
93 +   *
94 +   * cutoffPolicy : (one of MIX, MAX, TRADITIONAL)
95 +   *      If cutoffPolicy was explicitly set, use that choice.
96 +   *      If cutoffPolicy was not explicitly set, use TRADITIONAL
97 +   *
98 +   * switchingRadius : realType
99 +   *  If the cutoffMethod was set to SWITCHED:
100 +   *      If the switchingRadius was explicitly set, use that value
101 +   *          (but do a sanity check first).
102 +   *      If the switchingRadius was not explicitly set: use 0.85 *
103 +   *      cutoffRadius_
104 +   *  If the cutoffMethod was not set to SWITCHED:
105 +   *      Set switchingRadius equal to cutoffRadius for safety.
106 +   */
107 +  void ForceManager::setupCutoffs() {
108 +    
109 +    Globals* simParams_ = info_->getSimParams();
110 +    ForceFieldOptions& forceFieldOptions_ = forceField_->getForceFieldOptions();
111 +    
112 +    if (simParams_->haveCutoffRadius()) {
113 +      rCut_ = simParams_->getCutoffRadius();
114 +    } else {      
115 +      if (info_->usesElectrostaticAtoms()) {
116 +        sprintf(painCave.errMsg,
117 +                "ForceManager::setupCutoffs: No value was set for the cutoffRadius.\n"
118 +                "\tOpenMD will use a default value of 12.0 angstroms"
119 +                "\tfor the cutoffRadius.\n");
120 +        painCave.isFatal = 0;
121 +        painCave.severity = OPENMD_INFO;
122 +        simError();
123 +        rCut_ = 12.0;
124 +      } else {
125 +        RealType thisCut;
126 +        set<AtomType*>::iterator i;
127 +        set<AtomType*> atomTypes;
128 +        atomTypes = info_->getSimulatedAtomTypes();        
129 +        for (i = atomTypes.begin(); i != atomTypes.end(); ++i) {
130 +          thisCut = interactionMan_->getSuggestedCutoffRadius((*i));
131 +          rCut_ = max(thisCut, rCut_);
132 +        }
133 +        sprintf(painCave.errMsg,
134 +                "ForceManager::setupCutoffs: No value was set for the cutoffRadius.\n"
135 +                "\tOpenMD will use %lf angstroms.\n",
136 +                rCut_);
137 +        painCave.isFatal = 0;
138 +        painCave.severity = OPENMD_INFO;
139 +        simError();
140 +      }
141 +    }
142 +
143 +    fDecomp_->setUserCutoff(rCut_);
144 +    interactionMan_->setCutoffRadius(rCut_);
145 +
146 +    map<string, CutoffMethod> stringToCutoffMethod;
147 +    stringToCutoffMethod["HARD"] = HARD;
148 +    stringToCutoffMethod["SWITCHED"] = SWITCHED;
149 +    stringToCutoffMethod["SHIFTED_POTENTIAL"] = SHIFTED_POTENTIAL;    
150 +    stringToCutoffMethod["SHIFTED_FORCE"] = SHIFTED_FORCE;
151    
152 <  void ForceManager::calcForces() {
152 >    if (simParams_->haveCutoffMethod()) {
153 >      string cutMeth = toUpperCopy(simParams_->getCutoffMethod());
154 >      map<string, CutoffMethod>::iterator i;
155 >      i = stringToCutoffMethod.find(cutMeth);
156 >      if (i == stringToCutoffMethod.end()) {
157 >        sprintf(painCave.errMsg,
158 >                "ForceManager::setupCutoffs: Could not find chosen cutoffMethod %s\n"
159 >                "\tShould be one of: "
160 >                "HARD, SWITCHED, SHIFTED_POTENTIAL, or SHIFTED_FORCE\n",
161 >                cutMeth.c_str());
162 >        painCave.isFatal = 1;
163 >        painCave.severity = OPENMD_ERROR;
164 >        simError();
165 >      } else {
166 >        cutoffMethod_ = i->second;
167 >      }
168 >    } else {
169 >      sprintf(painCave.errMsg,
170 >              "ForceManager::setupCutoffs: No value was set for the cutoffMethod.\n"
171 >              "\tOpenMD will use SHIFTED_FORCE.\n");
172 >      painCave.isFatal = 0;
173 >      painCave.severity = OPENMD_INFO;
174 >      simError();
175 >      cutoffMethod_ = SHIFTED_FORCE;        
176 >    }
177 >
178 >    map<string, CutoffPolicy> stringToCutoffPolicy;
179 >    stringToCutoffPolicy["MIX"] = MIX;
180 >    stringToCutoffPolicy["MAX"] = MAX;
181 >    stringToCutoffPolicy["TRADITIONAL"] = TRADITIONAL;    
182 >
183 >    std::string cutPolicy;
184 >    if (forceFieldOptions_.haveCutoffPolicy()){
185 >      cutPolicy = forceFieldOptions_.getCutoffPolicy();
186 >    }else if (simParams_->haveCutoffPolicy()) {
187 >      cutPolicy = simParams_->getCutoffPolicy();
188 >    }
189 >
190 >    if (!cutPolicy.empty()){
191 >      toUpper(cutPolicy);
192 >      map<string, CutoffPolicy>::iterator i;
193 >      i = stringToCutoffPolicy.find(cutPolicy);
194 >
195 >      if (i == stringToCutoffPolicy.end()) {
196 >        sprintf(painCave.errMsg,
197 >                "ForceManager::setupCutoffs: Could not find chosen cutoffPolicy %s\n"
198 >                "\tShould be one of: "
199 >                "MIX, MAX, or TRADITIONAL\n",
200 >                cutPolicy.c_str());
201 >        painCave.isFatal = 1;
202 >        painCave.severity = OPENMD_ERROR;
203 >        simError();
204 >      } else {
205 >        cutoffPolicy_ = i->second;
206 >      }
207 >    } else {
208 >      sprintf(painCave.errMsg,
209 >              "ForceManager::setupCutoffs: No value was set for the cutoffPolicy.\n"
210 >              "\tOpenMD will use TRADITIONAL.\n");
211 >      painCave.isFatal = 0;
212 >      painCave.severity = OPENMD_INFO;
213 >      simError();
214 >      cutoffPolicy_ = TRADITIONAL;        
215 >    }
216 >
217 >    fDecomp_->setCutoffPolicy(cutoffPolicy_);
218 >        
219 >    // create the switching function object:
220 >
221 >    switcher_ = new SwitchingFunction();
222 >  
223 >    if (cutoffMethod_ == SWITCHED) {
224 >      if (simParams_->haveSwitchingRadius()) {
225 >        rSwitch_ = simParams_->getSwitchingRadius();
226 >        if (rSwitch_ > rCut_) {        
227 >          sprintf(painCave.errMsg,
228 >                  "ForceManager::setupCutoffs: switchingRadius (%f) is larger "
229 >                  "than the cutoffRadius(%f)\n", rSwitch_, rCut_);
230 >          painCave.isFatal = 1;
231 >          painCave.severity = OPENMD_ERROR;
232 >          simError();
233 >        }
234 >      } else {      
235 >        rSwitch_ = 0.85 * rCut_;
236 >        sprintf(painCave.errMsg,
237 >                "ForceManager::setupCutoffs: No value was set for the switchingRadius.\n"
238 >                "\tOpenMD will use a default value of 85 percent of the cutoffRadius.\n"
239 >                "\tswitchingRadius = %f. for this simulation\n", rSwitch_);
240 >        painCave.isFatal = 0;
241 >        painCave.severity = OPENMD_WARNING;
242 >        simError();
243 >      }
244 >    } else {
245 >      if (simParams_->haveSwitchingRadius()) {
246 >        map<string, CutoffMethod>::const_iterator it;
247 >        string theMeth;
248 >        for (it = stringToCutoffMethod.begin();
249 >             it != stringToCutoffMethod.end(); ++it) {
250 >          if (it->second == cutoffMethod_) {
251 >            theMeth = it->first;
252 >            break;
253 >          }
254 >        }
255 >        sprintf(painCave.errMsg,
256 >                "ForceManager::setupCutoffs: the cutoffMethod (%s)\n"
257 >                "\tis not set to SWITCHED, so switchingRadius value\n"
258 >                "\twill be ignored for this simulation\n", theMeth.c_str());
259 >        painCave.isFatal = 0;
260 >        painCave.severity = OPENMD_WARNING;
261 >        simError();
262 >      }
263 >
264 >      rSwitch_ = rCut_;
265 >    }
266      
267 +    // Default to cubic switching function.
268 +    sft_ = cubic;
269 +    if (simParams_->haveSwitchingFunctionType()) {
270 +      string funcType = simParams_->getSwitchingFunctionType();
271 +      toUpper(funcType);
272 +      if (funcType == "CUBIC") {
273 +        sft_ = cubic;
274 +      } else {
275 +        if (funcType == "FIFTH_ORDER_POLYNOMIAL") {
276 +          sft_ = fifth_order_poly;
277 +        } else {
278 +          // throw error        
279 +          sprintf( painCave.errMsg,
280 +                   "ForceManager::setupSwitching : Unknown switchingFunctionType. (Input file specified %s .)\n"
281 +                   "\tswitchingFunctionType must be one of: "
282 +                   "\"cubic\" or \"fifth_order_polynomial\".",
283 +                   funcType.c_str() );
284 +          painCave.isFatal = 1;
285 +          painCave.severity = OPENMD_ERROR;
286 +          simError();
287 +        }          
288 +      }
289 +    }
290 +    switcher_->setSwitchType(sft_);
291 +    switcher_->setSwitch(rSwitch_, rCut_);
292 +    interactionMan_->setSwitchingRadius(rSwitch_);
293 +  }
294 +  
295 +  void ForceManager::initialize() {
296 +
297      if (!info_->isTopologyDone()) {
298 +
299        info_->update();
300        interactionMan_->setSimInfo(info_);
301        interactionMan_->initialize();
302 <      swfun_ = interactionMan_->getSwitchingFunction();
303 <      fDecomp_->distributeInitialData();
304 <      info_->prepareTopology();
302 >
303 >      // We want to delay the cutoffs until after the interaction
304 >      // manager has set up the atom-atom interactions so that we can
305 >      // query them for suggested cutoff values
306 >      setupCutoffs();
307 >
308 >      info_->prepareTopology();      
309      }
310 +
311 +    ForceFieldOptions& fopts = forceField_->getForceFieldOptions();
312 +    
313 +    // Force fields can set options on how to scale van der Waals and
314 +    // electrostatic interactions for atoms connected via bonds, bends
315 +    // and torsions in this case the topological distance between
316 +    // atoms is:
317 +    // 0 = topologically unconnected
318 +    // 1 = bonded together
319 +    // 2 = connected via a bend
320 +    // 3 = connected via a torsion
321      
322 +    vdwScale_.reserve(4);
323 +    fill(vdwScale_.begin(), vdwScale_.end(), 0.0);
324 +
325 +    electrostaticScale_.reserve(4);
326 +    fill(electrostaticScale_.begin(), electrostaticScale_.end(), 0.0);
327 +
328 +    vdwScale_[0] = 1.0;
329 +    vdwScale_[1] = fopts.getvdw12scale();
330 +    vdwScale_[2] = fopts.getvdw13scale();
331 +    vdwScale_[3] = fopts.getvdw14scale();
332 +    
333 +    electrostaticScale_[0] = 1.0;
334 +    electrostaticScale_[1] = fopts.getelectrostatic12scale();
335 +    electrostaticScale_[2] = fopts.getelectrostatic13scale();
336 +    electrostaticScale_[3] = fopts.getelectrostatic14scale();    
337 +    
338 +    fDecomp_->distributeInitialData();
339 +
340 +    initialized_ = true;
341 +
342 +  }
343 +
344 +  void ForceManager::calcForces() {
345 +    
346 +    if (!initialized_) initialize();
347 +
348      preCalculation();  
349      shortRangeInteractions();
350      longRangeInteractions();
351 <    postCalculation();
88 <    
351 >    postCalculation();    
352    }
353    
354    void ForceManager::preCalculation() {
# Line 102 | Line 365 | namespace OpenMD {
365      
366      for (mol = info_->beginMolecule(mi); mol != NULL;
367           mol = info_->nextMolecule(mi)) {
368 <      for(atom = mol->beginAtom(ai); atom != NULL; atom = mol->nextAtom(ai)) {
368 >      for(atom = mol->beginAtom(ai); atom != NULL;
369 >          atom = mol->nextAtom(ai)) {
370          atom->zeroForcesAndTorques();
371 +        cerr << "apos = " << atom->getPos() << "\n";
372        }
373 <          
373 >      
374        //change the positions of atoms which belong to the rigidbodies
375        for (rb = mol->beginRigidBody(rbIter); rb != NULL;
376             rb = mol->nextRigidBody(rbIter)) {
377          rb->zeroForcesAndTorques();
378        }        
379 <
379 >      
380        if(info_->getNGlobalCutoffGroups() != info_->getNGlobalAtoms()){
381          for(cg = mol->beginCutoffGroup(ci); cg != NULL;
382              cg = mol->nextCutoffGroup(ci)) {
383            //calculate the center of mass of cutoff group
384            cg->updateCOM();
385 +          cerr << "cgpos = " << cg->getPos() << "\n";
386          }
387        }      
388      }
389 <  
389 >    
390      // Zero out the stress tensor
391      tau *= 0.0;
392      
# Line 174 | Line 440 | namespace OpenMD {
440            dataSet.prev.angle = dataSet.curr.angle = angle;
441            dataSet.prev.potential = dataSet.curr.potential = currBendPot;
442            dataSet.deltaV = 0.0;
443 <          bendDataSets.insert(map<Bend*, BendDataSet>::value_type(bend, dataSet));
443 >          bendDataSets.insert(map<Bend*, BendDataSet>::value_type(bend,
444 >                                                                  dataSet));
445          }else {
446            i->second.prev.angle = i->second.curr.angle;
447            i->second.prev.potential = i->second.curr.potential;
# Line 245 | Line 512 | namespace OpenMD {
512    
513    void ForceManager::longRangeInteractions() {
514  
248 –    // some of this initial stuff will go away:
515      Snapshot* curSnapshot = info_->getSnapshotManager()->getCurrentSnapshot();
516      DataStorage* config = &(curSnapshot->atomData);
517      DataStorage* cgConfig = &(curSnapshot->cgData);
252 –    RealType* frc = config->getArrayPointer(DataStorage::dslForce);
253 –    RealType* pos = config->getArrayPointer(DataStorage::dslPosition);
254 –    RealType* trq = config->getArrayPointer(DataStorage::dslTorque);
255 –    RealType* A = config->getArrayPointer(DataStorage::dslAmat);
256 –    RealType* electroFrame = config->getArrayPointer(DataStorage::dslElectroFrame);
257 –    RealType* particlePot = config->getArrayPointer(DataStorage::dslParticlePot);
258 –    RealType* rc;    
518  
519 <    if(info_->getNGlobalCutoffGroups() != info_->getNGlobalAtoms()){
520 <      rc = cgConfig->getArrayPointer(DataStorage::dslPosition);
519 >    //calculate the center of mass of cutoff group
520 >
521 >    SimInfo::MoleculeIterator mi;
522 >    Molecule* mol;
523 >    Molecule::CutoffGroupIterator ci;
524 >    CutoffGroup* cg;
525 >
526 >    if(info_->getNCutoffGroups() > 0){      
527 >      for (mol = info_->beginMolecule(mi); mol != NULL;
528 >           mol = info_->nextMolecule(mi)) {
529 >        for(cg = mol->beginCutoffGroup(ci); cg != NULL;
530 >            cg = mol->nextCutoffGroup(ci)) {
531 >          cerr << "branch1\n";
532 >          cerr << "globind = " << cg->getGlobalIndex() << "\n";
533 >          cg->updateCOM();
534 >        }
535 >      }      
536      } else {
537        // center of mass of the group is the same as position of the atom  
538        // if cutoff group does not exist
539 <      rc = pos;
539 >      cerr << "branch2\n";
540 >      cgConfig->position = config->position;
541      }
267 –    
268 –    //initialize data before passing to fortran
269 –    RealType longRangePotential[N_INTERACTION_FAMILIES];
270 –    RealType lrPot = 0.0;
271 –    int isError = 0;
542  
543 <    // dangerous to iterate over enums, but we'll live on the edge:
274 <    for (int i = NO_FAMILY; i != N_INTERACTION_FAMILIES; ++i){
275 <      longRangePotential[i]=0.0; //Initialize array
276 <    }
277 <
278 <    // new stuff starts here:
279 <
543 >    fDecomp_->zeroWorkArrays();
544      fDecomp_->distributeData();
545 <
546 <    int cg1, cg2, atom1, atom2;
547 <    Vector3d d_grp, dag;
548 <    RealType rgrpsq, rgrp;
545 >    
546 >    int cg1, cg2, atom1, atom2, topoDist;
547 >    Vector3d d_grp, dag, d;
548 >    RealType rgrpsq, rgrp, r2, r;
549 >    RealType electroMult, vdwMult;
550      RealType vij;
551 <    Vector3d fij, fg;
552 <    pair<int, int> gtypes;
551 >    Vector3d fij, fg, f1;
552 >    tuple3<RealType, RealType, RealType> cuts;
553      RealType rCutSq;
554      bool in_switching_region;
555      RealType sw, dswdr, swderiv;
# Line 292 | Line 557 | namespace OpenMD {
557      InteractionData idat;
558      SelfData sdat;
559      RealType mf;
560 +    RealType lrPot;
561 +    RealType vpair;
562 +    potVec longRangePotential(0.0);
563 +    potVec workPot(0.0);
564  
565      int loopStart, loopEnd;
566  
567 +    idat.vdwMult = &vdwMult;
568 +    idat.electroMult = &electroMult;
569 +    idat.pot = &workPot;
570 +    sdat.pot = fDecomp_->getEmbeddingPotential();
571 +    idat.vpair = &vpair;
572 +    idat.f1 = &f1;
573 +    idat.sw = &sw;
574 +    idat.shiftedPot = (cutoffMethod_ == SHIFTED_POTENTIAL) ? true : false;
575 +    idat.shiftedForce = (cutoffMethod_ == SHIFTED_FORCE) ? true : false;
576 +    
577      loopEnd = PAIR_LOOP;
578      if (info_->requiresPrepair() ) {
579        loopStart = PREPAIR_LOOP;
580      } else {
581        loopStart = PAIR_LOOP;
582      }
583 <
584 <    for (int iLoop = loopStart; iLoop < loopEnd; iLoop++) {
585 <      
583 >  
584 >    for (int iLoop = loopStart; iLoop <= loopEnd; iLoop++) {
585 >    
586        if (iLoop == loopStart) {
587          bool update_nlist = fDecomp_->checkNeighborList();
588          if (update_nlist)
589            neighborList = fDecomp_->buildNeighborList();
590 <      }
591 <
590 >      }      
591 >        
592        for (vector<pair<int, int> >::iterator it = neighborList.begin();
593               it != neighborList.end(); ++it) {
594 <        
594 >                
595          cg1 = (*it).first;
596          cg2 = (*it).second;
597 +        
598 +        cuts = fDecomp_->getGroupCutoffs(cg1, cg2);
599  
319 –        gtypes = fDecomp_->getGroupTypes(cg1, cg2);
600          d_grp  = fDecomp_->getIntergroupVector(cg1, cg2);
601          curSnapshot->wrapVector(d_grp);        
602          rgrpsq = d_grp.lengthSquare();
323 –        rCutSq = groupCutoffMap[gtypes].first;
603  
604 +        rCutSq = cuts.second;
605 +
606          if (rgrpsq < rCutSq) {
607 <          *(idat.rcut) = groupCutoffMap[gtypes].second;
607 >          idat.rcut = &cuts.first;
608            if (iLoop == PAIR_LOOP) {
609 <            vij *= 0.0;
609 >            vij = 0.0;
610              fij = V3Zero;
611            }
612            
613 <          in_switching_region = swfun_->getSwitch(rgrpsq, *(idat.sw), dswdr,
614 <                                                  rgrp);              
613 >          in_switching_region = switcher_->getSwitch(rgrpsq, sw, dswdr,
614 >                                                     rgrp);
615 >              
616            atomListRow = fDecomp_->getAtomsInGroupRow(cg1);
617            atomListColumn = fDecomp_->getAtomsInGroupColumn(cg2);
618  
# Line 341 | Line 623 | namespace OpenMD {
623              for (vector<int>::iterator jb = atomListColumn.begin();
624                   jb != atomListColumn.end(); ++jb) {              
625                atom2 = (*jb);
626 <              
626 >
627                if (!fDecomp_->skipAtomPair(atom1, atom2)) {
628 +                vpair = 0.0;
629 +                workPot = 0.0;
630 +                f1 = V3Zero;
631 +
632 +                fDecomp_->fillInteractionData(idat, atom1, atom2);
633                  
634 <                idat = fDecomp_->fillInteractionData(atom1, atom2);
634 >                topoDist = fDecomp_->getTopologicalDistance(atom1, atom2);
635 >                vdwMult = vdwScale_[topoDist];
636 >                electroMult = electrostaticScale_[topoDist];
637  
638                  if (atomListRow.size() == 1 && atomListColumn.size() == 1) {
639 <                  *(idat.d) = d_grp;
640 <                  *(idat.r2) = rgrpsq;
639 >                  idat.d = &d_grp;
640 >                  idat.r2 = &rgrpsq;
641 >                  cerr << "dgrp = " << d_grp << "\n";
642                  } else {
643 <                  *(idat.d) = fDecomp_->getInteratomicVector(atom1, atom2);
644 <                  curSnapshot->wrapVector( *(idat.d) );
645 <                  *(idat.r2) = idat.d->lengthSquare();
643 >                  d = fDecomp_->getInteratomicVector(atom1, atom2);
644 >                  curSnapshot->wrapVector( d );
645 >                  r2 = d.lengthSquare();
646 >                  cerr << "datm = " << d<< "\n";
647 >                  idat.d = &d;
648 >                  idat.r2 = &r2;
649                  }
650                  
651 <                *(idat.rij) = sqrt( *(idat.r2) );
651 >                cerr << "idat.d = " << *(idat.d) << "\n";
652 >                r = sqrt( *(idat.r2) );
653 >                idat.rij = &r;
654                
655                  if (iLoop == PREPAIR_LOOP) {
656                    interactionMan_->doPrePair(idat);
657                  } else {
658                    interactionMan_->doPair(idat);
659 <                  vij += *(idat.vpair);
660 <                  fij += *(idat.f1);
661 <                  tau -= outProduct( *(idat.d), *(idat.f1));
659 >                  fDecomp_->unpackInteractionData(idat, atom1, atom2);
660 >
661 >                  cerr << "d = " << *(idat.d) << "\tv=" << vpair << "\tf=" << f1 << "\n";
662 >                  vij += vpair;
663 >                  fij += f1;
664 >                  tau -= outProduct( *(idat.d), f1);
665                  }
666                }
667              }
# Line 373 | Line 671 | namespace OpenMD {
671              if (in_switching_region) {
672                swderiv = vij * dswdr / rgrp;
673                fg = swderiv * d_grp;
376 –
674                fij += fg;
675  
676                if (atomListRow.size() == 1 && atomListColumn.size() == 1) {
# Line 425 | Line 722 | namespace OpenMD {
722        }
723  
724        if (iLoop == PREPAIR_LOOP) {
725 <        if (info_->requiresPrepair()) {            
725 >        if (info_->requiresPrepair()) {
726 >
727            fDecomp_->collectIntermediateData();
728 <          atomListLocal = fDecomp_->getAtomList();
729 <          for (vector<int>::iterator ia = atomListLocal.begin();
730 <               ia != atomListLocal.end(); ++ia) {              
433 <            atom1 = (*ia);            
434 <            sdat = fDecomp_->fillSelfData(atom1);
728 >
729 >          for (int atom1 = 0; atom1 < info_->getNAtoms(); atom1++) {
730 >            fDecomp_->fillSelfData(sdat, atom1);
731              interactionMan_->doPreForce(sdat);
732            }
733 <          fDecomp_->distributeIntermediateData();        
733 >
734 >          fDecomp_->distributeIntermediateData();
735 >
736          }
737        }
738  
739      }
740      
741      fDecomp_->collectData();
742 <    
743 <    if (info_->requiresSkipCorrection() || info_->requiresSelfCorrection()) {
446 <      atomListLocal = fDecomp_->getAtomList();
447 <      for (vector<int>::iterator ia = atomListLocal.begin();
448 <           ia != atomListLocal.end(); ++ia) {              
449 <        atom1 = (*ia);    
742 >        
743 >    if (info_->requiresSelfCorrection()) {
744  
745 <        if (info_->requiresSkipCorrection()) {
746 <          vector<int> skipList = fDecomp_->getSkipsForAtom(atom1);
747 <          for (vector<int>::iterator jb = skipList.begin();
454 <               jb != skipList.end(); ++jb) {              
455 <            atom2 = (*jb);
456 <            idat = fDecomp_->fillSkipData(atom1, atom2);
457 <            interactionMan_->doSkipCorrection(idat);
458 <          }
459 <        }
460 <          
461 <        if (info_->requiresSelfCorrection()) {
462 <          sdat = fDecomp_->fillSelfData(atom1);
463 <          interactionMan_->doSelfCorrection(sdat);
464 <        }
745 >      for (int atom1 = 0; atom1 < info_->getNAtoms(); atom1++) {          
746 >        fDecomp_->fillSelfData(sdat, atom1);
747 >        interactionMan_->doSelfCorrection(sdat);
748        }
466 –    }
749  
468 –    // dangerous to iterate over enums, but we'll live on the edge:
469 –    for (int i = NO_FAMILY; i != N_INTERACTION_FAMILIES; ++i){
470 –      lrPot += longRangePotential[i]; //Quick hack
750      }
751 <        
751 >
752 >    longRangePotential = *(fDecomp_->getEmbeddingPotential()) +
753 >      *(fDecomp_->getPairwisePotential());
754 >
755 >    lrPot = longRangePotential.sum();
756 >
757      //store the tau and long range potential    
758      curSnapshot->statData[Stats::LONG_RANGE_POTENTIAL] = lrPot;
759      curSnapshot->statData[Stats::VANDERWAALS_POTENTIAL] = longRangePotential[VANDERWAALS_FAMILY];

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines