ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/OpenMD/branches/development/src/brains/ForceManager.cpp
(Generate patch)

Comparing branches/development/src/brains/ForceManager.cpp (file contents):
Revision 1601 by gezelter, Thu Aug 4 20:04:35 2011 UTC vs.
Revision 1787 by gezelter, Wed Aug 29 18:13:11 2012 UTC

# Line 36 | Line 36
36   * [1]  Meineke, et al., J. Comp. Chem. 26, 252-271 (2005).            
37   * [2]  Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006).          
38   * [3]  Sun, Lin & Gezelter, J. Chem. Phys. 128, 24107 (2008).          
39 < * [4]  Vardeman & Gezelter, in progress (2009).                        
39 > * [4]  Kuang & Gezelter,  J. Chem. Phys. 133, 164101 (2010).
40 > * [5]  Vardeman, Stocker & Gezelter, J. Chem. Theory Comput. 7, 834 (2011).
41   */
42  
43   /**
# Line 57 | Line 58
58   #include "primitives/Torsion.hpp"
59   #include "primitives/Inversion.hpp"
60   #include "nonbonded/NonBondedInteraction.hpp"
61 + #include "perturbations/ElectricField.hpp"
62   #include "parallel/ForceMatrixDecomposition.hpp"
63  
64   #include <cstdio>
# Line 108 | Line 110 | namespace OpenMD {
110      
111      Globals* simParams_ = info_->getSimParams();
112      ForceFieldOptions& forceFieldOptions_ = forceField_->getForceFieldOptions();
113 +    int mdFileVersion;
114 +    rCut_ = 0.0; //Needs a value for a later max() call;  
115      
116 +    if (simParams_->haveMDfileVersion())
117 +      mdFileVersion = simParams_->getMDfileVersion();
118 +    else
119 +      mdFileVersion = 0;
120 +  
121      if (simParams_->haveCutoffRadius()) {
122        rCut_ = simParams_->getCutoffRadius();
123      } else {      
# Line 166 | Line 175 | namespace OpenMD {
175          cutoffMethod_ = i->second;
176        }
177      } else {
178 <      sprintf(painCave.errMsg,
179 <              "ForceManager::setupCutoffs: No value was set for the cutoffMethod.\n"
180 <              "\tOpenMD will use SHIFTED_FORCE.\n");
181 <      painCave.isFatal = 0;
182 <      painCave.severity = OPENMD_INFO;
183 <      simError();
184 <      cutoffMethod_ = SHIFTED_FORCE;        
178 >      if (mdFileVersion > 1) {
179 >        sprintf(painCave.errMsg,
180 >                "ForceManager::setupCutoffs: No value was set for the cutoffMethod.\n"
181 >                "\tOpenMD will use SHIFTED_FORCE.\n");
182 >        painCave.isFatal = 0;
183 >        painCave.severity = OPENMD_INFO;
184 >        simError();
185 >        cutoffMethod_ = SHIFTED_FORCE;        
186 >      } else {
187 >        // handle the case where the old file version was in play
188 >        // (there should be no cutoffMethod, so we have to deduce it
189 >        // from other data).        
190 >
191 >        sprintf(painCave.errMsg,
192 >                "ForceManager::setupCutoffs : DEPRECATED FILE FORMAT!\n"
193 >                "\tOpenMD found a file which does not set a cutoffMethod.\n"
194 >                "\tOpenMD will attempt to deduce a cutoffMethod using the\n"
195 >                "\tbehavior of the older (version 1) code.  To remove this\n"
196 >                "\twarning, add an explicit cutoffMethod and change the top\n"
197 >                "\tof the file so that it begins with <OpenMD version=2>\n");
198 >        painCave.isFatal = 0;
199 >        painCave.severity = OPENMD_WARNING;
200 >        simError();            
201 >                
202 >        // The old file version tethered the shifting behavior to the
203 >        // electrostaticSummationMethod keyword.
204 >        
205 >        if (simParams_->haveElectrostaticSummationMethod()) {
206 >          string myMethod = simParams_->getElectrostaticSummationMethod();
207 >          toUpper(myMethod);
208 >        
209 >          if (myMethod == "SHIFTED_POTENTIAL") {
210 >            cutoffMethod_ = SHIFTED_POTENTIAL;
211 >          } else if (myMethod == "SHIFTED_FORCE") {
212 >            cutoffMethod_ = SHIFTED_FORCE;
213 >          }
214 >        
215 >          if (simParams_->haveSwitchingRadius())
216 >            rSwitch_ = simParams_->getSwitchingRadius();
217 >
218 >          if (myMethod == "SHIFTED_POTENTIAL" || myMethod == "SHIFTED_FORCE") {
219 >            if (simParams_->haveSwitchingRadius()){
220 >              sprintf(painCave.errMsg,
221 >                      "ForceManager::setupCutoffs : DEPRECATED ERROR MESSAGE\n"
222 >                      "\tA value was set for the switchingRadius\n"
223 >                      "\teven though the electrostaticSummationMethod was\n"
224 >                      "\tset to %s\n", myMethod.c_str());
225 >              painCave.severity = OPENMD_WARNING;
226 >              painCave.isFatal = 1;
227 >              simError();            
228 >            }
229 >          }
230 >          if (abs(rCut_ - rSwitch_) < 0.0001) {
231 >            if (cutoffMethod_ == SHIFTED_FORCE) {              
232 >              sprintf(painCave.errMsg,
233 >                      "ForceManager::setupCutoffs : DEPRECATED BEHAVIOR\n"
234 >                      "\tcutoffRadius and switchingRadius are set to the\n"
235 >                      "\tsame value.  OpenMD will use shifted force\n"
236 >                      "\tpotentials instead of switching functions.\n");
237 >              painCave.isFatal = 0;
238 >              painCave.severity = OPENMD_WARNING;
239 >              simError();            
240 >            } else {
241 >              cutoffMethod_ = SHIFTED_POTENTIAL;
242 >              sprintf(painCave.errMsg,
243 >                      "ForceManager::setupCutoffs : DEPRECATED BEHAVIOR\n"
244 >                      "\tcutoffRadius and switchingRadius are set to the\n"
245 >                      "\tsame value.  OpenMD will use shifted potentials\n"
246 >                      "\tinstead of switching functions.\n");
247 >              painCave.isFatal = 0;
248 >              painCave.severity = OPENMD_WARNING;
249 >              simError();            
250 >            }
251 >          }
252 >        }
253 >      }
254      }
255  
256      map<string, CutoffPolicy> stringToCutoffPolicy;
# Line 180 | Line 258 | namespace OpenMD {
258      stringToCutoffPolicy["MAX"] = MAX;
259      stringToCutoffPolicy["TRADITIONAL"] = TRADITIONAL;    
260  
261 <    std::string cutPolicy;
261 >    string cutPolicy;
262      if (forceFieldOptions_.haveCutoffPolicy()){
263        cutPolicy = forceFieldOptions_.getCutoffPolicy();
264      }else if (simParams_->haveCutoffPolicy()) {
# Line 242 | Line 320 | namespace OpenMD {
320          simError();
321        }
322      } else {
323 <      if (simParams_->haveSwitchingRadius()) {
324 <        map<string, CutoffMethod>::const_iterator it;
325 <        string theMeth;
326 <        for (it = stringToCutoffMethod.begin();
327 <             it != stringToCutoffMethod.end(); ++it) {
328 <          if (it->second == cutoffMethod_) {
329 <            theMeth = it->first;
330 <            break;
323 >      if (mdFileVersion > 1) {
324 >        // throw an error if we define a switching radius and don't need one.
325 >        // older file versions should not do this.
326 >        if (simParams_->haveSwitchingRadius()) {
327 >          map<string, CutoffMethod>::const_iterator it;
328 >          string theMeth;
329 >          for (it = stringToCutoffMethod.begin();
330 >               it != stringToCutoffMethod.end(); ++it) {
331 >            if (it->second == cutoffMethod_) {
332 >              theMeth = it->first;
333 >              break;
334 >            }
335            }
336 +          sprintf(painCave.errMsg,
337 +                  "ForceManager::setupCutoffs: the cutoffMethod (%s)\n"
338 +                  "\tis not set to SWITCHED, so switchingRadius value\n"
339 +                  "\twill be ignored for this simulation\n", theMeth.c_str());
340 +          painCave.isFatal = 0;
341 +          painCave.severity = OPENMD_WARNING;
342 +          simError();
343          }
255 –        sprintf(painCave.errMsg,
256 –                "ForceManager::setupCutoffs: the cutoffMethod (%s)\n"
257 –                "\tis not set to SWITCHED, so switchingRadius value\n"
258 –                "\twill be ignored for this simulation\n", theMeth.c_str());
259 –        painCave.isFatal = 0;
260 –        painCave.severity = OPENMD_WARNING;
261 –        simError();
344        }
263 –
345        rSwitch_ = rCut_;
346      }
347      
# Line 289 | Line 370 | namespace OpenMD {
370      }
371      switcher_->setSwitchType(sft_);
372      switcher_->setSwitch(rSwitch_, rCut_);
292 –    interactionMan_->setSwitchingRadius(rSwitch_);
373    }
374 +
375 +
376 +
377    
378    void ForceManager::initialize() {
379  
# Line 306 | Line 389 | namespace OpenMD {
389        setupCutoffs();
390  
391        info_->prepareTopology();      
392 +
393 +      doParticlePot_ = info_->getSimParams()->getOutputParticlePotential();
394 +      doHeatFlux_ = info_->getSimParams()->getPrintHeatFlux();
395 +      if (doHeatFlux_) doParticlePot_ = true;
396 +
397 +      doElectricField_ = info_->getSimParams()->getOutputElectricField();
398 +  
399      }
400  
401      ForceFieldOptions& fopts = forceField_->getForceFieldOptions();
# Line 335 | Line 425 | namespace OpenMD {
425      electrostaticScale_[2] = fopts.getelectrostatic13scale();
426      electrostaticScale_[3] = fopts.getelectrostatic14scale();    
427      
428 +    if (info_->getSimParams()->haveElectricField()) {
429 +      ElectricField* eField = new ElectricField(info_);
430 +      perturbations_.push_back(eField);
431 +    }
432 +
433      fDecomp_->distributeInitialData();
434  
435      initialized_ = true;
# Line 361 | Line 456 | namespace OpenMD {
456      Molecule::CutoffGroupIterator ci;
457      CutoffGroup* cg;
458      
459 <    // forces are zeroed here, before any are accumulated.
459 >    // forces and potentials are zeroed here, before any are
460 >    // accumulated.
461      
462 +    Snapshot* snap = info_->getSnapshotManager()->getCurrentSnapshot();
463 +
464 +    snap->setBondPotential(0.0);
465 +    snap->setBendPotential(0.0);
466 +    snap->setTorsionPotential(0.0);
467 +    snap->setInversionPotential(0.0);
468 +
469 +    potVec zeroPot(0.0);
470 +    snap->setLongRangePotential(zeroPot);
471 +    snap->setExcludedPotentials(zeroPot);
472 +
473 +    snap->setRestraintPotential(0.0);
474 +    snap->setRawPotential(0.0);
475 +
476      for (mol = info_->beginMolecule(mi); mol != NULL;
477           mol = info_->nextMolecule(mi)) {
478        for(atom = mol->beginAtom(ai); atom != NULL;
# Line 386 | Line 496 | namespace OpenMD {
496      }
497      
498      // Zero out the stress tensor
499 <    tau *= 0.0;
500 <    
499 >    stressTensor *= 0.0;
500 >    // Zero out the heatFlux
501 >    fDecomp_->setHeatFlux( Vector3d(0.0) );    
502    }
503    
504    void ForceManager::shortRangeInteractions() {
# Line 420 | Line 531 | namespace OpenMD {
531  
532        for (bond = mol->beginBond(bondIter); bond != NULL;
533             bond = mol->nextBond(bondIter)) {
534 <        bond->calcForce();
534 >        bond->calcForce(doParticlePot_);
535          bondPotential += bond->getPotential();
536        }
537  
# Line 428 | Line 539 | namespace OpenMD {
539             bend = mol->nextBend(bendIter)) {
540          
541          RealType angle;
542 <        bend->calcForce(angle);
542 >        bend->calcForce(angle, doParticlePot_);
543          RealType currBendPot = bend->getPotential();          
544          
545          bendPotential += bend->getPotential();
# Line 453 | Line 564 | namespace OpenMD {
564        for (torsion = mol->beginTorsion(torsionIter); torsion != NULL;
565             torsion = mol->nextTorsion(torsionIter)) {
566          RealType angle;
567 <        torsion->calcForce(angle);
567 >        torsion->calcForce(angle, doParticlePot_);
568          RealType currTorsionPot = torsion->getPotential();
569          torsionPotential += torsion->getPotential();
570          map<Torsion*, TorsionDataSet>::iterator i = torsionDataSets.find(torsion);
# Line 477 | Line 588 | namespace OpenMD {
588             inversion != NULL;
589             inversion = mol->nextInversion(inversionIter)) {
590          RealType angle;
591 <        inversion->calcForce(angle);
591 >        inversion->calcForce(angle, doParticlePot_);
592          RealType currInversionPot = inversion->getPotential();
593          inversionPotential += inversion->getPotential();
594          map<Inversion*, InversionDataSet>::iterator i = inversionDataSets.find(inversion);
# Line 497 | Line 608 | namespace OpenMD {
608          }      
609        }      
610      }
611 <    
612 <    RealType  shortRangePotential = bondPotential + bendPotential +
613 <      torsionPotential +  inversionPotential;    
611 >
612 > #ifdef IS_MPI
613 >    // Collect from all nodes.  This should eventually be moved into a
614 >    // SystemDecomposition, but this is a better place than in
615 >    // Thermo to do the collection.
616 >    MPI::COMM_WORLD.Allreduce(MPI::IN_PLACE, &bondPotential, 1, MPI::REALTYPE,
617 >                              MPI::SUM);
618 >    MPI::COMM_WORLD.Allreduce(MPI::IN_PLACE, &bendPotential, 1, MPI::REALTYPE,
619 >                              MPI::SUM);
620 >    MPI::COMM_WORLD.Allreduce(MPI::IN_PLACE, &torsionPotential, 1,
621 >                              MPI::REALTYPE, MPI::SUM);
622 >    MPI::COMM_WORLD.Allreduce(MPI::IN_PLACE, &inversionPotential, 1,
623 >                              MPI::REALTYPE, MPI::SUM);
624 > #endif
625 >
626      Snapshot* curSnapshot = info_->getSnapshotManager()->getCurrentSnapshot();
627 <    curSnapshot->statData[Stats::SHORT_RANGE_POTENTIAL] = shortRangePotential;
628 <    curSnapshot->statData[Stats::BOND_POTENTIAL] = bondPotential;
629 <    curSnapshot->statData[Stats::BEND_POTENTIAL] = bendPotential;
630 <    curSnapshot->statData[Stats::DIHEDRAL_POTENTIAL] = torsionPotential;
631 <    curSnapshot->statData[Stats::INVERSION_POTENTIAL] = inversionPotential;    
627 >
628 >    curSnapshot->setBondPotential(bondPotential);
629 >    curSnapshot->setBendPotential(bendPotential);
630 >    curSnapshot->setTorsionPotential(torsionPotential);
631 >    curSnapshot->setInversionPotential(inversionPotential);
632 >    
633 >    // RealType shortRangePotential = bondPotential + bendPotential +
634 >    //   torsionPotential +  inversionPotential;    
635 >
636 >    // curSnapshot->setShortRangePotential(shortRangePotential);
637    }
638    
639    void ForceManager::longRangeInteractions() {
640  
641 +
642      Snapshot* curSnapshot = info_->getSnapshotManager()->getCurrentSnapshot();
643      DataStorage* config = &(curSnapshot->atomData);
644      DataStorage* cgConfig = &(curSnapshot->cgData);
# Line 533 | Line 662 | namespace OpenMD {
662        // center of mass of the group is the same as position of the atom  
663        // if cutoff group does not exist
664        cgConfig->position = config->position;
665 +      cgConfig->velocity = config->velocity;
666      }
667  
668      fDecomp_->zeroWorkArrays();
669      fDecomp_->distributeData();
670      
671      int cg1, cg2, atom1, atom2, topoDist;
672 <    Vector3d d_grp, dag, d;
672 >    Vector3d d_grp, dag, d, gvel2, vel2;
673      RealType rgrpsq, rgrp, r2, r;
674      RealType electroMult, vdwMult;
675      RealType vij;
# Line 552 | Line 682 | namespace OpenMD {
682      InteractionData idat;
683      SelfData sdat;
684      RealType mf;
555 –    RealType lrPot;
685      RealType vpair;
686 +    RealType dVdFQ1(0.0);
687 +    RealType dVdFQ2(0.0);
688      potVec longRangePotential(0.0);
689      potVec workPot(0.0);
690 +    potVec exPot(0.0);
691 +    Vector3d eField1(0.0);
692 +    Vector3d eField2(0.0);
693 +    vector<int>::iterator ia, jb;
694  
695      int loopStart, loopEnd;
696  
697      idat.vdwMult = &vdwMult;
698      idat.electroMult = &electroMult;
699      idat.pot = &workPot;
700 +    idat.excludedPot = &exPot;
701      sdat.pot = fDecomp_->getEmbeddingPotential();
702 +    sdat.excludedPot = fDecomp_->getExcludedSelfPotential();
703      idat.vpair = &vpair;
704 +    idat.dVdFQ1 = &dVdFQ1;
705 +    idat.dVdFQ2 = &dVdFQ2;
706 +    idat.eField1 = &eField1;
707 +    idat.eField2 = &eField2;  
708      idat.f1 = &f1;
709      idat.sw = &sw;
710      idat.shiftedPot = (cutoffMethod_ == SHIFTED_POTENTIAL) ? true : false;
711      idat.shiftedForce = (cutoffMethod_ == SHIFTED_FORCE) ? true : false;
712 +    idat.doParticlePot = doParticlePot_;
713 +    idat.doElectricField = doElectricField_;
714 +    sdat.doParticlePot = doParticlePot_;
715      
716      loopEnd = PAIR_LOOP;
717      if (info_->requiresPrepair() ) {
# Line 575 | Line 719 | namespace OpenMD {
719      } else {
720        loopStart = PAIR_LOOP;
721      }
578 –  
722      for (int iLoop = loopStart; iLoop <= loopEnd; iLoop++) {
723      
724        if (iLoop == loopStart) {
725          bool update_nlist = fDecomp_->checkNeighborList();
726          if (update_nlist)
727            neighborList = fDecomp_->buildNeighborList();
728 <      }      
729 <        
728 >      }            
729 >
730        for (vector<pair<int, int> >::iterator it = neighborList.begin();
731               it != neighborList.end(); ++it) {
732                  
# Line 593 | Line 736 | namespace OpenMD {
736          cuts = fDecomp_->getGroupCutoffs(cg1, cg2);
737  
738          d_grp  = fDecomp_->getIntergroupVector(cg1, cg2);
739 +
740          curSnapshot->wrapVector(d_grp);        
741          rgrpsq = d_grp.lengthSquare();
598 –
742          rCutSq = cuts.second;
743  
744          if (rgrpsq < rCutSq) {
# Line 607 | Line 750 | namespace OpenMD {
750            
751            in_switching_region = switcher_->getSwitch(rgrpsq, sw, dswdr,
752                                                       rgrp);
753 <              
753 >
754            atomListRow = fDecomp_->getAtomsInGroupRow(cg1);
755            atomListColumn = fDecomp_->getAtomsInGroupColumn(cg2);
756  
757 <          for (vector<int>::iterator ia = atomListRow.begin();
757 >          if (doHeatFlux_)
758 >            gvel2 = fDecomp_->getGroupVelocityColumn(cg2);
759 >
760 >          for (ia = atomListRow.begin();
761                 ia != atomListRow.end(); ++ia) {            
762              atom1 = (*ia);
763 <            
764 <            for (vector<int>::iterator jb = atomListColumn.begin();
763 >
764 >            for (jb = atomListColumn.begin();
765                   jb != atomListColumn.end(); ++jb) {              
766                atom2 = (*jb);
767  
768 <              if (!fDecomp_->skipAtomPair(atom1, atom2)) {
768 >              if (!fDecomp_->skipAtomPair(atom1, atom2, cg1, cg2)) {
769 >
770                  vpair = 0.0;
771                  workPot = 0.0;
772 +                exPot = 0.0;
773                  f1 = V3Zero;
774 +                dVdFQ1 = 0.0;
775 +                dVdFQ2 = 0.0;
776  
777                  fDecomp_->fillInteractionData(idat, atom1, atom2);
778 <                
778 >
779                  topoDist = fDecomp_->getTopologicalDistance(atom1, atom2);
780                  vdwMult = vdwScale_[topoDist];
781                  electroMult = electrostaticScale_[topoDist];
# Line 633 | Line 783 | namespace OpenMD {
783                  if (atomListRow.size() == 1 && atomListColumn.size() == 1) {
784                    idat.d = &d_grp;
785                    idat.r2 = &rgrpsq;
786 +                  if (doHeatFlux_)
787 +                    vel2 = gvel2;
788                  } else {
789                    d = fDecomp_->getInteratomicVector(atom1, atom2);
790                    curSnapshot->wrapVector( d );
791                    r2 = d.lengthSquare();
792                    idat.d = &d;
793                    idat.r2 = &r2;
794 +                  if (doHeatFlux_)
795 +                    vel2 = fDecomp_->getAtomVelocityColumn(atom2);
796                  }
797                
798                  r = sqrt( *(idat.r2) );
# Line 649 | Line 803 | namespace OpenMD {
803                  } else {
804                    interactionMan_->doPair(idat);
805                    fDecomp_->unpackInteractionData(idat, atom1, atom2);
652 –
806                    vij += vpair;
807                    fij += f1;
808 <                  tau -= outProduct( *(idat.d), f1);
808 >                  stressTensor -= outProduct( *(idat.d), f1);
809 >                  if (doHeatFlux_)
810 >                    fDecomp_->addToHeatFlux(*(idat.d) * dot(f1, vel2));
811                  }
812                }
813              }
# Line 665 | Line 820 | namespace OpenMD {
820                fij += fg;
821  
822                if (atomListRow.size() == 1 && atomListColumn.size() == 1) {
823 <                tau -= outProduct( *(idat.d), fg);
823 >                stressTensor -= outProduct( *(idat.d), fg);
824 >                if (doHeatFlux_)
825 >                  fDecomp_->addToHeatFlux(*(idat.d) * dot(fg, vel2));
826 >                
827                }
828            
829 <              for (vector<int>::iterator ia = atomListRow.begin();
829 >              for (ia = atomListRow.begin();
830                     ia != atomListRow.end(); ++ia) {            
831                  atom1 = (*ia);                
832                  mf = fDecomp_->getMassFactorRow(atom1);
# Line 676 | Line 834 | namespace OpenMD {
834                  // presence in switching region
835                  fg = swderiv * d_grp * mf;
836                  fDecomp_->addForceToAtomRow(atom1, fg);
679 –
837                  if (atomListRow.size() > 1) {
838                    if (info_->usesAtomicVirial()) {
839                      // find the distance between the atom
840                      // and the center of the cutoff group:
841                      dag = fDecomp_->getAtomToGroupVectorRow(atom1, cg1);
842 <                    tau -= outProduct(dag, fg);
842 >                    stressTensor -= outProduct(dag, fg);
843 >                    if (doHeatFlux_)
844 >                      fDecomp_->addToHeatFlux( dag * dot(fg, vel2));
845                    }
846                  }
847                }
848 <              for (vector<int>::iterator jb = atomListColumn.begin();
848 >              for (jb = atomListColumn.begin();
849                     jb != atomListColumn.end(); ++jb) {              
850                  atom2 = (*jb);
851                  mf = fDecomp_->getMassFactorColumn(atom2);
# Line 700 | Line 859 | namespace OpenMD {
859                      // find the distance between the atom
860                      // and the center of the cutoff group:
861                      dag = fDecomp_->getAtomToGroupVectorColumn(atom2, cg2);
862 <                    tau -= outProduct(dag, fg);
862 >                    stressTensor -= outProduct(dag, fg);
863 >                    if (doHeatFlux_)
864 >                      fDecomp_->addToHeatFlux( dag * dot(fg, vel2));
865                    }
866                  }
867                }
868              }
869 <            //if (!SIM_uses_AtomicVirial) {
870 <            //  tau -= outProduct(d_grp, fij);
869 >            //if (!info_->usesAtomicVirial()) {
870 >            //  stressTensor -= outProduct(d_grp, fij);
871 >            //  if (doHeatFlux_)
872 >            //     fDecomp_->addToHeatFlux( d_grp * dot(fij, vel2));
873              //}
874            }
875          }
# Line 717 | Line 880 | namespace OpenMD {
880  
881            fDecomp_->collectIntermediateData();
882  
883 <          for (int atom1 = 0; atom1 < info_->getNAtoms(); atom1++) {
883 >          for (unsigned int atom1 = 0; atom1 < info_->getNAtoms(); atom1++) {
884              fDecomp_->fillSelfData(sdat, atom1);
885              interactionMan_->doPreForce(sdat);
886            }
# Line 726 | Line 889 | namespace OpenMD {
889  
890          }
891        }
729 –
892      }
893      
894 +    // collects pairwise information
895      fDecomp_->collectData();
896          
897      if (info_->requiresSelfCorrection()) {
898 <
736 <      for (int atom1 = 0; atom1 < info_->getNAtoms(); atom1++) {          
898 >      for (unsigned int atom1 = 0; atom1 < info_->getNAtoms(); atom1++) {
899          fDecomp_->fillSelfData(sdat, atom1);
900          interactionMan_->doSelfCorrection(sdat);
901        }
740 –
902      }
903  
904 +    // collects single-atom information
905 +    fDecomp_->collectSelfData();
906 +
907      longRangePotential = *(fDecomp_->getEmbeddingPotential()) +
908        *(fDecomp_->getPairwisePotential());
909  
910 <    lrPot = longRangePotential.sum();
910 >    curSnapshot->setLongRangePotential(longRangePotential);
911 >    
912 >    curSnapshot->setExcludedPotentials(*(fDecomp_->getExcludedSelfPotential()) +
913 >                                         *(fDecomp_->getExcludedPotential()));
914  
748 –    //store the tau and long range potential    
749 –    curSnapshot->statData[Stats::LONG_RANGE_POTENTIAL] = lrPot;
750 –    curSnapshot->statData[Stats::VANDERWAALS_POTENTIAL] = longRangePotential[VANDERWAALS_FAMILY];
751 –    curSnapshot->statData[Stats::ELECTROSTATIC_POTENTIAL] = longRangePotential[ELECTROSTATIC_FAMILY];
915    }
916  
917    
918    void ForceManager::postCalculation() {
919 +
920 +    vector<Perturbation*>::iterator pi;
921 +    for (pi = perturbations_.begin(); pi != perturbations_.end(); ++pi) {
922 +      (*pi)->applyPerturbation();
923 +    }
924 +
925      SimInfo::MoleculeIterator mi;
926      Molecule* mol;
927      Molecule::RigidBodyIterator rbIter;
928      RigidBody* rb;
929      Snapshot* curSnapshot = info_->getSnapshotManager()->getCurrentSnapshot();
930 <    
930 >  
931      // collect the atomic forces onto rigid bodies
932      
933      for (mol = info_->beginMolecule(mi); mol != NULL;
# Line 766 | Line 935 | namespace OpenMD {
935        for (rb = mol->beginRigidBody(rbIter); rb != NULL;
936             rb = mol->nextRigidBody(rbIter)) {
937          Mat3x3d rbTau = rb->calcForcesAndTorquesAndVirial();
938 <        tau += rbTau;
938 >        stressTensor += rbTau;
939        }
940      }
941      
942   #ifdef IS_MPI
943 <    Mat3x3d tmpTau(tau);
944 <    MPI_Allreduce(tmpTau.getArrayPointer(), tau.getArrayPointer(),
776 <                  9, MPI_REALTYPE, MPI_SUM, MPI_COMM_WORLD);
943 >    MPI::COMM_WORLD.Allreduce(MPI::IN_PLACE, stressTensor.getArrayPointer(), 9,
944 >                              MPI::REALTYPE, MPI::SUM);
945   #endif
946 <    curSnapshot->statData.setTau(tau);
946 >    curSnapshot->setStressTensor(stressTensor);
947 >    
948    }
780 –
949   } //end namespace OpenMD

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines