ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/OpenMD/branches/development/src/parallel/ForceMatrixDecomposition.cpp
(Generate patch)

Comparing branches/development/src/parallel/ForceMatrixDecomposition.cpp (file contents):
Revision 1760 by gezelter, Thu Jun 21 19:26:46 2012 UTC vs.
Revision 1787 by gezelter, Wed Aug 29 18:13:11 2012 UTC

# Line 310 | Line 310 | namespace OpenMD {
310      
311      RealType tol = 1e-6;
312      largestRcut_ = 0.0;
313 –    RealType rc;
313      int atid;
314      set<AtomType*> atypes = info_->getSimulatedAtomTypes();
315      
# Line 395 | Line 394 | namespace OpenMD {
394        }
395        
396        bool gTypeFound = false;
397 <      for (int gt = 0; gt < gTypeCutoffs.size(); gt++) {
397 >      for (unsigned int gt = 0; gt < gTypeCutoffs.size(); gt++) {
398          if (abs(groupCutoff[cg1] - gTypeCutoffs[gt]) < tol) {
399            groupToGtype[cg1] = gt;
400            gTypeFound = true;
# Line 420 | Line 419 | namespace OpenMD {
419      
420      RealType tradRcut = groupMax;
421  
422 <    for (int i = 0; i < gTypeCutoffs.size();  i++) {
423 <      for (int j = 0; j < gTypeCutoffs.size();  j++) {      
422 >    for (unsigned int i = 0; i < gTypeCutoffs.size();  i++) {
423 >      for (unsigned int j = 0; j < gTypeCutoffs.size();  j++) {      
424          RealType thisRcut;
425          switch(cutoffPolicy_) {
426          case TRADITIONAL:
# Line 477 | Line 476 | namespace OpenMD {
476    }
477  
478    int ForceMatrixDecomposition::getTopologicalDistance(int atom1, int atom2) {
479 <    for (int j = 0; j < toposForAtom[atom1].size(); j++) {
479 >    for (unsigned int j = 0; j < toposForAtom[atom1].size(); j++) {
480        if (toposForAtom[atom1][j] == atom2)
481          return topoDist[atom1][j];
482      }
# Line 488 | Line 487 | namespace OpenMD {
487      pairwisePot = 0.0;
488      embeddingPot = 0.0;
489      excludedPot = 0.0;
490 +    excludedSelfPot = 0.0;
491  
492   #ifdef IS_MPI
493      if (storageLayout_ & DataStorage::dslForce) {
# Line 557 | Line 557 | namespace OpenMD {
557             atomRowData.electricField.end(), V3Zero);
558        fill(atomColData.electricField.begin(),
559             atomColData.electricField.end(), V3Zero);
560 –    }
561 –
562 –    if (storageLayout_ & DataStorage::dslFlucQForce) {    
563 –      fill(atomRowData.flucQFrc.begin(), atomRowData.flucQFrc.end(),
564 –           0.0);
565 –      fill(atomColData.flucQFrc.begin(), atomColData.flucQFrc.end(),
566 –           0.0);
560      }
561  
562   #endif
# Line 639 | Line 632 | namespace OpenMD {
632        AtomPlanMatrixColumn->gather(snap_->atomData.aMat,
633                                     atomColData.aMat);
634      }
635 <    
636 <    // if needed, gather the atomic eletrostatic frames
637 <    if (storageLayout_ & DataStorage::dslElectroFrame) {
638 <      AtomPlanMatrixRow->gather(snap_->atomData.electroFrame,
639 <                                atomRowData.electroFrame);
640 <      AtomPlanMatrixColumn->gather(snap_->atomData.electroFrame,
641 <                                   atomColData.electroFrame);
635 >
636 >    // if needed, gather the atomic eletrostatic information
637 >    if (storageLayout_ & DataStorage::dslDipole) {
638 >      AtomPlanVectorRow->gather(snap_->atomData.dipole,
639 >                                atomRowData.dipole);
640 >      AtomPlanVectorColumn->gather(snap_->atomData.dipole,
641 >                                   atomColData.dipole);
642      }
643  
644 +    if (storageLayout_ & DataStorage::dslQuadrupole) {
645 +      AtomPlanMatrixRow->gather(snap_->atomData.quadrupole,
646 +                                atomRowData.quadrupole);
647 +      AtomPlanMatrixColumn->gather(snap_->atomData.quadrupole,
648 +                                   atomColData.quadrupole);
649 +    }
650 +        
651      // if needed, gather the atomic fluctuating charge values
652      if (storageLayout_ & DataStorage::dslFlucQPosition) {
653        AtomPlanRealRow->gather(snap_->atomData.flucQPos,
# Line 906 | Line 906 | namespace OpenMD {
906        RealType ploc2 = 0.0;
907        MPI::COMM_WORLD.Allreduce(&ploc1, &ploc2, 1, MPI::REALTYPE, MPI::SUM);
908        embeddingPot[ii] = ploc2;
909 +    }    
910 +    for (int ii = 0; ii < N_INTERACTION_FAMILIES; ii++) {
911 +      RealType ploc1 = excludedSelfPot[ii];
912 +      RealType ploc2 = 0.0;
913 +      MPI::COMM_WORLD.Allreduce(&ploc1, &ploc2, 1, MPI::REALTYPE, MPI::SUM);
914 +      excludedSelfPot[ii] = ploc2;
915      }    
916   #endif
917      
# Line 1126 | Line 1132 | namespace OpenMD {
1132        idat.A2 = &(atomColData.aMat[atom2]);
1133      }
1134      
1129 –    if (storageLayout_ & DataStorage::dslElectroFrame) {
1130 –      idat.eFrame1 = &(atomRowData.electroFrame[atom1]);
1131 –      idat.eFrame2 = &(atomColData.electroFrame[atom2]);
1132 –    }
1133 –
1135      if (storageLayout_ & DataStorage::dslTorque) {
1136        idat.t1 = &(atomRowData.torque[atom1]);
1137        idat.t2 = &(atomColData.torque[atom2]);
1138      }
1139  
1140 +    if (storageLayout_ & DataStorage::dslDipole) {
1141 +      idat.dipole1 = &(atomRowData.dipole[atom1]);
1142 +      idat.dipole2 = &(atomColData.dipole[atom2]);
1143 +    }
1144 +
1145 +    if (storageLayout_ & DataStorage::dslQuadrupole) {
1146 +      idat.quadrupole1 = &(atomRowData.quadrupole[atom1]);
1147 +      idat.quadrupole2 = &(atomColData.quadrupole[atom2]);
1148 +    }
1149 +
1150      if (storageLayout_ & DataStorage::dslDensity) {
1151        idat.rho1 = &(atomRowData.density[atom1]);
1152        idat.rho2 = &(atomColData.density[atom2]);
# Line 1175 | Line 1186 | namespace OpenMD {
1186        idat.A2 = &(snap_->atomData.aMat[atom2]);
1187      }
1188  
1178 –    if (storageLayout_ & DataStorage::dslElectroFrame) {
1179 –      idat.eFrame1 = &(snap_->atomData.electroFrame[atom1]);
1180 –      idat.eFrame2 = &(snap_->atomData.electroFrame[atom2]);
1181 –    }
1182 –
1189      if (storageLayout_ & DataStorage::dslTorque) {
1190        idat.t1 = &(snap_->atomData.torque[atom1]);
1191        idat.t2 = &(snap_->atomData.torque[atom2]);
1192 +    }
1193 +
1194 +    if (storageLayout_ & DataStorage::dslDipole) {
1195 +      idat.dipole1 = &(snap_->atomData.dipole[atom1]);
1196 +      idat.dipole2 = &(snap_->atomData.dipole[atom2]);
1197      }
1198  
1199 +    if (storageLayout_ & DataStorage::dslQuadrupole) {
1200 +      idat.quadrupole1 = &(snap_->atomData.quadrupole[atom1]);
1201 +      idat.quadrupole2 = &(snap_->atomData.quadrupole[atom2]);
1202 +    }
1203 +
1204      if (storageLayout_ & DataStorage::dslDensity) {    
1205        idat.rho1 = &(snap_->atomData.density[atom1]);
1206        idat.rho2 = &(snap_->atomData.density[atom2]);
# Line 1333 | Line 1349 | namespace OpenMD {
1349          for (int j = 0; j < 3; j++) {
1350            scaled[j] -= roundMe(scaled[j]);
1351            scaled[j] += 0.5;
1352 +          // Handle the special case when an object is exactly on the
1353 +          // boundary (a scaled coordinate of 1.0 is the same as
1354 +          // scaled coordinate of 0.0)
1355 +          if (scaled[j] >= 1.0) scaled[j] -= 1.0;
1356          }
1357          
1358          // find xyz-indices of cell that cutoffGroup is in.
# Line 1357 | Line 1377 | namespace OpenMD {
1377          for (int j = 0; j < 3; j++) {
1378            scaled[j] -= roundMe(scaled[j]);
1379            scaled[j] += 0.5;
1380 +          // Handle the special case when an object is exactly on the
1381 +          // boundary (a scaled coordinate of 1.0 is the same as
1382 +          // scaled coordinate of 0.0)
1383 +          if (scaled[j] >= 1.0) scaled[j] -= 1.0;
1384          }
1385          
1386          // find xyz-indices of cell that cutoffGroup is in.
# Line 1383 | Line 1407 | namespace OpenMD {
1407          for (int j = 0; j < 3; j++) {
1408            scaled[j] -= roundMe(scaled[j]);
1409            scaled[j] += 0.5;
1410 +          // Handle the special case when an object is exactly on the
1411 +          // boundary (a scaled coordinate of 1.0 is the same as
1412 +          // scaled coordinate of 0.0)
1413 +          if (scaled[j] >= 1.0) scaled[j] -= 1.0;
1414          }
1415          
1416          // find xyz-indices of cell that cutoffGroup is in.

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines