--- trunk/src/brains/MoleculeCreator.cpp 2009/11/25 20:02:06 1390 +++ trunk/src/brains/MoleculeCreator.cpp 2014/04/05 20:56:01 1979 @@ -35,15 +35,15 @@ * * [1] Meineke, et al., J. Comp. Chem. 26, 252-271 (2005). * [2] Fennell & Gezelter, J. Chem. Phys. 124, 234104 (2006). - * [3] Sun, Lin & Gezelter, J. Chem. Phys. 128, 24107 (2008). - * [4] Vardeman & Gezelter, in progress (2009). + * [3] Sun, Lin & Gezelter, J. Chem. Phys. 128, 234107 (2008). + * [4] Kuang & Gezelter, J. Chem. Phys. 133, 164101 (2010). + * [5] Vardeman, Stocker & Gezelter, J. Chem. Theory Comput. 7, 834 (2011). */ /** * @file MoleculeCreator.cpp * @author tlin * @date 11/04/2004 - * @time 13:44am * @version 1.0 */ @@ -54,7 +54,7 @@ #include "brains/MoleculeCreator.hpp" #include "primitives/GhostBend.hpp" #include "primitives/GhostTorsion.hpp" -#include "types/DirectionalAtomType.hpp" +#include "types/AtomType.hpp" #include "types/FixedBondType.hpp" #include "utils/simError.h" #include "utils/StringUtils.hpp" @@ -65,8 +65,9 @@ namespace OpenMD { MoleculeStamp *molStamp, int stampId, int globalIndex, LocalIndexManager* localIndexMan) { - Molecule* mol = new Molecule(stampId, globalIndex, molStamp->getName()); - + Molecule* mol = new Molecule(stampId, globalIndex, molStamp->getName(), + molStamp->getRegion() ); + //create atoms Atom* atom; AtomStamp* currentAtomStamp; @@ -96,7 +97,7 @@ namespace OpenMD { for (int i = 0; i < nBonds; ++i) { currentBondStamp = molStamp->getBondStamp(i); - bond = createBond(ff, mol, currentBondStamp); + bond = createBond(ff, mol, currentBondStamp, localIndexMan); mol->addBond(bond); } @@ -106,7 +107,7 @@ namespace OpenMD { int nBends = molStamp->getNBends(); for (int i = 0; i < nBends; ++i) { currentBendStamp = molStamp->getBendStamp(i); - bend = createBend(ff, mol, currentBendStamp); + bend = createBend(ff, mol, currentBendStamp, localIndexMan); mol->addBend(bend); } @@ -116,7 +117,7 @@ namespace OpenMD { int nTorsions = molStamp->getNTorsions(); for (int i = 0; i < nTorsions; ++i) { currentTorsionStamp = molStamp->getTorsionStamp(i); - torsion = createTorsion(ff, mol, currentTorsionStamp); + torsion = createTorsion(ff, mol, currentTorsionStamp, localIndexMan); mol->addTorsion(torsion); } @@ -126,7 +127,8 @@ namespace OpenMD { int nInversions = molStamp->getNInversions(); for (int i = 0; i < nInversions; ++i) { currentInversionStamp = molStamp->getInversionStamp(i); - inversion = createInversion(ff, mol, currentInversionStamp); + inversion = createInversion(ff, mol, currentInversionStamp, + localIndexMan); if (inversion != NULL ) { mol->addInversion(inversion); } @@ -138,7 +140,8 @@ namespace OpenMD { int nCutoffGroups = molStamp->getNCutoffGroups(); for (int i = 0; i < nCutoffGroups; ++i) { currentCutoffGroupStamp = molStamp->getCutoffGroupStamp(i); - cutoffGroup = createCutoffGroup(mol, currentCutoffGroupStamp); + cutoffGroup = createCutoffGroup(mol, currentCutoffGroupStamp, + localIndexMan); mol->addCutoffGroup(cutoffGroup); } @@ -169,13 +172,58 @@ namespace OpenMD { // every single free atom for (fai = freeAtoms.begin(); fai != freeAtoms.end(); ++fai) { - cutoffGroup = createCutoffGroup(mol, *fai); + cutoffGroup = createCutoffGroup(mol, *fai, localIndexMan); mol->addCutoffGroup(cutoffGroup); } - //create constraints + + //create bonded constraintPairs: createConstraintPair(mol); + + //create non-bonded constraintPairs + for (int i = 0; i < molStamp->getNConstraints(); ++i) { + ConstraintStamp* cStamp = molStamp->getConstraintStamp(i); + Atom* atomA; + Atom* atomB; + + atomA = mol->getAtomAt(cStamp->getA()); + atomB = mol->getAtomAt(cStamp->getB()); + assert( atomA && atomB ); + + RealType distance; + bool printConstraintForce = false; + + if (!cStamp->haveConstrainedDistance()) { + sprintf(painCave.errMsg, + "Constraint Error: A non-bond constraint was specified\n" + "\twithout providing a value for the constrainedDistance.\n"); + painCave.isFatal = 1; + simError(); + } else { + distance = cStamp->getConstrainedDistance(); + } + + if (cStamp->havePrintConstraintForce()) { + printConstraintForce = cStamp->getPrintConstraintForce(); + } + + ConstraintElem* consElemA = new ConstraintElem(atomA); + ConstraintElem* consElemB = new ConstraintElem(atomB); + ConstraintPair* cPair = new ConstraintPair(consElemA, consElemB, distance, + printConstraintForce); + mol->addConstraintPair(cPair); + } + + // now create the constraint elements: + createConstraintElem(mol); + // Does this molecule stamp define a total constrained charge value? + // If so, let the created molecule know about it. + + if (molStamp->haveConstrainTotalCharge() ) { + mol->setConstrainTotalCharge( molStamp->getConstrainTotalCharge() ); + } + //the construction of this molecule is finished mol->complete(); @@ -198,21 +246,12 @@ namespace OpenMD { painCave.isFatal = 1; simError(); } - + //below code still have some kind of hard-coding smell if (atomType->isDirectional()){ - - DirectionalAtomType* dAtomType = dynamic_cast(atomType); - - if (dAtomType == NULL) { - sprintf(painCave.errMsg, "Can not cast AtomType to DirectionalAtomType"); - painCave.isFatal = 1; - simError(); - } - DirectionalAtom* dAtom; - dAtom = new DirectionalAtom(dAtomType); + dAtom = new DirectionalAtom(atomType); atom = dAtom; } else{ @@ -227,7 +266,7 @@ namespace OpenMD { RigidBody* MoleculeCreator::createRigidBody(MoleculeStamp *molStamp, Molecule* mol, RigidBodyStamp* rbStamp, - LocalIndexManager* localIndexMan) { + LocalIndexManager* localIndexMan){ Atom* atom; int nAtoms; Vector3d refCoor; @@ -251,20 +290,20 @@ namespace OpenMD { //set the local index of this rigid body, global index will be set later rb->setLocalIndex(localIndexMan->getNextRigidBodyIndex()); - //the rule for naming rigidbody MoleculeName_RB_Integer - //The first part is the name of the molecule - //The second part is alway fixed as "RB" - //The third part is the index of the rigidbody defined in meta-data file - //For example, Butane_RB_0 is a valid rigid body name of butane molecule - /**@todo replace itoa by lexi_cast */ + // The rule for naming a rigidbody is: MoleculeName_RB_Integer + // The first part is the name of the molecule + // The second part is always fixed as "RB" + // The third part is the index of the rigidbody defined in meta-data file + // For example, Butane_RB_0 is a valid rigid body name of butane molecule + std::string s = OpenMD_itoa(mol->getNRigidBodies(), 10); rb->setType(mol->getType() + "_RB_" + s.c_str()); - return rb; } Bond* MoleculeCreator::createBond(ForceField* ff, Molecule* mol, - BondStamp* stamp) { + BondStamp* stamp, + LocalIndexManager* localIndexMan) { BondType* bondType; Atom* atomA; Atom* atomB; @@ -284,11 +323,25 @@ namespace OpenMD { painCave.isFatal = 1; simError(); } - return new Bond(atomA, atomB, bondType); + Bond* bond = new Bond(atomA, atomB, bondType); + + //set the local index of this bond, the global index will be set later + bond->setLocalIndex(localIndexMan->getNextBondIndex()); + + // The rule for naming a bond is: MoleculeName_Bond_Integer + // The first part is the name of the molecule + // The second part is always fixed as "Bond" + // The third part is the index of the bond defined in meta-data file + // For example, Butane_bond_0 is a valid Bond name in a butane molecule + + std::string s = OpenMD_itoa(mol->getNBonds(), 10); + bond->setName(mol->getType() + "_Bond_" + s.c_str()); + return bond; } Bend* MoleculeCreator::createBend(ForceField* ff, Molecule* mol, - BendStamp* stamp) { + BendStamp* stamp, + LocalIndexManager* localIndexMan) { Bend* bend = NULL; std::vector bendAtoms = stamp->getMembers(); if (bendAtoms.size() == 3) { @@ -303,7 +356,8 @@ namespace OpenMD { atomC->getType().c_str()); if (bendType == NULL) { - sprintf(painCave.errMsg, "Can not find Matching Bend Type for[%s, %s, %s]", + sprintf(painCave.errMsg, + "Can not find Matching Bend Type for[%s, %s, %s]", atomA->getType().c_str(), atomB->getType().c_str(), atomC->getType().c_str()); @@ -327,7 +381,8 @@ namespace OpenMD { BendType* bendType = ff->getBendType(normalAtom->getType(), ghostAtom->getType(), "GHOST"); if (bendType == NULL) { - sprintf(painCave.errMsg, "Can not find Matching Bend Type for[%s, %s, %s]", + sprintf(painCave.errMsg, + "Can not find Matching Bend Type for[%s, %s, %s]", normalAtom->getType().c_str(), ghostAtom->getType().c_str(), "GHOST"); @@ -339,12 +394,24 @@ namespace OpenMD { bend = new GhostBend(normalAtom, ghostAtom, bendType); } - + + //set the local index of this bend, the global index will be set later + bend->setLocalIndex(localIndexMan->getNextBendIndex()); + + // The rule for naming a bend is: MoleculeName_Bend_Integer + // The first part is the name of the molecule + // The second part is always fixed as "Bend" + // The third part is the index of the bend defined in meta-data file + // For example, Butane_Bend_0 is a valid Bend name in a butane molecule + + std::string s = OpenMD_itoa(mol->getNBends(), 10); + bend->setName(mol->getType() + "_Bend_" + s.c_str()); return bend; } Torsion* MoleculeCreator::createTorsion(ForceField* ff, Molecule* mol, - TorsionStamp* stamp) { + TorsionStamp* stamp, + LocalIndexManager* localIndexMan) { Torsion* torsion = NULL; std::vector torsionAtoms = stamp->getMembers(); @@ -366,7 +433,8 @@ namespace OpenMD { atomC->getType(), atomD->getType()); if (torsionType == NULL) { - sprintf(painCave.errMsg, "Can not find Matching Torsion Type for[%s, %s, %s, %s]", + sprintf(painCave.errMsg, + "Can not find Matching Torsion Type for[%s, %s, %s, %s]", atomA->getType().c_str(), atomB->getType().c_str(), atomC->getType().c_str(), @@ -403,12 +471,25 @@ namespace OpenMD { torsion = new GhostTorsion(atomA, atomB, dAtom, torsionType); } + + //set the local index of this torsion, the global index will be set later + torsion->setLocalIndex(localIndexMan->getNextTorsionIndex()); + // The rule for naming a torsion is: MoleculeName_Torsion_Integer + // The first part is the name of the molecule + // The second part is always fixed as "Torsion" + // The third part is the index of the torsion defined in meta-data file + // For example, Butane_Torsion_0 is a valid Torsion name in a + // butane molecule + + std::string s = OpenMD_itoa(mol->getNTorsions(), 10); + torsion->setName(mol->getType() + "_Torsion_" + s.c_str()); return torsion; } Inversion* MoleculeCreator::createInversion(ForceField* ff, Molecule* mol, - InversionStamp* stamp) { + InversionStamp* stamp, + LocalIndexManager* localIndexMan) { Inversion* inversion = NULL; int center = stamp->getCenter(); @@ -444,12 +525,28 @@ namespace OpenMD { } else { inversion = new Inversion(atomA, atomB, atomC, atomD, inversionType); + + // set the local index of this inversion, the global index will + // be set later + inversion->setLocalIndex(localIndexMan->getNextInversionIndex()); + + // The rule for naming an inversion is: MoleculeName_Inversion_Integer + // The first part is the name of the molecule + // The second part is always fixed as "Inversion" + // The third part is the index of the inversion defined in meta-data file + // For example, Benzene_Inversion_0 is a valid Inversion name in a + // Benzene molecule + + std::string s = OpenMD_itoa(mol->getNInversions(), 10); + inversion->setName(mol->getType() + "_Inversion_" + s.c_str()); return inversion; } } - CutoffGroup* MoleculeCreator::createCutoffGroup(Molecule* mol, CutoffGroupStamp* stamp) { + CutoffGroup* MoleculeCreator::createCutoffGroup(Molecule* mol, + CutoffGroupStamp* stamp, + LocalIndexManager* localIndexMan) { int nAtoms; CutoffGroup* cg; Atom* atom; @@ -461,14 +558,22 @@ namespace OpenMD { assert(atom); cg->addAtom(atom); } - + + //set the local index of this cutoffGroup, global index will be set later + cg->setLocalIndex(localIndexMan->getNextCutoffGroupIndex()); + return cg; } - - CutoffGroup* MoleculeCreator::createCutoffGroup(Molecule * mol, Atom* atom) { + + CutoffGroup* MoleculeCreator::createCutoffGroup(Molecule * mol, Atom* atom, + LocalIndexManager* localIndexMan) { CutoffGroup* cg; cg = new CutoffGroup(); cg->addAtom(atom); + + //set the local index of this cutoffGroup, global index will be set later + cg->setLocalIndex(localIndexMan->getNextCutoffGroupIndex()); + return cg; } @@ -477,24 +582,20 @@ namespace OpenMD { //add bond constraints Molecule::BondIterator bi; Bond* bond; + ConstraintPair* cPair; + for (bond = mol->beginBond(bi); bond != NULL; bond = mol->nextBond(bi)) { BondType* bt = bond->getBondType(); - //class Parent1 {}; - //class Child1 : public Parent {}; - //class Child2 : public Parent {}; - //Child1* ch1 = new Child1(); - //Child2* ch2 = dynamic_cast(ch1); - //the dynamic_cast is succeed in above line. A compiler bug? - if (typeid(FixedBondType) == typeid(*bt)) { FixedBondType* fbt = dynamic_cast(bt); ConstraintElem* consElemA = new ConstraintElem(bond->getAtomA()); ConstraintElem* consElemB = new ConstraintElem(bond->getAtomB()); - ConstraintPair* consPair = new ConstraintPair(consElemA, consElemB, fbt->getEquilibriumBondLength()); - mol->addConstraintPair(consPair); + cPair = new ConstraintPair(consElemA, consElemB, + fbt->getEquilibriumBondLength(), false); + mol->addConstraintPair(cPair); } } @@ -506,22 +607,20 @@ namespace OpenMD { ConstraintPair* consPair; Molecule::ConstraintPairIterator cpi; std::set sdSet; - for (consPair = mol->beginConstraintPair(cpi); consPair != NULL; consPair = mol->nextConstraintPair(cpi)) { + for (consPair = mol->beginConstraintPair(cpi); consPair != NULL; + consPair = mol->nextConstraintPair(cpi)) { StuntDouble* sdA = consPair->getConsElem1()->getStuntDouble(); if (sdSet.find(sdA) == sdSet.end()){ sdSet.insert(sdA); mol->addConstraintElem(new ConstraintElem(sdA)); } - + StuntDouble* sdB = consPair->getConsElem2()->getStuntDouble(); if (sdSet.find(sdB) == sdSet.end()){ sdSet.insert(sdB); mol->addConstraintElem(new ConstraintElem(sdB)); - } - + } } - } - }