--- branches/development/src/parallel/ForceDecomposition.cpp	2011/04/11 18:44:16	1547
+++ branches/development/src/parallel/ForceMatrixDecomposition.cpp	2011/04/30 02:54:02	1554
@@ -38,7 +38,7 @@
  * [3]  Sun, Lin & Gezelter, J. Chem. Phys. 128, 24107 (2008).          
  * [4]  Vardeman & Gezelter, in progress (2009).                        
  */
-#include "parallel/ForceDecomposition.hpp"
+#include "parallel/ForceMatrixDecomposition.hpp"
 #include "math/SquareMatrix3.hpp"
 #include "nonbonded/NonBondedInteraction.hpp"
 #include "brains/SnapshotManager.hpp"
@@ -51,57 +51,67 @@ namespace OpenMD {
    * SimulationSetup
    */
   
-  void ForceDecomposition::distributeInitialData() {
+  void ForceMatrixDecomposition::distributeInitialData() {
+    snap_ = sman_->getCurrentSnapshot();
+    storageLayout_ = sman_->getStorageLayout();
 #ifdef IS_MPI    
-    Snapshot* snap = sman_->getCurrentSnapshot();
-    int nLocal = snap->getNumberOfAtoms();
-    int nGroups = snap->getNumberOfCutoffGroups();
+    int nLocal = snap_->getNumberOfAtoms();
+    int nGroups = snap_->getNumberOfCutoffGroups();
+    
+    AtomCommIntRow = new Communicator<Row,int>(nLocal);
+    AtomCommRealRow = new Communicator<Row,RealType>(nLocal);
+    AtomCommVectorRow = new Communicator<Row,Vector3d>(nLocal);
+    AtomCommMatrixRow = new Communicator<Row,Mat3x3d>(nLocal);
 
-    AtomCommIntI = new Communicator<Row,int>(nLocal);
-    AtomCommRealI = new Communicator<Row,RealType>(nLocal);
-    AtomCommVectorI = new Communicator<Row,Vector3d>(nLocal);
-    AtomCommMatrixI = new Communicator<Row,Mat3x3d>(nLocal);
+    AtomCommIntColumn = new Communicator<Column,int>(nLocal);
+    AtomCommRealColumn = new Communicator<Column,RealType>(nLocal);
+    AtomCommVectorColumn = new Communicator<Column,Vector3d>(nLocal);
+    AtomCommMatrixColumn = new Communicator<Column,Mat3x3d>(nLocal);
 
-    AtomCommIntJ = new Communicator<Column,int>(nLocal);
-    AtomCommRealJ = new Communicator<Column,RealType>(nLocal);
-    AtomCommVectorJ = new Communicator<Column,Vector3d>(nLocal);
-    AtomCommMatrixJ = new Communicator<Column,Mat3x3d>(nLocal);
+    cgCommIntRow = new Communicator<Row,int>(nGroups);
+    cgCommVectorRow = new Communicator<Row,Vector3d>(nGroups);
+    cgCommIntColumn = new Communicator<Column,int>(nGroups);
+    cgCommVectorColumn = new Communicator<Column,Vector3d>(nGroups);
 
-    cgCommIntI = new Communicator<Row,int>(nGroups);
-    cgCommVectorI = new Communicator<Row,Vector3d>(nGroups);
-    cgCommIntJ = new Communicator<Column,int>(nGroups);
-    cgCommVectorJ = new Communicator<Column,Vector3d>(nGroups);
+    int nAtomsInRow = AtomCommIntRow->getSize();
+    int nAtomsInCol = AtomCommIntColumn->getSize();
+    int nGroupsInRow = cgCommIntRow->getSize();
+    int nGroupsInCol = cgCommIntColumn->getSize();
 
-    int nAtomsInRow = AtomCommIntI->getSize();
-    int nAtomsInCol = AtomCommIntJ->getSize();
-    int nGroupsInRow = cgCommIntI->getSize();
-    int nGroupsInCol = cgCommIntJ->getSize();
-
+    // Modify the data storage objects with the correct layouts and sizes:
+    atomRowData.resize(nAtomsInRow);
+    atomRowData.setStorageLayout(storageLayout_);
+    atomColData.resize(nAtomsInCol);
+    atomColData.setStorageLayout(storageLayout_);
+    cgRowData.resize(nGroupsInRow);
+    cgRowData.setStorageLayout(DataStorage::dslPosition);
+    cgColData.resize(nGroupsInCol);
+    cgColData.setStorageLayout(DataStorage::dslPosition);
+    
     vector<vector<RealType> > pot_row(N_INTERACTION_FAMILIES, 
                                       vector<RealType> (nAtomsInRow, 0.0));
     vector<vector<RealType> > pot_col(N_INTERACTION_FAMILIES,
                                       vector<RealType> (nAtomsInCol, 0.0));
-    
-    vector<RealType> pot_local(N_INTERACTION_FAMILIES, 0.0);
 
+
+    vector<RealType> pot_local(N_INTERACTION_FAMILIES, 0.0);
+    
     // gather the information for atomtype IDs (atids):
     vector<int> identsLocal = info_->getIdentArray();
     identsRow.reserve(nAtomsInRow);
     identsCol.reserve(nAtomsInCol);
+    
+    AtomCommIntRow->gather(identsLocal, identsRow);
+    AtomCommIntColumn->gather(identsLocal, identsCol);
+    
+    AtomLocalToGlobal = info_->getGlobalAtomIndices();
+    AtomCommIntRow->gather(AtomLocalToGlobal, AtomRowToGlobal);
+    AtomCommIntColumn->gather(AtomLocalToGlobal, AtomColToGlobal);
+    
+    cgLocalToGlobal = info_->getGlobalGroupIndices();
+    cgCommIntRow->gather(cgLocalToGlobal, cgRowToGlobal);
+    cgCommIntColumn->gather(cgLocalToGlobal, cgColToGlobal);
 
-    AtomCommIntI->gather(identsLocal, identsRow);
-    AtomCommIntJ->gather(identsLocal, identsCol);
-
-    AtomLocalToGlobal = info_->getLocalToGlobalAtomIndex();
-    AtomCommIntI->gather(AtomLocalToGlobal, AtomRowToGlobal);
-    AtomCommIntJ->gather(AtomLocalToGlobal, AtomColToGlobal);
-
-    cgLocalToGlobal = info_->getLocalToGlobalCutoffGroupIndex();
-    cgCommIntI->gather(cgLocalToGlobal, cgRowToGlobal);
-    cgCommIntJ->gather(cgLocalToGlobal, cgColToGlobal);
-
-     
-
     // still need:
     // topoDist
     // exclude
@@ -110,124 +120,237 @@ namespace OpenMD {
     
 
 
-  void ForceDecomposition::distributeData()  {
+  void ForceMatrixDecomposition::distributeData()  {
+    snap_ = sman_->getCurrentSnapshot();
+    storageLayout_ = sman_->getStorageLayout();
 #ifdef IS_MPI
-    Snapshot* snap = sman_->getCurrentSnapshot();
     
     // gather up the atomic positions
-    AtomCommVectorI->gather(snap->atomData.position, 
-                            snap->atomIData.position);
-    AtomCommVectorJ->gather(snap->atomData.position, 
-                            snap->atomJData.position);
+    AtomCommVectorRow->gather(snap_->atomData.position, 
+                              atomRowData.position);
+    AtomCommVectorColumn->gather(snap_->atomData.position, 
+                                 atomColData.position);
     
     // gather up the cutoff group positions
-    cgCommVectorI->gather(snap->cgData.position, 
-                          snap->cgIData.position);
-    cgCommVectorJ->gather(snap->cgData.position, 
-                          snap->cgJData.position);
+    cgCommVectorRow->gather(snap_->cgData.position, 
+                            cgRowData.position);
+    cgCommVectorColumn->gather(snap_->cgData.position, 
+                               cgColData.position);
     
     // if needed, gather the atomic rotation matrices
-    if (snap->atomData.getStorageLayout() & DataStorage::dslAmat) {
-      AtomCommMatrixI->gather(snap->atomData.aMat, 
-                              snap->atomIData.aMat);
-      AtomCommMatrixJ->gather(snap->atomData.aMat, 
-                              snap->atomJData.aMat);
+    if (storageLayout_ & DataStorage::dslAmat) {
+      AtomCommMatrixRow->gather(snap_->atomData.aMat, 
+                                atomRowData.aMat);
+      AtomCommMatrixColumn->gather(snap_->atomData.aMat, 
+                                   atomColData.aMat);
     }
     
     // if needed, gather the atomic eletrostatic frames
-    if (snap->atomData.getStorageLayout() & DataStorage::dslElectroFrame) {
-      AtomCommMatrixI->gather(snap->atomData.electroFrame, 
-                              snap->atomIData.electroFrame);
-      AtomCommMatrixJ->gather(snap->atomData.electroFrame, 
-                              snap->atomJData.electroFrame);
+    if (storageLayout_ & DataStorage::dslElectroFrame) {
+      AtomCommMatrixRow->gather(snap_->atomData.electroFrame, 
+                                atomRowData.electroFrame);
+      AtomCommMatrixColumn->gather(snap_->atomData.electroFrame, 
+                                   atomColData.electroFrame);
     }
 #endif      
   }
   
-  void ForceDecomposition::collectIntermediateData() {
+  void ForceMatrixDecomposition::collectIntermediateData() {
+    snap_ = sman_->getCurrentSnapshot();
+    storageLayout_ = sman_->getStorageLayout();
 #ifdef IS_MPI
-    Snapshot* snap = sman_->getCurrentSnapshot();
     
-    if (snap->atomData.getStorageLayout() & DataStorage::dslDensity) {
-
-      AtomCommRealI->scatter(snap->atomIData.density, 
-                             snap->atomData.density);
-
-      int n = snap->atomData.density.size();
+    if (storageLayout_ & DataStorage::dslDensity) {
+      
+      AtomCommRealRow->scatter(atomRowData.density, 
+                               snap_->atomData.density);
+      
+      int n = snap_->atomData.density.size();
       std::vector<RealType> rho_tmp(n, 0.0);
-      AtomCommRealJ->scatter(snap->atomJData.density, rho_tmp);
+      AtomCommRealColumn->scatter(atomColData.density, rho_tmp);
       for (int i = 0; i < n; i++)
-        snap->atomData.density[i] += rho_tmp[i];
+        snap_->atomData.density[i] += rho_tmp[i];
     }
 #endif
   }
   
-  void ForceDecomposition::distributeIntermediateData() {
+  void ForceMatrixDecomposition::distributeIntermediateData() {
+    snap_ = sman_->getCurrentSnapshot();
+    storageLayout_ = sman_->getStorageLayout();
 #ifdef IS_MPI
-    Snapshot* snap = sman_->getCurrentSnapshot();
-    if (snap->atomData.getStorageLayout() & DataStorage::dslFunctional) {
-      AtomCommRealI->gather(snap->atomData.functional, 
-                            snap->atomIData.functional);
-      AtomCommRealJ->gather(snap->atomData.functional, 
-                            snap->atomJData.functional);
+    if (storageLayout_ & DataStorage::dslFunctional) {
+      AtomCommRealRow->gather(snap_->atomData.functional, 
+                              atomRowData.functional);
+      AtomCommRealColumn->gather(snap_->atomData.functional, 
+                                 atomColData.functional);
     }
     
-    if (snap->atomData.getStorageLayout() & DataStorage::dslFunctionalDerivative) {
-      AtomCommRealI->gather(snap->atomData.functionalDerivative, 
-                            snap->atomIData.functionalDerivative);
-      AtomCommRealJ->gather(snap->atomData.functionalDerivative, 
-                            snap->atomJData.functionalDerivative);
+    if (storageLayout_ & DataStorage::dslFunctionalDerivative) {
+      AtomCommRealRow->gather(snap_->atomData.functionalDerivative, 
+                              atomRowData.functionalDerivative);
+      AtomCommRealColumn->gather(snap_->atomData.functionalDerivative, 
+                                 atomColData.functionalDerivative);
     }
 #endif
   }
   
   
-  void ForceDecomposition::collectData() {
-#ifdef IS_MPI
-    Snapshot* snap = sman_->getCurrentSnapshot();
-    
-    int n = snap->atomData.force.size();
+  void ForceMatrixDecomposition::collectData() {
+    snap_ = sman_->getCurrentSnapshot();
+    storageLayout_ = sman_->getStorageLayout();
+#ifdef IS_MPI    
+    int n = snap_->atomData.force.size();
     vector<Vector3d> frc_tmp(n, V3Zero);
     
-    AtomCommVectorI->scatter(snap->atomIData.force, frc_tmp);
+    AtomCommVectorRow->scatter(atomRowData.force, frc_tmp);
     for (int i = 0; i < n; i++) {
-      snap->atomData.force[i] += frc_tmp[i];
+      snap_->atomData.force[i] += frc_tmp[i];
       frc_tmp[i] = 0.0;
     }
     
-    AtomCommVectorJ->scatter(snap->atomJData.force, frc_tmp);
+    AtomCommVectorColumn->scatter(atomColData.force, frc_tmp);
     for (int i = 0; i < n; i++)
-      snap->atomData.force[i] += frc_tmp[i];
+      snap_->atomData.force[i] += frc_tmp[i];
     
     
-    if (snap->atomData.getStorageLayout() & DataStorage::dslTorque) {
+    if (storageLayout_ & DataStorage::dslTorque) {
 
-      int nt = snap->atomData.force.size();
+      int nt = snap_->atomData.force.size();
       vector<Vector3d> trq_tmp(nt, V3Zero);
 
-      AtomCommVectorI->scatter(snap->atomIData.torque, trq_tmp);
+      AtomCommVectorRow->scatter(atomRowData.torque, trq_tmp);
       for (int i = 0; i < n; i++) {
-        snap->atomData.torque[i] += trq_tmp[i];
+        snap_->atomData.torque[i] += trq_tmp[i];
         trq_tmp[i] = 0.0;
       }
       
-      AtomCommVectorJ->scatter(snap->atomJData.torque, trq_tmp);
+      AtomCommVectorColumn->scatter(atomColData.torque, trq_tmp);
       for (int i = 0; i < n; i++)
-        snap->atomData.torque[i] += trq_tmp[i];
+        snap_->atomData.torque[i] += trq_tmp[i];
     }
     
-    int nLocal = snap->getNumberOfAtoms();
+    int nLocal = snap_->getNumberOfAtoms();
 
     vector<vector<RealType> > pot_temp(N_INTERACTION_FAMILIES, 
                                        vector<RealType> (nLocal, 0.0));
     
     for (int i = 0; i < N_INTERACTION_FAMILIES; i++) {
-      AtomCommRealI->scatter(pot_row[i], pot_temp[i]);
+      AtomCommRealRow->scatter(pot_row[i], pot_temp[i]);
       for (int ii = 0;  ii < pot_temp[i].size(); ii++ ) {
         pot_local[i] += pot_temp[i][ii];
       }
     }
 #endif
   }
+
   
+  Vector3d ForceMatrixDecomposition::getIntergroupVector(int cg1, int cg2){
+    Vector3d d;
+    
+#ifdef IS_MPI
+    d = cgColData.position[cg2] - cgRowData.position[cg1];
+#else
+    d = snap_->cgData.position[cg2] - snap_->cgData.position[cg1];
+#endif
+    
+    snap_->wrapVector(d);
+    return d;    
+  }
+
+
+  Vector3d ForceMatrixDecomposition::getAtomToGroupVectorRow(int atom1, int cg1){
+
+    Vector3d d;
+    
+#ifdef IS_MPI
+    d = cgRowData.position[cg1] - atomRowData.position[atom1];
+#else
+    d = snap_->cgData.position[cg1] - snap_->atomData.position[atom1];
+#endif
+
+    snap_->wrapVector(d);
+    return d;    
+  }
+  
+  Vector3d ForceMatrixDecomposition::getAtomToGroupVectorColumn(int atom2, int cg2){
+    Vector3d d;
+    
+#ifdef IS_MPI
+    d = cgColData.position[cg2] - atomColData.position[atom2];
+#else
+    d = snap_->cgData.position[cg2] - snap_->atomData.position[atom2];
+#endif
+    
+    snap_->wrapVector(d);
+    return d;    
+  }
+    
+  Vector3d ForceMatrixDecomposition::getInteratomicVector(int atom1, int atom2){
+    Vector3d d;
+    
+#ifdef IS_MPI
+    d = atomColData.position[atom2] - atomRowData.position[atom1];
+#else
+    d = snap_->atomData.position[atom2] - snap_->atomData.position[atom1];
+#endif
+
+    snap_->wrapVector(d);
+    return d;    
+  }
+
+  void ForceMatrixDecomposition::addForceToAtomRow(int atom1, Vector3d fg){
+#ifdef IS_MPI
+    atomRowData.force[atom1] += fg;
+#else
+    snap_->atomData.force[atom1] += fg;
+#endif
+  }
+
+  void ForceMatrixDecomposition::addForceToAtomColumn(int atom2, Vector3d fg){
+#ifdef IS_MPI
+    atomColData.force[atom2] += fg;
+#else
+    snap_->atomData.force[atom2] += fg;
+#endif
+
+  }
+
+    // filling interaction blocks with pointers
+  InteractionData ForceMatrixDecomposition::fillInteractionData(int atom1, int atom2) {    
+
+    InteractionData idat;
+#ifdef IS_MPI
+    if (storageLayout_ & DataStorage::dslAmat) {
+      idat.A1 = &(atomRowData.aMat[atom1]);
+      idat.A2 = &(atomColData.aMat[atom2]);
+    }
+
+    if (storageLayout_ & DataStorage::dslElectroFrame) {
+      idat.eFrame1 = &(atomRowData.electroFrame[atom1]);
+      idat.eFrame2 = &(atomColData.electroFrame[atom2]);
+    }
+
+    if (storageLayout_ & DataStorage::dslTorque) {
+      idat.t1 = &(atomRowData.torque[atom1]);
+      idat.t2 = &(atomColData.torque[atom2]);
+    }
+
+    if (storageLayout_ & DataStorage::dslDensity) {
+      idat.rho1 = &(atomRowData.density[atom1]);
+      idat.rho2 = &(atomColData.density[atom2]);
+    }
+
+    if (storageLayout_ & DataStorage::dslFunctionalDerivative) {
+      idat.dfrho1 = &(atomRowData.functionalDerivative[atom1]);
+      idat.dfrho2 = &(atomColData.functionalDerivative[atom2]);
+    }
+#endif
+    
+  }
+  InteractionData ForceMatrixDecomposition::fillSkipData(int atom1, int atom2){
+  }
+  SelfData ForceMatrixDecomposition::fillSelfData(int atom1) {
+  }
+
+  
 } //end namespace OpenMD