ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/group/trunk/OOPSE/libmdtools/DumpWriter.cpp
(Generate patch)

Comparing trunk/OOPSE/libmdtools/DumpWriter.cpp (file contents):
Revision 913 by chuckv, Thu Jan 8 22:25:52 2004 UTC vs.
Revision 949 by chuckv, Thu Jan 15 21:57:10 2004 UTC

# Line 3 | Line 3
3   #include <string.h>
4   #include <iostream>
5   #include <fstream>
6 + #include <algorithm>
7 + #include <utility>
8  
9   #ifdef IS_MPI
10   #include <mpi.h>
# Line 26 | Line 28 | DumpWriter::DumpWriter( SimInfo* the_entry_plug ){
28    if(worldRank == 0 ){
29   #endif // is_mpi
30  
31 <    strcpy( outName, entry_plug->sampleName );
31 >    dumpFile.open(entry_plug->sampleName, ios::out | ios::trunc );
32  
33 <    outFile.open(outName, ios::out | ios::trunc );
33 >    if( !dumpFile ){
34  
33 –    if( !outFile ){
34 –
35        sprintf( painCave.errMsg,
36                 "Could not open \"%s\" for dump output.\n",
37 <               outName);
37 >               entry_plug->sampleName);
38        painCave.isFatal = 1;
39        simError();
40      }
41  
42 –    //outFile.setf( ios::scientific );
43 –
42   #ifdef IS_MPI
43    }
44  
45 +  //sort the local atoms by global index
46 +  sortByGlobalIndex();
47 +  
48    sprintf( checkPointMsg,
49             "Sucessfully opened output file for dumping.\n");
50    MPIcheckPoint();
# Line 56 | Line 57 | DumpWriter::~DumpWriter( ){
57    if(worldRank == 0 ){
58   #endif // is_mpi
59  
60 <    outFile.close();
60 >    dumpFile.close();
61  
62   #ifdef IS_MPI
63    }
64   #endif // is_mpi
65   }
66  
67 < void DumpWriter::writeDump( double currentTime ){
67 > #ifdef IS_MPI
68  
69 + /**
70 + * A hook function to load balancing
71 + */
72 +
73 + void DumpWriter::update(){
74 +  sortByGlobalIndex();          
75 + }
76 +  
77 + /**
78 + * Auxiliary sorting function
79 + */
80 +
81 + bool indexSortingCriterion(const pair<int, int>& p1, const pair<int, int>& p2){
82 +  return p1.second < p2.second;
83 + }
84 +
85 + /**
86 + * Sorting the local index by global index
87 + */
88 +
89 + void DumpWriter::sortByGlobalIndex(){
90 +  Atom** atoms = entry_plug->atoms;
91 +  
92 +  indexArray.clear();
93 +  
94 +  for(int i = 0; i < mpiSim->getMyNlocal();i++)
95 +    indexArray.push_back(make_pair(i, atoms[i]->getGlobalIndex()));
96 +  
97 +  sort(indexArray.begin(), indexArray.end(), indexSortingCriterion);    
98 +
99 +  //for (int i = 0; i < mpiSim->getMyNlocal(); i++) {
100 +  //  printf("node %d has global %d at local %d\n", worldRank, indexArray[i].second, indexArray[i].first);
101 +  //}
102 +    
103 + }
104 +
105 + #endif
106 +
107 + void DumpWriter::writeDump(double currentTime){
108 +
109 +  ofstream finalOut;
110 +  vector<ofstream*> fileStreams;
111 +
112 + #ifdef IS_MPI
113 +  printf("Hello from node %d\n", worldRank);
114 +  sortByGlobalIndex();
115 +  if(worldRank == 0 ){
116 +    
117 +    finalOut.open( entry_plug->finalName, ios::out | ios::trunc );
118 +    if( !finalOut ){
119 +      sprintf( painCave.errMsg,
120 +               "Could not open \"%s\" for final dump output.\n",
121 +               entry_plug->finalName );
122 +      painCave.isFatal = 1;
123 +      simError();
124 +    }
125 +  }
126 + #endif // is_mpi
127 +
128 +  fileStreams.push_back(&finalOut);
129 +  fileStreams.push_back(&dumpFile);
130 +
131 +  writeFrame(fileStreams, currentTime);
132 +
133 + #ifdef IS_MPI
134 +  finalOut.close();
135 + #endif
136 +        
137 + }
138 +
139 + void DumpWriter::writeFinal(double currentTime){
140 +
141 +  ofstream finalOut;
142 +  vector<ofstream*> fileStreams;
143 +
144 + #ifdef IS_MPI
145 +  if(worldRank == 0 ){
146 +
147 +    finalOut.open( entry_plug->finalName, ios::out | ios::trunc );
148 +
149 +    if( !finalOut ){
150 +      sprintf( painCave.errMsg,
151 +               "Could not open \"%s\" for final dump output.\n",
152 +               entry_plug->finalName );
153 +      painCave.isFatal = 1;
154 +      simError();
155 +    }
156 +
157 +  }
158 + #endif // is_mpi
159 +  
160 +  fileStreams.push_back(&finalOut);  
161 +  writeFrame(fileStreams, currentTime);
162 +
163 + #ifdef IS_MPI
164 +  finalOut.close();
165 + #endif
166 +  
167 + }
168 +
169 + void DumpWriter::writeFrame( vector<ofstream*>& outFile, double currentTime ){
170 +
171    const int BUFFERSIZE = 2000;
172    const int MINIBUFFERSIZE = 100;
173  
174 <  char tempBuffer[BUFFERSIZE];
174 >  char tempBuffer[BUFFERSIZE];  
175    char writeLine[BUFFERSIZE];
176  
177 <  int i;
177 >  int i, k;
178 >
179   #ifdef IS_MPI
180 <  int j, which_node, done, which_atom, local_index;
181 <  double atomTransData[6];
182 <  double atomOrientData[7];
180 >  
181 >  /*********************************************************************
182 >   * Documentation?  You want DOCUMENTATION?
183 >   *
184 >   * Why all the potatoes below?  
185 >   *
186 >   * To make a long story short, the original version of DumpWriter
187 >   * worked in the most inefficient way possible.  Node 0 would
188 >   * poke each of the node for an individual atom's formatted data
189 >   * as node 0 worked its way down the global index. This was particularly
190 >   * inefficient since the method blocked all processors at every atom
191 >   * (and did it twice!).
192 >   *
193 >   * An intermediate version of DumpWriter could be described from Node
194 >   * zero's perspective as follows:
195 >   *
196 >   *  1) Have 100 of your friends stand in a circle.
197 >   *  2) When you say go, have all of them start tossing potatoes at
198 >   *     you (one at a time).
199 >   *  3) Catch the potatoes.
200 >   *
201 >   * It was an improvement, but MPI has buffers and caches that could
202 >   * best be described in this analogy as "potato nets", so there's no
203 >   * need to block the processors atom-by-atom.
204 >   *
205 >   * This new and improved DumpWriter works in an even more efficient
206 >   * way:
207 >   *
208 >   *  1) Have 100 of your friend stand in a circle.
209 >   *  2) When you say go, have them start tossing 5-pound bags of
210 >   *     potatoes at you.
211 >   *  3) Once you've caught a friend's bag of potatoes,
212 >   *     toss them a spud to let them know they can toss another bag.
213 >   *
214 >   * How's THAT for documentation?
215 >   *
216 >   *********************************************************************/
217 >
218 >  int *potatoes;
219 >  int myPotato;
220 >
221 >  int nProc;
222 >  int j, which_node, done, which_atom, local_index, currentIndex;
223 >  double atomData6[6];
224 >  double atomData13[13];
225    int isDirectional;
226    char* atomTypeString;
227    char MPIatomTypeString[MINIBUFFERSIZE];
228 <  int me;
83 <  int atomTypeTag;
84 <  int atomIsDirectionalTag;
85 <  int atomTransDataTag;
86 <  int atomOrientDataTag;
228 >
229   #else //is_mpi
230    int nAtoms = entry_plug->n_atoms;
231   #endif //is_mpi
# Line 93 | Line 235 | void DumpWriter::writeDump( double currentTime ){
235    Atom** atoms = entry_plug->atoms;
236    double pos[3], vel[3];
237  
96 –  // write current frame to the eor file
97 –
98 –  this->writeFinal( currentTime );
99 –
238   #ifndef IS_MPI
239 +  
240 +  for(k = 0; k < outFile.size(); k++){
241 +    *outFile[k] << nAtoms << "\n";
242  
243 <  outFile << nAtoms << "\n";
243 >    *outFile[k] << currentTime << ";\t"
244 >               << entry_plug->Hmat[0][0] << "\t"
245 >                     << entry_plug->Hmat[1][0] << "\t"
246 >                     << entry_plug->Hmat[2][0] << ";\t"
247 >              
248 >               << entry_plug->Hmat[0][1] << "\t"
249 >                     << entry_plug->Hmat[1][1] << "\t"
250 >                     << entry_plug->Hmat[2][1] << ";\t"
251  
252 <  outFile << currentTime << ";\t"
253 <          << entry_plug->Hmat[0][0] << "\t"
254 <          << entry_plug->Hmat[1][0] << "\t"
107 <          << entry_plug->Hmat[2][0] << ";\t"
252 >                     << entry_plug->Hmat[0][2] << "\t"
253 >                     << entry_plug->Hmat[1][2] << "\t"
254 >                     << entry_plug->Hmat[2][2] << ";";
255  
256 <          << entry_plug->Hmat[0][1] << "\t"
257 <          << entry_plug->Hmat[1][1] << "\t"
258 <          << entry_plug->Hmat[2][1] << ";\t"
259 <
113 <          << entry_plug->Hmat[0][2] << "\t"
114 <          << entry_plug->Hmat[1][2] << "\t"
115 <          << entry_plug->Hmat[2][2] << ";";
116 <  //write out additional parameters, such as chi and eta
117 <  outFile << entry_plug->the_integrator->getAdditionalParameters();
118 <  outFile << endl;
119 <
256 >    //write out additional parameters, such as chi and eta
257 >    *outFile[k] << entry_plug->the_integrator->getAdditionalParameters() << endl;
258 >  }
259 >  
260    for( i=0; i<nAtoms; i++ ){
261  
262      atoms[i]->getPos(pos);
# Line 152 | Line 292 | void DumpWriter::writeDump( double currentTime ){
292      else
293        strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
294  
295 <    outFile << writeLine;
295 >    for(k = 0; k < outFile.size(); k++)
296 >      *outFile[k] << writeLine;
297    }
157 –  outFile.flush();
298  
299   #else // is_mpi
300  
301    /* code to find maximum tag value */
302 +  
303    int *tagub, flag, MAXTAG;
304    MPI_Attr_get(MPI_COMM_WORLD, MPI_TAG_UB, &tagub, &flag);
305    if (flag) {
306      MAXTAG = *tagub;
307    } else {
308      MAXTAG = 32767;
309 <  }
309 >  }  
310  
311    int haveError;
312  
# Line 175 | Line 316 | void DumpWriter::writeDump( double currentTime ){
316    // write out header and node 0's coordinates
317  
318    if( worldRank == 0 ){
178 –    outFile << mpiSim->getTotAtoms() << "\n";
319  
320 <    outFile << currentTime << ";\t"
181 <            << entry_plug->Hmat[0][0] << "\t"
182 <            << entry_plug->Hmat[1][0] << "\t"
183 <            << entry_plug->Hmat[2][0] << ";\t"
320 >    // Node 0 needs a list of the magic potatoes for each processor;
321  
322 <            << entry_plug->Hmat[0][1] << "\t"
323 <            << entry_plug->Hmat[1][1] << "\t"
187 <            << entry_plug->Hmat[2][1] << ";\t"
322 >    nProc = mpiSim->getNumberProcessors();
323 >    potatoes = new int[nProc];
324  
325 <            << entry_plug->Hmat[0][2] << "\t"
326 <            << entry_plug->Hmat[1][2] << "\t"
327 <            << entry_plug->Hmat[2][2] << ";";
325 >    //write out the comment lines
326 >    for (i = 0; i < nProc; i++)
327 >      potatoes[i] = 0;
328 >    
329 >      for(k = 0; k < outFile.size(); k++){
330 >        *outFile[k] << mpiSim->getTotAtoms() << "\n";
331  
332 <    outFile << entry_plug->the_integrator->getAdditionalParameters();
333 <    outFile << endl;
334 <    outFile.flush();
332 >        *outFile[k] << currentTime << ";\t"
333 >                         << entry_plug->Hmat[0][0] << "\t"
334 >                         << entry_plug->Hmat[1][0] << "\t"
335 >                         << entry_plug->Hmat[2][0] << ";\t"
336  
337 <    tag = 0;
337 >                         << entry_plug->Hmat[0][1] << "\t"
338 >                         << entry_plug->Hmat[1][1] << "\t"
339 >                         << entry_plug->Hmat[2][1] << ";\t"
340  
341 <    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
341 >                         << entry_plug->Hmat[0][2] << "\t"
342 >                         << entry_plug->Hmat[1][2] << "\t"
343 >                         << entry_plug->Hmat[2][2] << ";";
344 >  
345 >        *outFile[k] << entry_plug->the_integrator->getAdditionalParameters() << endl;
346 >    }
347  
348 <      if (tag + 2 >= MAXTAG) {
349 <        // The tag was going to exceed the maximum value, so wrap around to 0:
350 <        tag = 0;
204 <        // Send the newly zeroed tag on to the other nodes:
205 <        MPI_Bcast(&tag, 1, MPI_INT, 0, MPI_COMM_WORLD);
206 <      }
348 >    currentIndex = 0;
349 >
350 >    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
351        
352        // Get the Node number which has this atom;
353        
354        which_node = AtomToProcMap[i];
355        
356        if (which_node != 0) {
357 +
358 +        if (potatoes[which_node] + 3 >= MAXTAG) {
359 +          // The potato was going to exceed the maximum value,
360 +          // so wrap this processor potato back to 0:        
361 +
362 +          potatoes[which_node] = 0;          
363 +          MPI_Send(0, 1, MPI_INT, which_node, 0, MPI_COMM_WORLD);
364 +          
365 +        }
366 +
367 +        myPotato = potatoes[which_node];        
368          
369          MPI_Recv(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, which_node,
370 <                 atomTypeTag, MPI_COMM_WORLD, &istatus);
370 >                 myPotato, MPI_COMM_WORLD, &istatus);
371          
372 <        strncpy(atomTypeString, MPIatomTypeString, MINIBUFFERSIZE);
373 <        
374 <        // Null terminate the atomTypeString just in case:
372 >        atomTypeString = MPIatomTypeString;
373 >        
374 >        myPotato++;
375  
221 –        atomTypeString[strlen(atomTypeString) - 1] = '\0';
222 –
376          MPI_Recv(&isDirectional, 1, MPI_INT, which_node,
377 <                 atomIsDirectionalTag, MPI_COMM_WORLD, &istatus);
378 <        
379 <        MPI_Recv(atomTransData, 6, MPI_DOUBLE, which_node,
227 <                 atomTransDataTag, MPI_COMM_WORLD, &istatus);
377 >                 myPotato, MPI_COMM_WORLD, &istatus);
378 >              
379 >        myPotato++;
380  
381 <        if (isDirectional) {
382 <
383 <          MPI_Recv(atomOrientData, 7, MPI_DOUBLE, which_node,
384 <                   atomOrientDataTag, MPI_COMM_WORLD, &istatus);
385 <
381 >        if (isDirectional) {          
382 >          MPI_Recv(atomData13, 13, MPI_DOUBLE, which_node,
383 >                   myPotato, MPI_COMM_WORLD, &istatus);
384 >        } else {
385 >          MPI_Recv(atomData6, 6, MPI_DOUBLE, which_node,
386 >                   myPotato, MPI_COMM_WORLD, &istatus);          
387          }
388 +        
389 +        myPotato++;
390 +        potatoes[which_node] = myPotato;
391  
392        } else {
393          
394 <        haveError = 0;
394 >        haveError = 0;
395          which_atom = i;
396 <        local_index=-1;
396 >        
397 >        //local_index = -1;
398  
399 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
400 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
401 <        }
402 <
403 <        if (local_index != -1) {
404 <
405 <          atomTypeString = atoms[local_index]->getType();
406 <
399 >        //for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
400 >        //  if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
401 >        //}
402 >        
403 >        //if (local_index != -1) {
404 >          
405 >          local_index = indexArray[currentIndex].first;        
406 >          
407 >          if (which_atom == indexArray[currentIndex].second) {
408 >            
409 >            atomTypeString = atoms[local_index]->getType();
410 >            
411            atoms[local_index]->getPos(pos);
412 <          atoms[local_index]->getVel(vel);
412 >          atoms[local_index]->getVel(vel);          
413 >          
414 >          atomData6[0] = pos[0];
415 >          atomData6[1] = pos[1];
416 >          atomData6[2] = pos[2];
417  
418 <          atomTransData[0] = pos[0];
419 <          atomTransData[1] = pos[1];
420 <          atomTransData[2] = pos[2];
256 <
257 <          atomTransData[3] = vel[0];
258 <          atomTransData[4] = vel[1];
259 <          atomTransData[5] = vel[2];
418 >          atomData6[3] = vel[0];
419 >          atomData6[4] = vel[1];
420 >          atomData6[5] = vel[2];
421            
422            isDirectional = 0;
423  
# Line 266 | Line 427 | void DumpWriter::writeDump( double currentTime ){
427              
428              dAtom = (DirectionalAtom *)atoms[local_index];
429              dAtom->getQ( q );
269 –            
270 –            atomOrientData[0] = q[0];
271 –            atomOrientData[1] = q[1];
272 –            atomOrientData[2] = q[2];
273 –            atomOrientData[3] = q[3];
430  
431 <            atomOrientData[4] = dAtom->getJx();
432 <            atomOrientData[5] = dAtom->getJy();
433 <            atomOrientData[6] = dAtom->getJz();
431 >            for (int j = 0; j < 6 ; j++)
432 >              atomData13[j] = atomData6[j];            
433 >            
434 >            atomData13[6] = q[0];
435 >            atomData13[7] = q[1];
436 >            atomData13[8] = q[2];
437 >            atomData13[9] = q[3];
438 >            
439 >            atomData13[10] = dAtom->getJx();
440 >            atomData13[11] = dAtom->getJy();
441 >            atomData13[12] = dAtom->getJz();
442            }
443 <
443 >          
444          } else {
445            sprintf(painCave.errMsg,
446 <                  "Atom %d not found on processor %d\n",
447 <                  i, worldRank );
446 >                  "Atom %d not found on processor %d, currentIndex = %d, local_index = %d\n",
447 >                  which_atom, worldRank, currentIndex, local_index );
448            haveError= 1;
449            simError();
450          }
287 –
288 –        if(haveError) DieDieDie();
289 –                              
290 –        // If we've survived to here, format the line:
451          
452 <        sprintf( tempBuffer,
453 <                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
454 <                 atomTypeString,
295 <                 atomTransData[0],
296 <                 atomTransData[1],
297 <                 atomTransData[2],
298 <                 atomTransData[3],
299 <                 atomTransData[4],
300 <                 atomTransData[5]);
301 <
302 <        strcpy( writeLine, tempBuffer );
303 <
304 <        if (isDirectional) {
305 <
306 <          sprintf( tempBuffer,
307 <                   "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
308 <                   atomOrientData[0],
309 <                   atomOrientData[1],
310 <                   atomOrientData[2],
311 <                   atomOrientData[3],
312 <                   atomOrientData[4],
313 <                   atomOrientData[5],
314 <                   atomOrientData[6]);
315 <          strcat( writeLine, tempBuffer );
316 <
317 <        } else {
318 <          strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
319 <        }
320 <
321 <        outFile << writeLine;
322 <        outFile.flush();
452 >        if(haveError) DieDieDie();
453 >        
454 >        currentIndex++;
455        }
456 <    }
325 <
326 <    outFile.flush();
327 <    sprintf( checkPointMsg,
328 <             "Sucessfully took a dump.\n");
329 <    MPIcheckPoint();        
330 <    
331 <  } else {
332 <
333 <    // worldRank != 0, so I'm a remote node.  
334 <    
335 <    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
456 >      // If we've survived to here, format the line:
457        
458 <      // Am I the node which has this atom?
459 <      
460 <      if (AtomToProcMap[i] == worldRank) {
461 <
462 <        local_index=-1;
463 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
464 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
465 <        }
466 <        if (local_index != -1) {
467 <        
468 <          atomTypeString = atoms[local_index]->getType();
469 <
470 <          atoms[local_index]->getPos(pos);
471 <          atoms[local_index]->getVel(vel);
351 <
352 <          atomTransData[0] = pos[0];
353 <          atomTransData[1] = pos[1];
354 <          atomTransData[2] = pos[2];
355 <
356 <          atomTransData[3] = vel[0];
357 <          atomTransData[4] = vel[1];
358 <          atomTransData[5] = vel[2];
359 <          
360 <          isDirectional = 0;
361 <
362 <          if( atoms[local_index]->isDirectional() ){
363 <
364 <            isDirectional = 1;
365 <            
366 <            dAtom = (DirectionalAtom *)atoms[local_index];
367 <            dAtom->getQ( q );
368 <            
369 <            atomOrientData[0] = q[0];
370 <            atomOrientData[1] = q[1];
371 <            atomOrientData[2] = q[2];
372 <            atomOrientData[3] = q[3];
373 <
374 <            atomOrientData[4] = dAtom->getJx();
375 <            atomOrientData[5] = dAtom->getJy();
376 <            atomOrientData[6] = dAtom->getJz();
377 <          }
378 <
379 <        } else {
380 <          sprintf(painCave.errMsg,
381 <                  "Atom %d not found on processor %d\n",
382 <                  i, worldRank );
383 <          haveError= 1;
384 <          simError();
385 <        }
386 <
387 <        // I've survived this far, so send off the data!
388 <
389 <        atomTypeTag          = 4*i;
390 <        atomIsDirectionalTag = 4*i + 1;
391 <        atomTransDataTag     = 4*i + 2;
392 <        atomOrientDataTag    = 4*i + 3;
393 <
394 <
395 <        strncpy(MPIatomTypeString, atomTypeString, MINIBUFFERSIZE);
396 <
397 <        // null terminate the string before sending (just in case):
398 <        MPIatomTypeString[MINIBUFFERSIZE-1] = '\0';
399 <
400 <        MPI_Send(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, 0,
401 <                 atomTypeTag, MPI_COMM_WORLD);
402 <        
403 <        MPI_Send(&isDirectional, 1, MPI_INT, 0,
404 <                 atomIsDirectionalTag, MPI_COMM_WORLD);
405 <        
406 <        MPI_Send(atomTransData, 6, MPI_DOUBLE, 0,
407 <                 atomTransDataTag, MPI_COMM_WORLD);
408 <
409 <        if (isDirectional) {
410 <
411 <          MPI_Send(atomOrientData, 7, MPI_DOUBLE, 0,
412 <                   atomOrientDataTag, MPI_COMM_WORLD);
413 <          
414 <        }
415 <      
416 <      }
417 <    }
418 <
419 <    sprintf( checkPointMsg,
420 <             "Sucessfully took a dump.\n");
421 <    MPIcheckPoint();        
422 <    
423 <  }
424 <  
425 <  painCave.isEventLoop = 0;
426 <
427 < #endif // is_mpi
428 < }
429 <
430 < void DumpWriter::writeFinal(double finalTime){
431 <
432 <  char finalName[500];
433 <  ofstream finalOut;
434 <
435 <  const int BUFFERSIZE = 2000;
436 <  const int MINIBUFFERSIZE = 100;
437 <  char tempBuffer[BUFFERSIZE];
438 <  char writeLine[BUFFERSIZE];
439 <
440 <  double q[4];
441 <  DirectionalAtom* dAtom;
442 <  Atom** atoms = entry_plug->atoms;
443 <  int i;
444 < #ifdef IS_MPI
445 <  int j, which_node, done, which_atom, local_index;
446 <  double atomTransData[6];
447 <  double atomOrientData[7];
448 <  int isDirectional;
449 <  char* atomTypeString;
450 <  char MPIatomTypeString[MINIBUFFERSIZE];
451 <  int atomTypeTag;
452 <  int atomIsDirectionalTag;
453 <  int atomTransDataTag;
454 <  int atomOrientDataTag;
455 < #else //is_mpi
456 <  int nAtoms = entry_plug->n_atoms;
457 < #endif //is_mpi
458 <
459 <  double pos[3], vel[3];
460 <
461 < #ifdef IS_MPI
462 <  if(worldRank == 0 ){
463 < #endif // is_mpi
464 <
465 <    strcpy( finalName, entry_plug->finalName );
466 <
467 <    finalOut.open( finalName, ios::out | ios::trunc );
468 <    if( !finalOut ){
469 <      sprintf( painCave.errMsg,
470 <               "Could not open \"%s\" for final dump output.\n",
471 <               finalName );
472 <      painCave.isFatal = 1;
473 <      simError();
474 <    }
475 <
476 <    // finalOut.setf( ios::scientific );
477 <
478 < #ifdef IS_MPI
479 <  }
480 <
481 <  sprintf(checkPointMsg,"Opened file for final configuration\n");
482 <  MPIcheckPoint();
483 <
484 < #endif //is_mpi
485 <
486 <
487 < #ifndef IS_MPI
488 <
489 <  finalOut << nAtoms << "\n";
490 <
491 <  finalOut << finalTime << ";\t"
492 <           << entry_plug->Hmat[0][0] << "\t"
493 <           << entry_plug->Hmat[1][0] << "\t"
494 <           << entry_plug->Hmat[2][0] << ";\t"
495 <
496 <           << entry_plug->Hmat[0][1] << "\t"
497 <           << entry_plug->Hmat[1][1] << "\t"
498 <           << entry_plug->Hmat[2][1] << ";\t"
499 <
500 <           << entry_plug->Hmat[0][2] << "\t"
501 <           << entry_plug->Hmat[1][2] << "\t"
502 <           << entry_plug->Hmat[2][2] << ";";
503 <
504 <  //write out additional parameters, such as chi and eta
505 <  finalOut << entry_plug->the_integrator->getAdditionalParameters();
506 <  finalOut << endl;
507 <
508 <  for( i=0; i<nAtoms; i++ ){
509 <
510 <    atoms[i]->getPos(pos);
511 <    atoms[i]->getVel(vel);
512 <
513 <    sprintf( tempBuffer,
514 <             "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
515 <             atoms[i]->getType(),
516 <             pos[0],
517 <             pos[1],
518 <             pos[2],
519 <             vel[0],
520 <             vel[1],
521 <             vel[2]);
522 <    strcpy( writeLine, tempBuffer );
523 <
524 <    if( atoms[i]->isDirectional() ){
525 <
526 <      dAtom = (DirectionalAtom *)atoms[i];
527 <      dAtom->getQ( q );
528 <
529 <      sprintf( tempBuffer,
530 <               "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
531 <               q[0],
532 <               q[1],
533 <               q[2],
534 <               q[3],
535 <               dAtom->getJx(),
536 <               dAtom->getJy(),
537 <               dAtom->getJz());
538 <      strcat( writeLine, tempBuffer );
539 <    }
540 <    else
541 <      strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
542 <
543 <    finalOut << writeLine;
544 <  }
545 <  finalOut.flush();
546 <  finalOut.close();
547 <
548 < #else // is_mpi
549 <
550 <  // first thing first, suspend fatalities.
551 <  painCave.isEventLoop = 1;
552 <
553 <  int myStatus; // 1 = wakeup & success; 0 = error; -1 = AllDone
554 <  int haveError;
555 <
556 <  MPI_Status istatus;
557 <  int *AtomToProcMap = mpiSim->getAtomToProcMap();
558 <
559 <  // write out header and node 0's coordinates
560 <
561 <  if( worldRank == 0 ){
562 <    finalOut << mpiSim->getTotAtoms() << "\n";
563 <
564 <    finalOut << finalTime << ";\t"
565 <            << entry_plug->Hmat[0][0] << "\t"
566 <            << entry_plug->Hmat[1][0] << "\t"
567 <            << entry_plug->Hmat[2][0] << ";\t"
568 <
569 <            << entry_plug->Hmat[0][1] << "\t"
570 <            << entry_plug->Hmat[1][1] << "\t"
571 <            << entry_plug->Hmat[2][1] << ";\t"
572 <
573 <            << entry_plug->Hmat[0][2] << "\t"
574 <            << entry_plug->Hmat[1][2] << "\t"
575 <            << entry_plug->Hmat[2][2] << ";";
576 <
577 <    finalOut << entry_plug->the_integrator->getAdditionalParameters();
578 <    finalOut << endl;
579 <    finalOut.flush();
580 <    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
581 <      // Get the Node number which has this atom;
582 <
583 <      which_node = AtomToProcMap[i];
584 <
585 <      if (which_node != 0) {
586 <        
587 <        atomTypeTag          = 4*i;
588 <        atomIsDirectionalTag = 4*i + 1;
589 <        atomTransDataTag     = 4*i + 2;
590 <        atomOrientDataTag    = 4*i + 3;
591 <
592 <        MPI_Recv(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, which_node,
593 <                 atomTypeTag, MPI_COMM_WORLD, &istatus);
594 <        
595 <        strncpy(atomTypeString, MPIatomTypeString, MINIBUFFERSIZE);
596 <
597 <        MPI_Recv(&isDirectional, 1, MPI_INT, which_node,
598 <                 atomIsDirectionalTag, MPI_COMM_WORLD, &istatus);
599 <        
600 <        MPI_Recv(atomTransData, 6, MPI_DOUBLE, which_node,
601 <                 atomTransDataTag, MPI_COMM_WORLD, &istatus);
602 <
603 <        if (isDirectional) {
604 <
605 <          MPI_Recv(atomOrientData, 7, MPI_DOUBLE, which_node,
606 <                   atomOrientDataTag, MPI_COMM_WORLD, &istatus);
607 <
608 <        }
609 <
458 >      if (!isDirectional) {
459 >        
460 >        sprintf( writeLine,
461 >                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
462 >                 atomTypeString,
463 >                 atomData6[0],
464 >                 atomData6[1],
465 >                 atomData6[2],
466 >                 atomData6[3],
467 >                 atomData6[4],
468 >                 atomData6[5]);
469 >        
470 >        strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
471 >        
472        } else {
473 +        
474 +        sprintf( writeLine,
475 +                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
476 +                 atomTypeString,
477 +                 atomData13[0],
478 +                 atomData13[1],
479 +                 atomData13[2],
480 +                 atomData13[3],
481 +                 atomData13[4],
482 +                 atomData13[5],
483 +                 atomData13[6],
484 +                 atomData13[7],
485 +                 atomData13[8],
486 +                 atomData13[9],
487 +                 atomData13[10],
488 +                 atomData13[11],
489 +                 atomData13[12]);
490          
612 –        haveError = 0;
613 –        which_atom = i;
614 –        local_index=-1;
615 –
616 –        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
617 –          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
618 –        }
619 –
620 –        if (local_index != -1) {
621 –
622 –          atomTypeString = atoms[local_index]->getType();
623 –
624 –          atoms[local_index]->getPos(pos);
625 –          atoms[local_index]->getVel(vel);
626 –
627 –          atomTransData[0] = pos[0];
628 –          atomTransData[1] = pos[1];
629 –          atomTransData[2] = pos[2];
630 –
631 –          atomTransData[3] = vel[0];
632 –          atomTransData[4] = vel[1];
633 –          atomTransData[5] = vel[2];
634 –          
635 –          isDirectional = 0;
636 –
637 –          if( atoms[local_index]->isDirectional() ){
638 –
639 –            isDirectional = 1;
640 –            
641 –            dAtom = (DirectionalAtom *)atoms[local_index];
642 –            dAtom->getQ( q );
643 –            
644 –            atomOrientData[0] = q[0];
645 –            atomOrientData[1] = q[1];
646 –            atomOrientData[2] = q[2];
647 –            atomOrientData[3] = q[3];
648 –
649 –            atomOrientData[4] = dAtom->getJx();
650 –            atomOrientData[5] = dAtom->getJy();
651 –            atomOrientData[6] = dAtom->getJz();
652 –          }
653 –
654 –        } else {
655 –          sprintf(painCave.errMsg,
656 –                  "Atom %d not found on processor %d\n",
657 –                  i, worldRank );
658 –          haveError= 1;
659 –          simError();
660 –        }
661 –
662 –        if(haveError) DieDieDie();
663 –                              
664 –        // If we've survived to here, format the line:
665 –        
666 –        sprintf( tempBuffer,
667 –                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
668 –                 atomTypeString,
669 –                 atomTransData[0],
670 –                 atomTransData[1],
671 –                 atomTransData[2],
672 –                 atomTransData[3],
673 –                 atomTransData[4],
674 –                 atomTransData[5]);
675 –
676 –        strcpy( writeLine, tempBuffer );
677 –
678 –        if (isDirectional) {
679 –
680 –          sprintf( tempBuffer,
681 –                   "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
682 –                   atomOrientData[0],
683 –                   atomOrientData[1],
684 –                   atomOrientData[2],
685 –                   atomOrientData[3],
686 –                   atomOrientData[4],
687 –                   atomOrientData[5],
688 –                   atomOrientData[6]);
689 –          strcat( writeLine, tempBuffer );
690 –
691 –        } else {
692 –          strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
693 –        }
694 –
695 –        finalOut << writeLine;
696 –        finalOut.flush();
491        }
492 +      
493 +      for(k = 0; k < outFile.size(); k++)
494 +        *outFile[k] << writeLine;
495      }
496 <
497 <    finalOut.flush();
496 >    
497 >    for(k = 0; k < outFile.size(); k++)
498 >      outFile[k]->flush();
499 >    
500      sprintf( checkPointMsg,
501               "Sucessfully took a dump.\n");
502 +    
503      MPIcheckPoint();        
504      
505 +    delete[] potatoes;
506 +    
507    } else {
508  
509      // worldRank != 0, so I'm a remote node.  
510 +
511 +    // Set my magic potato to 0:
512 +
513 +    myPotato = 0;
514 +    currentIndex = 0;
515      
516      for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
517        
# Line 712 | Line 519 | void DumpWriter::writeFinal(double finalTime){
519        
520        if (AtomToProcMap[i] == worldRank) {
521  
522 <        local_index=-1;
523 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
524 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
522 >        if (myPotato + 3 >= MAXTAG) {
523 >          
524 >          // The potato was going to exceed the maximum value,
525 >          // so wrap this processor potato back to 0 (and block until
526 >          // node 0 says we can go:
527 >          
528 >          MPI_Recv(&myPotato, 1, MPI_INT, 0, 0, MPI_COMM_WORLD, &istatus);
529 >          
530          }
531 <        if (local_index != -1) {
531 >        which_atom = i;
532 >
533 >        //local_index = -1;
534 >
535 >        //for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
536 >        // if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
537 >        //}
538 >        
539 >        //if (local_index != -1) {
540 >
541 >        local_index = indexArray[currentIndex].first;        
542 >                
543 >        if (which_atom == indexArray[currentIndex].second) {
544          
545            atomTypeString = atoms[local_index]->getType();
546 <
546 >          
547            atoms[local_index]->getPos(pos);
548            atoms[local_index]->getVel(vel);
549 +          
550 +          atomData6[0] = pos[0];
551 +          atomData6[1] = pos[1];
552 +          atomData6[2] = pos[2];
553  
554 <          atomTransData[0] = pos[0];
555 <          atomTransData[1] = pos[1];
556 <          atomTransData[2] = pos[2];
729 <
730 <          atomTransData[3] = vel[0];
731 <          atomTransData[4] = vel[1];
732 <          atomTransData[5] = vel[2];
554 >          atomData6[3] = vel[0];
555 >          atomData6[4] = vel[1];
556 >          atomData6[5] = vel[2];
557            
558            isDirectional = 0;
559  
# Line 740 | Line 564 | void DumpWriter::writeFinal(double finalTime){
564              dAtom = (DirectionalAtom *)atoms[local_index];
565              dAtom->getQ( q );
566              
567 <            atomOrientData[0] = q[0];
568 <            atomOrientData[1] = q[1];
569 <            atomOrientData[2] = q[2];
570 <            atomOrientData[3] = q[3];
571 <
572 <            atomOrientData[4] = dAtom->getJx();
573 <            atomOrientData[5] = dAtom->getJy();
574 <            atomOrientData[6] = dAtom->getJz();
567 >            for (int j = 0; j < 6 ; j++)
568 >              atomData13[j] = atomData6[j];
569 >            
570 >            atomData13[6] = q[0];
571 >            atomData13[7] = q[1];
572 >            atomData13[8] = q[2];
573 >            atomData13[9] = q[3];
574 >  
575 >            atomData13[10] = dAtom->getJx();
576 >            atomData13[11] = dAtom->getJy();
577 >            atomData13[12] = dAtom->getJz();
578            }
579  
580          } else {
581            sprintf(painCave.errMsg,
582 <                  "Atom %d not found on processor %d\n",
583 <                  i, worldRank );
582 >                  "Atom %d not found on processor %d, currentIndex = %d, local_index = %d\n",
583 >                  which_atom, worldRank, currentIndex, local_index );
584            haveError= 1;
585            simError();
586          }
587 <
761 <        // I've survived this far, so send off the data!
762 <
763 <        atomTypeTag          = 4*i;
764 <        atomIsDirectionalTag = 4*i + 1;
765 <        atomTransDataTag     = 4*i + 2;
766 <        atomOrientDataTag    = 4*i + 3;
767 <
587 >        
588          strncpy(MPIatomTypeString, atomTypeString, MINIBUFFERSIZE);
589  
590 +        // null terminate the string before sending (just in case):
591 +        MPIatomTypeString[MINIBUFFERSIZE-1] = '\0';
592 +
593          MPI_Send(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, 0,
594 <                 atomTypeTag, MPI_COMM_WORLD);
594 >                             myPotato, MPI_COMM_WORLD);
595          
596 +        myPotato++;
597 +
598          MPI_Send(&isDirectional, 1, MPI_INT, 0,
599 <                 atomIsDirectionalTag, MPI_COMM_WORLD);
599 >                             myPotato, MPI_COMM_WORLD);
600          
601 <        MPI_Send(atomTransData, 6, MPI_DOUBLE, 0,
602 <                 atomTransDataTag, MPI_COMM_WORLD);
778 <
601 >        myPotato++;
602 >        
603          if (isDirectional) {
604  
605 <          MPI_Send(atomOrientData, 7, MPI_DOUBLE, 0,
606 <                   atomOrientDataTag, MPI_COMM_WORLD);
605 >          MPI_Send(atomData13, 13, MPI_DOUBLE, 0,
606 >                   myPotato, MPI_COMM_WORLD);
607            
608 +        } else {
609 +
610 +          MPI_Send(atomData6, 6, MPI_DOUBLE, 0,
611 +                   myPotato, MPI_COMM_WORLD);
612          }
613 <      
613 >
614 >        myPotato++;  
615 >        currentIndex++;    
616        }
617      }
618  
619      sprintf( checkPointMsg,
620 <             "Sucessfully wrote final file.\n");
620 >             "Sucessfully took a dump.\n");
621      MPIcheckPoint();        
622      
623 <  }
623 >  }
624    
795 –  painCave.isEventLoop = 0;
796 –
797 –  if( worldRank == 0 ) finalOut.close();
625   #endif // is_mpi
626   }
627  
801 –
802 –
628   #ifdef IS_MPI
629  
630   // a couple of functions to let us escape the write loop

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines