ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/group/trunk/OOPSE/libmdtools/DumpWriter.cpp
(Generate patch)

Comparing trunk/OOPSE/libmdtools/DumpWriter.cpp (file contents):
Revision 913 by chuckv, Thu Jan 8 22:25:52 2004 UTC vs.
Revision 951 by mmeineke, Fri Jan 16 21:51:51 2004 UTC

# Line 3 | Line 3
3   #include <string.h>
4   #include <iostream>
5   #include <fstream>
6 + #include <algorithm>
7 + #include <utility>
8  
9   #ifdef IS_MPI
10   #include <mpi.h>
# Line 26 | Line 28 | DumpWriter::DumpWriter( SimInfo* the_entry_plug ){
28    if(worldRank == 0 ){
29   #endif // is_mpi
30  
31 <    strcpy( outName, entry_plug->sampleName );
31 >    dumpFile.open(entry_plug->sampleName, ios::out | ios::trunc );
32  
33 <    outFile.open(outName, ios::out | ios::trunc );
33 >    if( !dumpFile ){
34  
33 –    if( !outFile ){
34 –
35        sprintf( painCave.errMsg,
36                 "Could not open \"%s\" for dump output.\n",
37 <               outName);
37 >               entry_plug->sampleName);
38        painCave.isFatal = 1;
39        simError();
40      }
41  
42 –    //outFile.setf( ios::scientific );
43 –
42   #ifdef IS_MPI
43    }
44  
45 +  //sort the local atoms by global index
46 +  sortByGlobalIndex();
47 +  
48    sprintf( checkPointMsg,
49             "Sucessfully opened output file for dumping.\n");
50    MPIcheckPoint();
# Line 56 | Line 57 | DumpWriter::~DumpWriter( ){
57    if(worldRank == 0 ){
58   #endif // is_mpi
59  
60 <    outFile.close();
60 >    dumpFile.close();
61  
62   #ifdef IS_MPI
63    }
64   #endif // is_mpi
65   }
66  
67 < void DumpWriter::writeDump( double currentTime ){
67 > #ifdef IS_MPI
68  
69 + /**
70 + * A hook function to load balancing
71 + */
72 +
73 + void DumpWriter::update(){
74 +  sortByGlobalIndex();          
75 + }
76 +  
77 + /**
78 + * Auxiliary sorting function
79 + */
80 +
81 + bool indexSortingCriterion(const pair<int, int>& p1, const pair<int, int>& p2){
82 +  return p1.second < p2.second;
83 + }
84 +
85 + /**
86 + * Sorting the local index by global index
87 + */
88 +
89 + void DumpWriter::sortByGlobalIndex(){
90 +  Atom** atoms = entry_plug->atoms;
91 +  
92 +  indexArray.clear();
93 +  
94 +  for(int i = 0; i < mpiSim->getMyNlocal();i++)
95 +    indexArray.push_back(make_pair(i, atoms[i]->getGlobalIndex()));
96 +  
97 +  sort(indexArray.begin(), indexArray.end(), indexSortingCriterion);    
98 +
99 +  //for (int i = 0; i < mpiSim->getMyNlocal(); i++) {
100 +  //  printf("node %d has global %d at local %d\n", worldRank, indexArray[i].second, indexArray[i].first);
101 +  //}
102 +    
103 + }
104 +
105 + #endif
106 +
107 + void DumpWriter::writeDump(double currentTime){
108 +
109 +  ofstream finalOut;
110 +  vector<ofstream*> fileStreams;
111 +
112 + #ifdef IS_MPI
113 +  printf("Hello from node %d\n", worldRank);
114 +  sortByGlobalIndex();
115 +  if(worldRank == 0 ){
116 +    
117 +    finalOut.open( entry_plug->finalName, ios::out | ios::trunc );
118 +    if( !finalOut ){
119 +      sprintf( painCave.errMsg,
120 +               "Could not open \"%s\" for final dump output.\n",
121 +               entry_plug->finalName );
122 +      painCave.isFatal = 1;
123 +      simError();
124 +    }
125 +  }
126 + #endif // is_mpi
127 +
128 +  fileStreams.push_back(&finalOut);
129 +  fileStreams.push_back(&dumpFile);
130 +
131 +  writeFrame(fileStreams, currentTime);
132 +
133 + #ifdef IS_MPI
134 +  finalOut.close();
135 + #endif
136 +        
137 + }
138 +
139 + void DumpWriter::writeFinal(double currentTime){
140 +
141 +  ofstream finalOut;
142 +  vector<ofstream*> fileStreams;
143 +
144 + #ifdef IS_MPI
145 +  if(worldRank == 0 ){
146 + #endif // is_mpi
147 +
148 +    finalOut.open( entry_plug->finalName, ios::out | ios::trunc );
149 +
150 +    if( !finalOut ){
151 +      sprintf( painCave.errMsg,
152 +               "Could not open \"%s\" for final dump output.\n",
153 +               entry_plug->finalName );
154 +      painCave.isFatal = 1;
155 +      simError();
156 +    }
157 +
158 + #ifdef IS_MPI
159 +  }
160 + #endif // is_mpi
161 +  
162 +  fileStreams.push_back(&finalOut);  
163 +  writeFrame(fileStreams, currentTime);
164 +
165 + #ifdef IS_MPI
166 +  finalOut.close();
167 + #endif
168 +  
169 + }
170 +
171 + void DumpWriter::writeFrame( vector<ofstream*>& outFile, double currentTime ){
172 +
173    const int BUFFERSIZE = 2000;
174    const int MINIBUFFERSIZE = 100;
175  
176 <  char tempBuffer[BUFFERSIZE];
176 >  char tempBuffer[BUFFERSIZE];  
177    char writeLine[BUFFERSIZE];
178  
179 <  int i;
179 >  int i, k;
180 >
181   #ifdef IS_MPI
182 <  int j, which_node, done, which_atom, local_index;
183 <  double atomTransData[6];
184 <  double atomOrientData[7];
182 >  
183 >  /*********************************************************************
184 >   * Documentation?  You want DOCUMENTATION?
185 >   *
186 >   * Why all the potatoes below?  
187 >   *
188 >   * To make a long story short, the original version of DumpWriter
189 >   * worked in the most inefficient way possible.  Node 0 would
190 >   * poke each of the node for an individual atom's formatted data
191 >   * as node 0 worked its way down the global index. This was particularly
192 >   * inefficient since the method blocked all processors at every atom
193 >   * (and did it twice!).
194 >   *
195 >   * An intermediate version of DumpWriter could be described from Node
196 >   * zero's perspective as follows:
197 >   *
198 >   *  1) Have 100 of your friends stand in a circle.
199 >   *  2) When you say go, have all of them start tossing potatoes at
200 >   *     you (one at a time).
201 >   *  3) Catch the potatoes.
202 >   *
203 >   * It was an improvement, but MPI has buffers and caches that could
204 >   * best be described in this analogy as "potato nets", so there's no
205 >   * need to block the processors atom-by-atom.
206 >   *
207 >   * This new and improved DumpWriter works in an even more efficient
208 >   * way:
209 >   *
210 >   *  1) Have 100 of your friend stand in a circle.
211 >   *  2) When you say go, have them start tossing 5-pound bags of
212 >   *     potatoes at you.
213 >   *  3) Once you've caught a friend's bag of potatoes,
214 >   *     toss them a spud to let them know they can toss another bag.
215 >   *
216 >   * How's THAT for documentation?
217 >   *
218 >   *********************************************************************/
219 >
220 >  int *potatoes;
221 >  int myPotato;
222 >
223 >  int nProc;
224 >  int j, which_node, done, which_atom, local_index, currentIndex;
225 >  double atomData6[6];
226 >  double atomData13[13];
227    int isDirectional;
228    char* atomTypeString;
229    char MPIatomTypeString[MINIBUFFERSIZE];
230 <  int me;
83 <  int atomTypeTag;
84 <  int atomIsDirectionalTag;
85 <  int atomTransDataTag;
86 <  int atomOrientDataTag;
230 >
231   #else //is_mpi
232    int nAtoms = entry_plug->n_atoms;
233   #endif //is_mpi
# Line 93 | Line 237 | void DumpWriter::writeDump( double currentTime ){
237    Atom** atoms = entry_plug->atoms;
238    double pos[3], vel[3];
239  
96 –  // write current frame to the eor file
97 –
98 –  this->writeFinal( currentTime );
99 –
240   #ifndef IS_MPI
241 +  
242 +  for(k = 0; k < outFile.size(); k++){
243 +    *outFile[k] << nAtoms << "\n";
244  
245 <  outFile << nAtoms << "\n";
245 >    *outFile[k] << currentTime << ";\t"
246 >               << entry_plug->Hmat[0][0] << "\t"
247 >                     << entry_plug->Hmat[1][0] << "\t"
248 >                     << entry_plug->Hmat[2][0] << ";\t"
249 >              
250 >               << entry_plug->Hmat[0][1] << "\t"
251 >                     << entry_plug->Hmat[1][1] << "\t"
252 >                     << entry_plug->Hmat[2][1] << ";\t"
253  
254 <  outFile << currentTime << ";\t"
255 <          << entry_plug->Hmat[0][0] << "\t"
256 <          << entry_plug->Hmat[1][0] << "\t"
107 <          << entry_plug->Hmat[2][0] << ";\t"
254 >                     << entry_plug->Hmat[0][2] << "\t"
255 >                     << entry_plug->Hmat[1][2] << "\t"
256 >                     << entry_plug->Hmat[2][2] << ";";
257  
258 <          << entry_plug->Hmat[0][1] << "\t"
259 <          << entry_plug->Hmat[1][1] << "\t"
260 <          << entry_plug->Hmat[2][1] << ";\t"
261 <
113 <          << entry_plug->Hmat[0][2] << "\t"
114 <          << entry_plug->Hmat[1][2] << "\t"
115 <          << entry_plug->Hmat[2][2] << ";";
116 <  //write out additional parameters, such as chi and eta
117 <  outFile << entry_plug->the_integrator->getAdditionalParameters();
118 <  outFile << endl;
119 <
258 >    //write out additional parameters, such as chi and eta
259 >    *outFile[k] << entry_plug->the_integrator->getAdditionalParameters() << endl;
260 >  }
261 >  
262    for( i=0; i<nAtoms; i++ ){
263  
264      atoms[i]->getPos(pos);
# Line 152 | Line 294 | void DumpWriter::writeDump( double currentTime ){
294      else
295        strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
296  
297 <    outFile << writeLine;
297 >    for(k = 0; k < outFile.size(); k++)
298 >      *outFile[k] << writeLine;
299    }
157 –  outFile.flush();
300  
301   #else // is_mpi
302  
303    /* code to find maximum tag value */
304 +  
305    int *tagub, flag, MAXTAG;
306    MPI_Attr_get(MPI_COMM_WORLD, MPI_TAG_UB, &tagub, &flag);
307    if (flag) {
308      MAXTAG = *tagub;
309    } else {
310      MAXTAG = 32767;
311 <  }
311 >  }  
312  
313    int haveError;
314  
# Line 175 | Line 318 | void DumpWriter::writeDump( double currentTime ){
318    // write out header and node 0's coordinates
319  
320    if( worldRank == 0 ){
178 –    outFile << mpiSim->getTotAtoms() << "\n";
321  
322 <    outFile << currentTime << ";\t"
181 <            << entry_plug->Hmat[0][0] << "\t"
182 <            << entry_plug->Hmat[1][0] << "\t"
183 <            << entry_plug->Hmat[2][0] << ";\t"
322 >    // Node 0 needs a list of the magic potatoes for each processor;
323  
324 <            << entry_plug->Hmat[0][1] << "\t"
325 <            << entry_plug->Hmat[1][1] << "\t"
187 <            << entry_plug->Hmat[2][1] << ";\t"
324 >    nProc = mpiSim->getNumberProcessors();
325 >    potatoes = new int[nProc];
326  
327 <            << entry_plug->Hmat[0][2] << "\t"
328 <            << entry_plug->Hmat[1][2] << "\t"
329 <            << entry_plug->Hmat[2][2] << ";";
327 >    //write out the comment lines
328 >    for (i = 0; i < nProc; i++)
329 >      potatoes[i] = 0;
330 >    
331 >      for(k = 0; k < outFile.size(); k++){
332 >        *outFile[k] << mpiSim->getTotAtoms() << "\n";
333  
334 <    outFile << entry_plug->the_integrator->getAdditionalParameters();
335 <    outFile << endl;
336 <    outFile.flush();
334 >        *outFile[k] << currentTime << ";\t"
335 >                         << entry_plug->Hmat[0][0] << "\t"
336 >                         << entry_plug->Hmat[1][0] << "\t"
337 >                         << entry_plug->Hmat[2][0] << ";\t"
338  
339 <    tag = 0;
339 >                         << entry_plug->Hmat[0][1] << "\t"
340 >                         << entry_plug->Hmat[1][1] << "\t"
341 >                         << entry_plug->Hmat[2][1] << ";\t"
342  
343 <    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
343 >                         << entry_plug->Hmat[0][2] << "\t"
344 >                         << entry_plug->Hmat[1][2] << "\t"
345 >                         << entry_plug->Hmat[2][2] << ";";
346 >  
347 >        *outFile[k] << entry_plug->the_integrator->getAdditionalParameters() << endl;
348 >    }
349  
350 <      if (tag + 2 >= MAXTAG) {
351 <        // The tag was going to exceed the maximum value, so wrap around to 0:
352 <        tag = 0;
204 <        // Send the newly zeroed tag on to the other nodes:
205 <        MPI_Bcast(&tag, 1, MPI_INT, 0, MPI_COMM_WORLD);
206 <      }
350 >    currentIndex = 0;
351 >
352 >    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
353        
354        // Get the Node number which has this atom;
355        
356        which_node = AtomToProcMap[i];
357        
358        if (which_node != 0) {
359 +
360 +        if (potatoes[which_node] + 3 >= MAXTAG) {
361 +          // The potato was going to exceed the maximum value,
362 +          // so wrap this processor potato back to 0:        
363 +
364 +          potatoes[which_node] = 0;          
365 +          MPI_Send(0, 1, MPI_INT, which_node, 0, MPI_COMM_WORLD);
366 +          
367 +        }
368 +
369 +        myPotato = potatoes[which_node];        
370          
371          MPI_Recv(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, which_node,
372 <                 atomTypeTag, MPI_COMM_WORLD, &istatus);
372 >                 myPotato, MPI_COMM_WORLD, &istatus);
373          
374 <        strncpy(atomTypeString, MPIatomTypeString, MINIBUFFERSIZE);
375 <        
376 <        // Null terminate the atomTypeString just in case:
374 >        atomTypeString = MPIatomTypeString;
375 >        
376 >        myPotato++;
377  
221 –        atomTypeString[strlen(atomTypeString) - 1] = '\0';
222 –
378          MPI_Recv(&isDirectional, 1, MPI_INT, which_node,
379 <                 atomIsDirectionalTag, MPI_COMM_WORLD, &istatus);
380 <        
381 <        MPI_Recv(atomTransData, 6, MPI_DOUBLE, which_node,
227 <                 atomTransDataTag, MPI_COMM_WORLD, &istatus);
379 >                 myPotato, MPI_COMM_WORLD, &istatus);
380 >              
381 >        myPotato++;
382  
383 <        if (isDirectional) {
384 <
385 <          MPI_Recv(atomOrientData, 7, MPI_DOUBLE, which_node,
386 <                   atomOrientDataTag, MPI_COMM_WORLD, &istatus);
387 <
383 >        if (isDirectional) {          
384 >          MPI_Recv(atomData13, 13, MPI_DOUBLE, which_node,
385 >                   myPotato, MPI_COMM_WORLD, &istatus);
386 >        } else {
387 >          MPI_Recv(atomData6, 6, MPI_DOUBLE, which_node,
388 >                   myPotato, MPI_COMM_WORLD, &istatus);          
389          }
390 +        
391 +        myPotato++;
392 +        potatoes[which_node] = myPotato;
393  
394        } else {
395          
396 <        haveError = 0;
396 >        haveError = 0;
397          which_atom = i;
398 <        local_index=-1;
398 >        
399 >        //local_index = -1;
400  
401 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
402 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
403 <        }
404 <
405 <        if (local_index != -1) {
406 <
407 <          atomTypeString = atoms[local_index]->getType();
408 <
401 >        //for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
402 >        //  if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
403 >        //}
404 >        
405 >        //if (local_index != -1) {
406 >          
407 >          local_index = indexArray[currentIndex].first;        
408 >          
409 >          if (which_atom == indexArray[currentIndex].second) {
410 >            
411 >            atomTypeString = atoms[local_index]->getType();
412 >            
413            atoms[local_index]->getPos(pos);
414 <          atoms[local_index]->getVel(vel);
414 >          atoms[local_index]->getVel(vel);          
415 >          
416 >          atomData6[0] = pos[0];
417 >          atomData6[1] = pos[1];
418 >          atomData6[2] = pos[2];
419  
420 <          atomTransData[0] = pos[0];
421 <          atomTransData[1] = pos[1];
422 <          atomTransData[2] = pos[2];
256 <
257 <          atomTransData[3] = vel[0];
258 <          atomTransData[4] = vel[1];
259 <          atomTransData[5] = vel[2];
420 >          atomData6[3] = vel[0];
421 >          atomData6[4] = vel[1];
422 >          atomData6[5] = vel[2];
423            
424            isDirectional = 0;
425  
# Line 266 | Line 429 | void DumpWriter::writeDump( double currentTime ){
429              
430              dAtom = (DirectionalAtom *)atoms[local_index];
431              dAtom->getQ( q );
269 –            
270 –            atomOrientData[0] = q[0];
271 –            atomOrientData[1] = q[1];
272 –            atomOrientData[2] = q[2];
273 –            atomOrientData[3] = q[3];
432  
433 <            atomOrientData[4] = dAtom->getJx();
434 <            atomOrientData[5] = dAtom->getJy();
435 <            atomOrientData[6] = dAtom->getJz();
433 >            for (int j = 0; j < 6 ; j++)
434 >              atomData13[j] = atomData6[j];            
435 >            
436 >            atomData13[6] = q[0];
437 >            atomData13[7] = q[1];
438 >            atomData13[8] = q[2];
439 >            atomData13[9] = q[3];
440 >            
441 >            atomData13[10] = dAtom->getJx();
442 >            atomData13[11] = dAtom->getJy();
443 >            atomData13[12] = dAtom->getJz();
444            }
445 <
445 >          
446          } else {
447            sprintf(painCave.errMsg,
448 <                  "Atom %d not found on processor %d\n",
449 <                  i, worldRank );
448 >                  "Atom %d not found on processor %d, currentIndex = %d, local_index = %d\n",
449 >                  which_atom, worldRank, currentIndex, local_index );
450            haveError= 1;
451            simError();
452          }
287 –
288 –        if(haveError) DieDieDie();
289 –                              
290 –        // If we've survived to here, format the line:
453          
454 <        sprintf( tempBuffer,
455 <                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
456 <                 atomTypeString,
295 <                 atomTransData[0],
296 <                 atomTransData[1],
297 <                 atomTransData[2],
298 <                 atomTransData[3],
299 <                 atomTransData[4],
300 <                 atomTransData[5]);
301 <
302 <        strcpy( writeLine, tempBuffer );
303 <
304 <        if (isDirectional) {
305 <
306 <          sprintf( tempBuffer,
307 <                   "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
308 <                   atomOrientData[0],
309 <                   atomOrientData[1],
310 <                   atomOrientData[2],
311 <                   atomOrientData[3],
312 <                   atomOrientData[4],
313 <                   atomOrientData[5],
314 <                   atomOrientData[6]);
315 <          strcat( writeLine, tempBuffer );
316 <
317 <        } else {
318 <          strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
319 <        }
320 <
321 <        outFile << writeLine;
322 <        outFile.flush();
454 >        if(haveError) DieDieDie();
455 >        
456 >        currentIndex++;
457        }
458 <    }
325 <
326 <    outFile.flush();
327 <    sprintf( checkPointMsg,
328 <             "Sucessfully took a dump.\n");
329 <    MPIcheckPoint();        
330 <    
331 <  } else {
332 <
333 <    // worldRank != 0, so I'm a remote node.  
334 <    
335 <    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
458 >      // If we've survived to here, format the line:
459        
460 <      // Am I the node which has this atom?
461 <      
462 <      if (AtomToProcMap[i] == worldRank) {
463 <
464 <        local_index=-1;
465 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
466 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
467 <        }
468 <        if (local_index != -1) {
469 <        
470 <          atomTypeString = atoms[local_index]->getType();
471 <
472 <          atoms[local_index]->getPos(pos);
473 <          atoms[local_index]->getVel(vel);
351 <
352 <          atomTransData[0] = pos[0];
353 <          atomTransData[1] = pos[1];
354 <          atomTransData[2] = pos[2];
355 <
356 <          atomTransData[3] = vel[0];
357 <          atomTransData[4] = vel[1];
358 <          atomTransData[5] = vel[2];
359 <          
360 <          isDirectional = 0;
361 <
362 <          if( atoms[local_index]->isDirectional() ){
363 <
364 <            isDirectional = 1;
365 <            
366 <            dAtom = (DirectionalAtom *)atoms[local_index];
367 <            dAtom->getQ( q );
368 <            
369 <            atomOrientData[0] = q[0];
370 <            atomOrientData[1] = q[1];
371 <            atomOrientData[2] = q[2];
372 <            atomOrientData[3] = q[3];
373 <
374 <            atomOrientData[4] = dAtom->getJx();
375 <            atomOrientData[5] = dAtom->getJy();
376 <            atomOrientData[6] = dAtom->getJz();
377 <          }
378 <
379 <        } else {
380 <          sprintf(painCave.errMsg,
381 <                  "Atom %d not found on processor %d\n",
382 <                  i, worldRank );
383 <          haveError= 1;
384 <          simError();
385 <        }
386 <
387 <        // I've survived this far, so send off the data!
388 <
389 <        atomTypeTag          = 4*i;
390 <        atomIsDirectionalTag = 4*i + 1;
391 <        atomTransDataTag     = 4*i + 2;
392 <        atomOrientDataTag    = 4*i + 3;
393 <
394 <
395 <        strncpy(MPIatomTypeString, atomTypeString, MINIBUFFERSIZE);
396 <
397 <        // null terminate the string before sending (just in case):
398 <        MPIatomTypeString[MINIBUFFERSIZE-1] = '\0';
399 <
400 <        MPI_Send(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, 0,
401 <                 atomTypeTag, MPI_COMM_WORLD);
402 <        
403 <        MPI_Send(&isDirectional, 1, MPI_INT, 0,
404 <                 atomIsDirectionalTag, MPI_COMM_WORLD);
405 <        
406 <        MPI_Send(atomTransData, 6, MPI_DOUBLE, 0,
407 <                 atomTransDataTag, MPI_COMM_WORLD);
408 <
409 <        if (isDirectional) {
410 <
411 <          MPI_Send(atomOrientData, 7, MPI_DOUBLE, 0,
412 <                   atomOrientDataTag, MPI_COMM_WORLD);
413 <          
414 <        }
415 <      
416 <      }
417 <    }
418 <
419 <    sprintf( checkPointMsg,
420 <             "Sucessfully took a dump.\n");
421 <    MPIcheckPoint();        
422 <    
423 <  }
424 <  
425 <  painCave.isEventLoop = 0;
426 <
427 < #endif // is_mpi
428 < }
429 <
430 < void DumpWriter::writeFinal(double finalTime){
431 <
432 <  char finalName[500];
433 <  ofstream finalOut;
434 <
435 <  const int BUFFERSIZE = 2000;
436 <  const int MINIBUFFERSIZE = 100;
437 <  char tempBuffer[BUFFERSIZE];
438 <  char writeLine[BUFFERSIZE];
439 <
440 <  double q[4];
441 <  DirectionalAtom* dAtom;
442 <  Atom** atoms = entry_plug->atoms;
443 <  int i;
444 < #ifdef IS_MPI
445 <  int j, which_node, done, which_atom, local_index;
446 <  double atomTransData[6];
447 <  double atomOrientData[7];
448 <  int isDirectional;
449 <  char* atomTypeString;
450 <  char MPIatomTypeString[MINIBUFFERSIZE];
451 <  int atomTypeTag;
452 <  int atomIsDirectionalTag;
453 <  int atomTransDataTag;
454 <  int atomOrientDataTag;
455 < #else //is_mpi
456 <  int nAtoms = entry_plug->n_atoms;
457 < #endif //is_mpi
458 <
459 <  double pos[3], vel[3];
460 <
461 < #ifdef IS_MPI
462 <  if(worldRank == 0 ){
463 < #endif // is_mpi
464 <
465 <    strcpy( finalName, entry_plug->finalName );
466 <
467 <    finalOut.open( finalName, ios::out | ios::trunc );
468 <    if( !finalOut ){
469 <      sprintf( painCave.errMsg,
470 <               "Could not open \"%s\" for final dump output.\n",
471 <               finalName );
472 <      painCave.isFatal = 1;
473 <      simError();
474 <    }
475 <
476 <    // finalOut.setf( ios::scientific );
477 <
478 < #ifdef IS_MPI
479 <  }
480 <
481 <  sprintf(checkPointMsg,"Opened file for final configuration\n");
482 <  MPIcheckPoint();
483 <
484 < #endif //is_mpi
485 <
486 <
487 < #ifndef IS_MPI
488 <
489 <  finalOut << nAtoms << "\n";
490 <
491 <  finalOut << finalTime << ";\t"
492 <           << entry_plug->Hmat[0][0] << "\t"
493 <           << entry_plug->Hmat[1][0] << "\t"
494 <           << entry_plug->Hmat[2][0] << ";\t"
495 <
496 <           << entry_plug->Hmat[0][1] << "\t"
497 <           << entry_plug->Hmat[1][1] << "\t"
498 <           << entry_plug->Hmat[2][1] << ";\t"
499 <
500 <           << entry_plug->Hmat[0][2] << "\t"
501 <           << entry_plug->Hmat[1][2] << "\t"
502 <           << entry_plug->Hmat[2][2] << ";";
503 <
504 <  //write out additional parameters, such as chi and eta
505 <  finalOut << entry_plug->the_integrator->getAdditionalParameters();
506 <  finalOut << endl;
507 <
508 <  for( i=0; i<nAtoms; i++ ){
509 <
510 <    atoms[i]->getPos(pos);
511 <    atoms[i]->getVel(vel);
512 <
513 <    sprintf( tempBuffer,
514 <             "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
515 <             atoms[i]->getType(),
516 <             pos[0],
517 <             pos[1],
518 <             pos[2],
519 <             vel[0],
520 <             vel[1],
521 <             vel[2]);
522 <    strcpy( writeLine, tempBuffer );
523 <
524 <    if( atoms[i]->isDirectional() ){
525 <
526 <      dAtom = (DirectionalAtom *)atoms[i];
527 <      dAtom->getQ( q );
528 <
529 <      sprintf( tempBuffer,
530 <               "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
531 <               q[0],
532 <               q[1],
533 <               q[2],
534 <               q[3],
535 <               dAtom->getJx(),
536 <               dAtom->getJy(),
537 <               dAtom->getJz());
538 <      strcat( writeLine, tempBuffer );
539 <    }
540 <    else
541 <      strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
542 <
543 <    finalOut << writeLine;
544 <  }
545 <  finalOut.flush();
546 <  finalOut.close();
547 <
548 < #else // is_mpi
549 <
550 <  // first thing first, suspend fatalities.
551 <  painCave.isEventLoop = 1;
552 <
553 <  int myStatus; // 1 = wakeup & success; 0 = error; -1 = AllDone
554 <  int haveError;
555 <
556 <  MPI_Status istatus;
557 <  int *AtomToProcMap = mpiSim->getAtomToProcMap();
558 <
559 <  // write out header and node 0's coordinates
560 <
561 <  if( worldRank == 0 ){
562 <    finalOut << mpiSim->getTotAtoms() << "\n";
563 <
564 <    finalOut << finalTime << ";\t"
565 <            << entry_plug->Hmat[0][0] << "\t"
566 <            << entry_plug->Hmat[1][0] << "\t"
567 <            << entry_plug->Hmat[2][0] << ";\t"
568 <
569 <            << entry_plug->Hmat[0][1] << "\t"
570 <            << entry_plug->Hmat[1][1] << "\t"
571 <            << entry_plug->Hmat[2][1] << ";\t"
572 <
573 <            << entry_plug->Hmat[0][2] << "\t"
574 <            << entry_plug->Hmat[1][2] << "\t"
575 <            << entry_plug->Hmat[2][2] << ";";
576 <
577 <    finalOut << entry_plug->the_integrator->getAdditionalParameters();
578 <    finalOut << endl;
579 <    finalOut.flush();
580 <    for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
581 <      // Get the Node number which has this atom;
582 <
583 <      which_node = AtomToProcMap[i];
584 <
585 <      if (which_node != 0) {
586 <        
587 <        atomTypeTag          = 4*i;
588 <        atomIsDirectionalTag = 4*i + 1;
589 <        atomTransDataTag     = 4*i + 2;
590 <        atomOrientDataTag    = 4*i + 3;
591 <
592 <        MPI_Recv(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, which_node,
593 <                 atomTypeTag, MPI_COMM_WORLD, &istatus);
594 <        
595 <        strncpy(atomTypeString, MPIatomTypeString, MINIBUFFERSIZE);
596 <
597 <        MPI_Recv(&isDirectional, 1, MPI_INT, which_node,
598 <                 atomIsDirectionalTag, MPI_COMM_WORLD, &istatus);
599 <        
600 <        MPI_Recv(atomTransData, 6, MPI_DOUBLE, which_node,
601 <                 atomTransDataTag, MPI_COMM_WORLD, &istatus);
602 <
603 <        if (isDirectional) {
604 <
605 <          MPI_Recv(atomOrientData, 7, MPI_DOUBLE, which_node,
606 <                   atomOrientDataTag, MPI_COMM_WORLD, &istatus);
607 <
608 <        }
609 <
460 >      if (!isDirectional) {
461 >        
462 >        sprintf( writeLine,
463 >                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
464 >                 atomTypeString,
465 >                 atomData6[0],
466 >                 atomData6[1],
467 >                 atomData6[2],
468 >                 atomData6[3],
469 >                 atomData6[4],
470 >                 atomData6[5]);
471 >        
472 >        strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
473 >        
474        } else {
475 +        
476 +        sprintf( writeLine,
477 +                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
478 +                 atomTypeString,
479 +                 atomData13[0],
480 +                 atomData13[1],
481 +                 atomData13[2],
482 +                 atomData13[3],
483 +                 atomData13[4],
484 +                 atomData13[5],
485 +                 atomData13[6],
486 +                 atomData13[7],
487 +                 atomData13[8],
488 +                 atomData13[9],
489 +                 atomData13[10],
490 +                 atomData13[11],
491 +                 atomData13[12]);
492          
612 –        haveError = 0;
613 –        which_atom = i;
614 –        local_index=-1;
615 –
616 –        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
617 –          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
618 –        }
619 –
620 –        if (local_index != -1) {
621 –
622 –          atomTypeString = atoms[local_index]->getType();
623 –
624 –          atoms[local_index]->getPos(pos);
625 –          atoms[local_index]->getVel(vel);
626 –
627 –          atomTransData[0] = pos[0];
628 –          atomTransData[1] = pos[1];
629 –          atomTransData[2] = pos[2];
630 –
631 –          atomTransData[3] = vel[0];
632 –          atomTransData[4] = vel[1];
633 –          atomTransData[5] = vel[2];
634 –          
635 –          isDirectional = 0;
636 –
637 –          if( atoms[local_index]->isDirectional() ){
638 –
639 –            isDirectional = 1;
640 –            
641 –            dAtom = (DirectionalAtom *)atoms[local_index];
642 –            dAtom->getQ( q );
643 –            
644 –            atomOrientData[0] = q[0];
645 –            atomOrientData[1] = q[1];
646 –            atomOrientData[2] = q[2];
647 –            atomOrientData[3] = q[3];
648 –
649 –            atomOrientData[4] = dAtom->getJx();
650 –            atomOrientData[5] = dAtom->getJy();
651 –            atomOrientData[6] = dAtom->getJz();
652 –          }
653 –
654 –        } else {
655 –          sprintf(painCave.errMsg,
656 –                  "Atom %d not found on processor %d\n",
657 –                  i, worldRank );
658 –          haveError= 1;
659 –          simError();
660 –        }
661 –
662 –        if(haveError) DieDieDie();
663 –                              
664 –        // If we've survived to here, format the line:
665 –        
666 –        sprintf( tempBuffer,
667 –                 "%s\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t",
668 –                 atomTypeString,
669 –                 atomTransData[0],
670 –                 atomTransData[1],
671 –                 atomTransData[2],
672 –                 atomTransData[3],
673 –                 atomTransData[4],
674 –                 atomTransData[5]);
675 –
676 –        strcpy( writeLine, tempBuffer );
677 –
678 –        if (isDirectional) {
679 –
680 –          sprintf( tempBuffer,
681 –                   "%lf\t%lf\t%lf\t%lf\t%lf\t%lf\t%lf\n",
682 –                   atomOrientData[0],
683 –                   atomOrientData[1],
684 –                   atomOrientData[2],
685 –                   atomOrientData[3],
686 –                   atomOrientData[4],
687 –                   atomOrientData[5],
688 –                   atomOrientData[6]);
689 –          strcat( writeLine, tempBuffer );
690 –
691 –        } else {
692 –          strcat( writeLine, "0.0\t0.0\t0.0\t0.0\t0.0\t0.0\t0.0\n" );
693 –        }
694 –
695 –        finalOut << writeLine;
696 –        finalOut.flush();
493        }
494 +      
495 +      for(k = 0; k < outFile.size(); k++)
496 +        *outFile[k] << writeLine;
497      }
498 <
499 <    finalOut.flush();
498 >    
499 >    for(k = 0; k < outFile.size(); k++)
500 >      outFile[k]->flush();
501 >    
502      sprintf( checkPointMsg,
503               "Sucessfully took a dump.\n");
504 +    
505      MPIcheckPoint();        
506      
507 +    delete[] potatoes;
508 +    
509    } else {
510  
511      // worldRank != 0, so I'm a remote node.  
512 +
513 +    // Set my magic potato to 0:
514 +
515 +    myPotato = 0;
516 +    currentIndex = 0;
517      
518      for (i = 0 ; i < mpiSim->getTotAtoms(); i++ ) {
519        
# Line 712 | Line 521 | void DumpWriter::writeFinal(double finalTime){
521        
522        if (AtomToProcMap[i] == worldRank) {
523  
524 <        local_index=-1;
525 <        for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
526 <          if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
524 >        if (myPotato + 3 >= MAXTAG) {
525 >          
526 >          // The potato was going to exceed the maximum value,
527 >          // so wrap this processor potato back to 0 (and block until
528 >          // node 0 says we can go:
529 >          
530 >          MPI_Recv(&myPotato, 1, MPI_INT, 0, 0, MPI_COMM_WORLD, &istatus);
531 >          
532          }
533 <        if (local_index != -1) {
533 >        which_atom = i;
534 >
535 >        //local_index = -1;
536 >
537 >        //for (j=0; (j<mpiSim->getMyNlocal()) && (local_index < 0); j++) {
538 >        // if (atoms[j]->getGlobalIndex() == which_atom) local_index = j;
539 >        //}
540 >        
541 >        //if (local_index != -1) {
542 >
543 >        local_index = indexArray[currentIndex].first;        
544 >                
545 >        if (which_atom == indexArray[currentIndex].second) {
546          
547            atomTypeString = atoms[local_index]->getType();
548 <
548 >          
549            atoms[local_index]->getPos(pos);
550            atoms[local_index]->getVel(vel);
551 +          
552 +          atomData6[0] = pos[0];
553 +          atomData6[1] = pos[1];
554 +          atomData6[2] = pos[2];
555  
556 <          atomTransData[0] = pos[0];
557 <          atomTransData[1] = pos[1];
558 <          atomTransData[2] = pos[2];
729 <
730 <          atomTransData[3] = vel[0];
731 <          atomTransData[4] = vel[1];
732 <          atomTransData[5] = vel[2];
556 >          atomData6[3] = vel[0];
557 >          atomData6[4] = vel[1];
558 >          atomData6[5] = vel[2];
559            
560            isDirectional = 0;
561  
# Line 740 | Line 566 | void DumpWriter::writeFinal(double finalTime){
566              dAtom = (DirectionalAtom *)atoms[local_index];
567              dAtom->getQ( q );
568              
569 <            atomOrientData[0] = q[0];
570 <            atomOrientData[1] = q[1];
571 <            atomOrientData[2] = q[2];
572 <            atomOrientData[3] = q[3];
573 <
574 <            atomOrientData[4] = dAtom->getJx();
575 <            atomOrientData[5] = dAtom->getJy();
576 <            atomOrientData[6] = dAtom->getJz();
569 >            for (int j = 0; j < 6 ; j++)
570 >              atomData13[j] = atomData6[j];
571 >            
572 >            atomData13[6] = q[0];
573 >            atomData13[7] = q[1];
574 >            atomData13[8] = q[2];
575 >            atomData13[9] = q[3];
576 >  
577 >            atomData13[10] = dAtom->getJx();
578 >            atomData13[11] = dAtom->getJy();
579 >            atomData13[12] = dAtom->getJz();
580            }
581  
582          } else {
583            sprintf(painCave.errMsg,
584 <                  "Atom %d not found on processor %d\n",
585 <                  i, worldRank );
584 >                  "Atom %d not found on processor %d, currentIndex = %d, local_index = %d\n",
585 >                  which_atom, worldRank, currentIndex, local_index );
586            haveError= 1;
587            simError();
588          }
589 <
761 <        // I've survived this far, so send off the data!
762 <
763 <        atomTypeTag          = 4*i;
764 <        atomIsDirectionalTag = 4*i + 1;
765 <        atomTransDataTag     = 4*i + 2;
766 <        atomOrientDataTag    = 4*i + 3;
767 <
589 >        
590          strncpy(MPIatomTypeString, atomTypeString, MINIBUFFERSIZE);
591  
592 +        // null terminate the string before sending (just in case):
593 +        MPIatomTypeString[MINIBUFFERSIZE-1] = '\0';
594 +
595          MPI_Send(MPIatomTypeString, MINIBUFFERSIZE, MPI_CHAR, 0,
596 <                 atomTypeTag, MPI_COMM_WORLD);
596 >                             myPotato, MPI_COMM_WORLD);
597          
598 +        myPotato++;
599 +
600          MPI_Send(&isDirectional, 1, MPI_INT, 0,
601 <                 atomIsDirectionalTag, MPI_COMM_WORLD);
601 >                             myPotato, MPI_COMM_WORLD);
602          
603 <        MPI_Send(atomTransData, 6, MPI_DOUBLE, 0,
604 <                 atomTransDataTag, MPI_COMM_WORLD);
778 <
603 >        myPotato++;
604 >        
605          if (isDirectional) {
606  
607 <          MPI_Send(atomOrientData, 7, MPI_DOUBLE, 0,
608 <                   atomOrientDataTag, MPI_COMM_WORLD);
607 >          MPI_Send(atomData13, 13, MPI_DOUBLE, 0,
608 >                   myPotato, MPI_COMM_WORLD);
609            
610 +        } else {
611 +
612 +          MPI_Send(atomData6, 6, MPI_DOUBLE, 0,
613 +                   myPotato, MPI_COMM_WORLD);
614          }
615 <      
615 >
616 >        myPotato++;  
617 >        currentIndex++;    
618        }
619      }
620  
621      sprintf( checkPointMsg,
622 <             "Sucessfully wrote final file.\n");
622 >             "Sucessfully took a dump.\n");
623      MPIcheckPoint();        
624      
625 <  }
625 >  }
626    
795 –  painCave.isEventLoop = 0;
796 –
797 –  if( worldRank == 0 ) finalOut.close();
627   #endif // is_mpi
628   }
629  
801 –
802 –
630   #ifdef IS_MPI
631  
632   // a couple of functions to let us escape the write loop

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines