ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/group/trunk/OOPSE/libmdtools/Integrator.cpp
(Generate patch)

Comparing trunk/OOPSE/libmdtools/Integrator.cpp (file contents):
Revision 711 by mmeineke, Fri Aug 22 20:04:39 2003 UTC vs.
Revision 1187 by chrisfen, Sat May 22 18:16:18 2004 UTC

# Line 1 | Line 1
1   #include <iostream>
2 < #include <cstdlib>
3 < #include <cmath>
2 > #include <stdlib.h>
3 > #include <math.h>
4  
5   #ifdef IS_MPI
6   #include "mpiSimulation.hpp"
7   #include <unistd.h>
8   #endif //is_mpi
9  
10 + #ifdef PROFILE
11 + #include "mdProfile.hpp"
12 + #endif // profile
13 +
14   #include "Integrator.hpp"
15   #include "simError.h"
16  
17  
18 < template<typename T> Integrator<T>::Integrator( SimInfo *theInfo, ForceFields* the_ff ) {
19 <  
18 > template<typename T> Integrator<T>::Integrator(SimInfo* theInfo,
19 >                                               ForceFields* the_ff){
20    info = theInfo;
21    myFF = the_ff;
22    isFirst = 1;
# Line 21 | Line 25 | template<typename T> Integrator<T>::Integrator( SimInf
25    nMols = info->n_mol;
26  
27    // give a little love back to the SimInfo object
24  
25  if( info->the_integrator != NULL ) delete info->the_integrator;
26  info->the_integrator = this;
28  
29 <  nAtoms = info->n_atoms;
29 >  if (info->the_integrator != NULL){
30 >    delete info->the_integrator;
31 >  }
32  
33 +  nAtoms = info->n_atoms;
34 +  integrableObjects = info->integrableObjects;
35 +
36    // check for constraints
37 <  
38 <  constrainedA    = NULL;
39 <  constrainedB    = NULL;
37 >
38 >  constrainedA = NULL;
39 >  constrainedB = NULL;
40    constrainedDsqr = NULL;
41 <  moving          = NULL;
42 <  moved           = NULL;
43 <  oldPos          = NULL;
44 <  
41 >  moving = NULL;
42 >  moved = NULL;
43 >  oldPos = NULL;
44 >
45    nConstrained = 0;
46  
47    checkConstraints();
48 +
49   }
50  
51 < template<typename T> Integrator<T>::~Integrator() {
52 <  
46 <  if( nConstrained ){
51 > template<typename T> Integrator<T>::~Integrator(){
52 >  if (nConstrained){
53      delete[] constrainedA;
54      delete[] constrainedB;
55      delete[] constrainedDsqr;
# Line 51 | Line 57 | template<typename T> Integrator<T>::~Integrator() {
57      delete[] moved;
58      delete[] oldPos;
59    }
54  
60   }
61  
62 < template<typename T> void Integrator<T>::checkConstraints( void ){
58 <
59 <
62 > template<typename T> void Integrator<T>::checkConstraints(void){
63    isConstrained = 0;
64  
65 <  Constraint *temp_con;
66 <  Constraint *dummy_plug;
65 >  Constraint* temp_con;
66 >  Constraint* dummy_plug;
67    temp_con = new Constraint[info->n_SRI];
68    nConstrained = 0;
69    int constrained = 0;
70 <  
70 >
71    SRI** theArray;
72 <  for(int i = 0; i < nMols; i++){
73 <    
74 <    theArray = (SRI**) molecules[i].getMyBonds();
75 <    for(int j=0; j<molecules[i].getNBonds(); j++){
73 <      
72 >  for (int i = 0; i < nMols; i++){
73 >
74 >          theArray = (SRI * *) molecules[i].getMyBonds();
75 >    for (int j = 0; j < molecules[i].getNBonds(); j++){
76        constrained = theArray[j]->is_constrained();
77  
78 <      if(constrained){
78 >      if (constrained){
79 >        dummy_plug = theArray[j]->get_constraint();
80 >        temp_con[nConstrained].set_a(dummy_plug->get_a());
81 >        temp_con[nConstrained].set_b(dummy_plug->get_b());
82 >        temp_con[nConstrained].set_dsqr(dummy_plug->get_dsqr());
83  
84 <        dummy_plug = theArray[j]->get_constraint();
85 <        temp_con[nConstrained].set_a( dummy_plug->get_a() );
86 <        temp_con[nConstrained].set_b( dummy_plug->get_b() );
81 <        temp_con[nConstrained].set_dsqr( dummy_plug->get_dsqr() );
82 <        
83 <        nConstrained++;
84 <        constrained = 0;
85 <      }
84 >        nConstrained++;
85 >        constrained = 0;
86 >      }
87      }
88  
89 <    theArray = (SRI**) molecules[i].getMyBends();
90 <    for(int j=0; j<molecules[i].getNBends(); j++){
90 <      
89 >    theArray = (SRI * *) molecules[i].getMyBends();
90 >    for (int j = 0; j < molecules[i].getNBends(); j++){
91        constrained = theArray[j]->is_constrained();
92 <      
93 <      if(constrained){
94 <        
95 <        dummy_plug = theArray[j]->get_constraint();
96 <        temp_con[nConstrained].set_a( dummy_plug->get_a() );
97 <        temp_con[nConstrained].set_b( dummy_plug->get_b() );
98 <        temp_con[nConstrained].set_dsqr( dummy_plug->get_dsqr() );
99 <        
100 <        nConstrained++;
101 <        constrained = 0;
92 >
93 >      if (constrained){
94 >        dummy_plug = theArray[j]->get_constraint();
95 >        temp_con[nConstrained].set_a(dummy_plug->get_a());
96 >        temp_con[nConstrained].set_b(dummy_plug->get_b());
97 >        temp_con[nConstrained].set_dsqr(dummy_plug->get_dsqr());
98 >
99 >        nConstrained++;
100 >        constrained = 0;
101        }
102      }
103  
104 <    theArray = (SRI**) molecules[i].getMyTorsions();
105 <    for(int j=0; j<molecules[i].getNTorsions(); j++){
107 <      
104 >    theArray = (SRI * *) molecules[i].getMyTorsions();
105 >    for (int j = 0; j < molecules[i].getNTorsions(); j++){
106        constrained = theArray[j]->is_constrained();
107 <      
108 <      if(constrained){
109 <        
110 <        dummy_plug = theArray[j]->get_constraint();
111 <        temp_con[nConstrained].set_a( dummy_plug->get_a() );
112 <        temp_con[nConstrained].set_b( dummy_plug->get_b() );
113 <        temp_con[nConstrained].set_dsqr( dummy_plug->get_dsqr() );
114 <        
115 <        nConstrained++;
118 <        constrained = 0;
107 >
108 >      if (constrained){
109 >        dummy_plug = theArray[j]->get_constraint();
110 >        temp_con[nConstrained].set_a(dummy_plug->get_a());
111 >        temp_con[nConstrained].set_b(dummy_plug->get_b());
112 >        temp_con[nConstrained].set_dsqr(dummy_plug->get_dsqr());
113 >
114 >        nConstrained++;
115 >        constrained = 0;
116        }
117      }
118    }
119  
120 <  if(nConstrained > 0){
121 <    
120 >
121 >  if (nConstrained > 0){
122      isConstrained = 1;
123  
124 <    if(constrainedA != NULL )    delete[] constrainedA;
125 <    if(constrainedB != NULL )    delete[] constrainedB;
126 <    if(constrainedDsqr != NULL ) delete[] constrainedDsqr;
124 >    if (constrainedA != NULL)
125 >      delete[] constrainedA;
126 >    if (constrainedB != NULL)
127 >      delete[] constrainedB;
128 >    if (constrainedDsqr != NULL)
129 >      delete[] constrainedDsqr;
130  
131 <    constrainedA =    new int[nConstrained];
132 <    constrainedB =    new int[nConstrained];
131 >    constrainedA = new int[nConstrained];
132 >    constrainedB = new int[nConstrained];
133      constrainedDsqr = new double[nConstrained];
134 <    
135 <    for( int i = 0; i < nConstrained; i++){
136 <      
134 >
135 >    for (int i = 0; i < nConstrained; i++){
136        constrainedA[i] = temp_con[i].get_a();
137        constrainedB[i] = temp_con[i].get_b();
138        constrainedDsqr[i] = temp_con[i].get_dsqr();
140
139      }
140  
141 <    
142 <    // save oldAtoms to check for lode balanceing later on.
143 <    
141 >
142 >    // save oldAtoms to check for lode balancing later on.
143 >
144      oldAtoms = nAtoms;
145 <    
145 >
146      moving = new int[nAtoms];
147 <    moved  = new int[nAtoms];
147 >    moved = new int[nAtoms];
148  
149 <    oldPos = new double[nAtoms*3];
149 >    oldPos = new double[nAtoms * 3];
150    }
151 <  
151 >
152    delete[] temp_con;
153   }
154  
155  
156 < template<typename T> void Integrator<T>::integrate( void ){
156 > template<typename T> void Integrator<T>::integrate(void){
157  
158 <  int i, j;                         // loop counters
159 <
160 <  double runTime     = info->run_time;
163 <  double sampleTime  = info->sampleTime;
164 <  double statusTime  = info->statusTime;
158 >  double runTime = info->run_time;
159 >  double sampleTime = info->sampleTime;
160 >  double statusTime = info->statusTime;
161    double thermalTime = info->thermalTime;
162 +  double resetTime = info->resetTime;
163  
164 +  double difference;
165    double currSample;
166    double currThermal;
167    double currStatus;
168 +  double currReset;
169  
170    int calcPot, calcStress;
172  int isError;
171  
172 <  tStats   = new Thermo( info );
173 <  statOut  = new StatWriter( info );
174 <  dumpOut  = new DumpWriter( info );
172 >  tStats = new Thermo(info);
173 >  statOut = new StatWriter(info);
174 >  dumpOut = new DumpWriter(info);
175  
176    atoms = info->atoms;
179  DirectionalAtom* dAtom;
177  
178    dt = info->dt;
179    dt2 = 0.5 * dt;
180  
181 +  readyCheck();
182 +
183 +  // remove center of mass drift velocity (in case we passed in a configuration
184 +  // that was drifting
185 +  tStats->removeCOMdrift();
186 +
187 +  // initialize the retraints if necessary
188 +  if (info->useThermInt) {
189 +    myFF->initRestraints();
190 +  }
191 +
192    // initialize the forces before the first step
193  
194    calcForce(1, 1);
195 <  // myFF->doForces(1,1);
196 <        
197 <  if( info->setTemp ){
198 <    
199 <    thermalize();
195 >  
196 >  if (nConstrained){
197 >    preMove();
198 >    constrainA();
199 >    calcForce(1, 1);
200 >    constrainB();
201    }
202    
203 +  if (info->setTemp){
204 +    thermalize();
205 +  }
206 +
207    calcPot     = 0;
208    calcStress  = 0;
209    currSample  = sampleTime + info->getTime();
210    currThermal = thermalTime+ info->getTime();
211    currStatus  = statusTime + info->getTime();
212 +  currReset   = resetTime  + info->getTime();
213  
214 <  dumpOut->writeDump( info->getTime() );
215 <  statOut->writeStat( info->getTime() );
214 >  dumpOut->writeDump(info->getTime());
215 >  statOut->writeStat(info->getTime());
216  
203  readyCheck();
217  
218   #ifdef IS_MPI
219 <  strcpy( checkPointMsg,
207 <          "The integrator is ready to go." );
219 >  strcpy(checkPointMsg, "The integrator is ready to go.");
220    MPIcheckPoint();
221   #endif // is_mpi
222  
223 <  while( info->getTime() < runTime ){
224 <
225 <    if( (info->getTime()+dt) >= currStatus ){
223 >  while (info->getTime() < runTime && !stopIntegrator()){
224 >    difference = info->getTime() + dt - currStatus;
225 >    if (difference > 0 || fabs(difference) < 1e-4 ){
226        calcPot = 1;
227        calcStress = 1;
228      }
229  
230 <    integrateStep( calcPot, calcStress );
231 <      
230 > #ifdef PROFILE
231 >    startProfile( pro1 );
232 > #endif
233 >    
234 >    integrateStep(calcPot, calcStress);
235 >
236 > #ifdef PROFILE
237 >    endProfile( pro1 );
238 >
239 >    startProfile( pro2 );
240 > #endif // profile
241 >
242      info->incrTime(dt);
243  
244 <    if( info->setTemp ){
245 <      if( info->getTime() >= currThermal ){
246 <        thermalize();
247 <        currThermal += thermalTime;
244 >    if (info->setTemp){
245 >      if (info->getTime() >= currThermal){
246 >        thermalize();
247 >        currThermal += thermalTime;
248        }
249      }
250  
251 <    if( info->getTime() >= currSample ){
252 <      dumpOut->writeDump( info->getTime() );
251 >    if (info->getTime() >= currSample){
252 >      dumpOut->writeDump(info->getTime());
253        currSample += sampleTime;
254      }
255  
256 <    if( info->getTime() >= currStatus ){
257 <      statOut->writeStat( info->getTime() );
258 <      calcPot = 0;
256 >    if (info->getTime() >= currStatus){
257 >      statOut->writeStat(info->getTime());
258 >      statOut->writeRaw(info->getTime());
259 >      calcPot = 0;
260        calcStress = 0;
261        currStatus += statusTime;
262 <    }
262 >    }
263  
264 +    if (info->resetIntegrator){
265 +      if (info->getTime() >= currReset){
266 +        this->resetIntegrator();
267 +        currReset += resetTime;
268 +      }
269 +    }
270 +    
271 + #ifdef PROFILE
272 +    endProfile( pro2 );
273 + #endif //profile
274 +
275   #ifdef IS_MPI
276 <    strcpy( checkPointMsg,
243 <            "successfully took a time step." );
276 >    strcpy(checkPointMsg, "successfully took a time step.");
277      MPIcheckPoint();
278   #endif // is_mpi
246
279    }
280  
281 <  dumpOut->writeFinal(info->getTime());
281 >  // dump out a file containing the omega values for the final configuration
282 >  if (info->useThermInt)
283 >    myFF->dumpzAngle();
284 >  
285  
286    delete dumpOut;
287    delete statOut;
288   }
289  
290 < template<typename T> void Integrator<T>::integrateStep( int calcPot, int calcStress ){
291 <
257 <
258 <      
290 > template<typename T> void Integrator<T>::integrateStep(int calcPot,
291 >                                                       int calcStress){
292    // Position full step, and velocity half step
293  
294 + #ifdef PROFILE
295 +  startProfile(pro3);
296 + #endif //profile
297 +
298    preMove();
299 +
300 + #ifdef PROFILE
301 +  endProfile(pro3);
302 +
303 +  startProfile(pro4);
304 + #endif // profile
305 +
306    moveA();
263  if( nConstrained ) constrainA();
307  
308 + #ifdef PROFILE
309 +  endProfile(pro4);
310    
311 +  startProfile(pro5);
312 + #endif//profile
313 +
314 +
315   #ifdef IS_MPI
316 <  strcpy( checkPointMsg, "Succesful moveA\n" );
316 >  strcpy(checkPointMsg, "Succesful moveA\n");
317    MPIcheckPoint();
318   #endif // is_mpi
270  
319  
320    // calc forces
321 +  calcForce(calcPot, calcStress);
322  
274  calcForce(calcPot,calcStress);
275
323   #ifdef IS_MPI
324 <  strcpy( checkPointMsg, "Succesful doForces\n" );
324 >  strcpy(checkPointMsg, "Succesful doForces\n");
325    MPIcheckPoint();
326   #endif // is_mpi
280  
327  
328 + #ifdef PROFILE
329 +  endProfile( pro5 );
330 +
331 +  startProfile( pro6 );
332 + #endif //profile
333 +
334    // finish the velocity  half step
335 <  
335 >
336    moveB();
337 <  if( nConstrained ) constrainB();
338 <  
337 >
338 > #ifdef PROFILE
339 >  endProfile(pro6);
340 > #endif // profile
341 >
342   #ifdef IS_MPI
343 <  strcpy( checkPointMsg, "Succesful moveB\n" );
343 >  strcpy(checkPointMsg, "Succesful moveB\n");
344    MPIcheckPoint();
345   #endif // is_mpi
291  
292
346   }
347  
348  
349 < template<typename T> void Integrator<T>::moveA( void ){
350 <  
298 <  int i, j;
349 > template<typename T> void Integrator<T>::moveA(void){
350 >  size_t i, j;
351    DirectionalAtom* dAtom;
352    double Tb[3], ji[3];
301  double A[3][3], I[3][3];
302  double angle;
353    double vel[3], pos[3], frc[3];
354    double mass;
355 +  double omega;
356 +
357 +  for (i = 0; i < integrableObjects.size() ; i++){
358 +    integrableObjects[i]->getVel(vel);
359 +    integrableObjects[i]->getPos(pos);
360 +    integrableObjects[i]->getFrc(frc);
361 +    
362 +    mass = integrableObjects[i]->getMass();
363  
364 <  for( i=0; i<nAtoms; i++ ){
307 <
308 <    atoms[i]->getVel( vel );
309 <    atoms[i]->getPos( pos );
310 <    atoms[i]->getFrc( frc );
311 <
312 <    mass = atoms[i]->getMass();
313 <
314 <    for (j=0; j < 3; j++) {
364 >    for (j = 0; j < 3; j++){
365        // velocity half step
366 <      vel[j] += ( dt2 * frc[j] / mass ) * eConvert;
366 >      vel[j] += (dt2 * frc[j] / mass) * eConvert;
367        // position whole step
368        pos[j] += dt * vel[j];
369      }
370  
371 <    atoms[i]->setVel( vel );
372 <    atoms[i]->setPos( pos );
371 >    integrableObjects[i]->setVel(vel);
372 >    integrableObjects[i]->setPos(pos);
373  
374 <    if( atoms[i]->isDirectional() ){
374 >    if (integrableObjects[i]->isDirectional()){
375  
326      dAtom = (DirectionalAtom *)atoms[i];
327          
376        // get and convert the torque to body frame
329      
330      dAtom->getTrq( Tb );
331      dAtom->lab2Body( Tb );
377  
378 +      integrableObjects[i]->getTrq(Tb);
379 +      integrableObjects[i]->lab2Body(Tb);
380 +
381        // get the angular momentum, and propagate a half step
382  
383 <      dAtom->getJ( ji );
383 >      integrableObjects[i]->getJ(ji);
384  
385 <      for (j=0; j < 3; j++)
385 >      for (j = 0; j < 3; j++)
386          ji[j] += (dt2 * Tb[j]) * eConvert;
339      
340      // use the angular velocities to propagate the rotation matrix a
341      // full time step
387  
388 <      dAtom->getA(A);
344 <      dAtom->getI(I);
345 <    
346 <      // rotate about the x-axis      
347 <      angle = dt2 * ji[0] / I[0][0];
348 <      this->rotate( 1, 2, angle, ji, A );
388 >      this->rotationPropagation( integrableObjects[i], ji );
389  
390 <      // rotate about the y-axis
391 <      angle = dt2 * ji[1] / I[1][1];
392 <      this->rotate( 2, 0, angle, ji, A );
353 <      
354 <      // rotate about the z-axis
355 <      angle = dt * ji[2] / I[2][2];
356 <      this->rotate( 0, 1, angle, ji, A);
357 <      
358 <      // rotate about the y-axis
359 <      angle = dt2 * ji[1] / I[1][1];
360 <      this->rotate( 2, 0, angle, ji, A );
361 <      
362 <       // rotate about the x-axis
363 <      angle = dt2 * ji[0] / I[0][0];
364 <      this->rotate( 1, 2, angle, ji, A );
365 <      
390 >      integrableObjects[i]->setJ(ji);
391 >    }
392 >  }
393  
394 <      dAtom->setJ( ji );
395 <      dAtom->setA( A  );
369 <          
370 <    }    
394 >  if (nConstrained){
395 >    constrainA();
396    }
397   }
398  
399  
400 < template<typename T> void Integrator<T>::moveB( void ){
400 > template<typename T> void Integrator<T>::moveB(void){
401    int i, j;
377  DirectionalAtom* dAtom;
402    double Tb[3], ji[3];
403    double vel[3], frc[3];
404    double mass;
405  
406 <  for( i=0; i<nAtoms; i++ ){
407 <
408 <    atoms[i]->getVel( vel );
385 <    atoms[i]->getFrc( frc );
406 >  for (i = 0; i < integrableObjects.size(); i++){
407 >    integrableObjects[i]->getVel(vel);
408 >    integrableObjects[i]->getFrc(frc);
409  
410 <    mass = atoms[i]->getMass();
410 >    mass = integrableObjects[i]->getMass();
411  
412      // velocity half step
413 <    for (j=0; j < 3; j++)
414 <      vel[j] += ( dt2 * frc[j] / mass ) * eConvert;
392 <    
393 <    atoms[i]->setVel( vel );
394 <
395 <    if( atoms[i]->isDirectional() ){
413 >    for (j = 0; j < 3; j++)
414 >      vel[j] += (dt2 * frc[j] / mass) * eConvert;
415  
416 <      dAtom = (DirectionalAtom *)atoms[i];
416 >    integrableObjects[i]->setVel(vel);
417  
418 <      // get and convert the torque to body frame      
418 >    if (integrableObjects[i]->isDirectional()){
419  
420 <      dAtom->getTrq( Tb );
402 <      dAtom->lab2Body( Tb );
420 >      // get and convert the torque to body frame
421  
422 +      integrableObjects[i]->getTrq(Tb);
423 +      integrableObjects[i]->lab2Body(Tb);
424 +
425        // get the angular momentum, and propagate a half step
426  
427 <      dAtom->getJ( ji );
427 >      integrableObjects[i]->getJ(ji);
428  
429 <      for (j=0; j < 3; j++)
429 >      for (j = 0; j < 3; j++)
430          ji[j] += (dt2 * Tb[j]) * eConvert;
410      
431  
432 <      dAtom->setJ( ji );
432 >
433 >      integrableObjects[i]->setJ(ji);
434      }
435    }
436 +
437 +  if (nConstrained){
438 +    constrainB();
439 +  }
440   }
441  
442 < template<typename T> void Integrator<T>::preMove( void ){
442 > template<typename T> void Integrator<T>::preMove(void){
443    int i, j;
444    double pos[3];
445  
446 <  if( nConstrained ){
446 >  if (nConstrained){
447 >    for (i = 0; i < nAtoms; i++){
448 >      atoms[i]->getPos(pos);
449  
450 <    for(i=0; i < nAtoms; i++) {
451 <
425 <      atoms[i]->getPos( pos );
426 <
427 <      for (j = 0; j < 3; j++) {        
428 <        oldPos[3*i + j] = pos[j];
450 >      for (j = 0; j < 3; j++){
451 >        oldPos[3 * i + j] = pos[j];
452        }
430
453      }
454 <  }  
454 >  }
455   }
456  
457   template<typename T> void Integrator<T>::constrainA(){
458 <
437 <  int i,j,k;
458 >  int i, j;
459    int done;
460    double posA[3], posB[3];
461    double velA[3], velB[3];
# Line 449 | Line 470 | template<typename T> void Integrator<T>::constrainA(){
470    double gab;
471    int iteration;
472  
473 <  for( i=0; i<nAtoms; i++){    
473 >  for (i = 0; i < nAtoms; i++){
474      moving[i] = 0;
475 <    moved[i]  = 1;
475 >    moved[i] = 1;
476    }
477  
478    iteration = 0;
479    done = 0;
480 <  while( !done && (iteration < maxIteration )){
460 <
480 >  while (!done && (iteration < maxIteration)){
481      done = 1;
482 <    for(i=0; i<nConstrained; i++){
463 <
482 >    for (i = 0; i < nConstrained; i++){
483        a = constrainedA[i];
484        b = constrainedB[i];
466      
467      ax = (a*3) + 0;
468      ay = (a*3) + 1;
469      az = (a*3) + 2;
485  
486 <      bx = (b*3) + 0;
487 <      by = (b*3) + 1;
488 <      bz = (b*3) + 2;
486 >      ax = (a * 3) + 0;
487 >      ay = (a * 3) + 1;
488 >      az = (a * 3) + 2;
489  
490 <      if( moved[a] || moved[b] ){
491 <        
492 <        atoms[a]->getPos( posA );
493 <        atoms[b]->getPos( posB );
494 <        
495 <        for (j = 0; j < 3; j++ )
490 >      bx = (b * 3) + 0;
491 >      by = (b * 3) + 1;
492 >      bz = (b * 3) + 2;
493 >
494 >      if (moved[a] || moved[b]){
495 >        atoms[a]->getPos(posA);
496 >        atoms[b]->getPos(posB);
497 >
498 >        for (j = 0; j < 3; j++)
499            pab[j] = posA[j] - posB[j];
482        
483        //periodic boundary condition
500  
501 <        info->wrapVector( pab );
501 >        //periodic boundary condition
502  
503 <        pabsq = pab[0] * pab[0] + pab[1] * pab[1] + pab[2] * pab[2];
503 >        info->wrapVector(pab);
504  
505 <        rabsq = constrainedDsqr[i];
490 <        diffsq = rabsq - pabsq;
505 >        pabsq = pab[0] * pab[0] + pab[1] * pab[1] + pab[2] * pab[2];
506  
507 <        // the original rattle code from alan tidesley
508 <        if (fabs(diffsq) > (tol*rabsq*2)) {
494 <          rab[0] = oldPos[ax] - oldPos[bx];
495 <          rab[1] = oldPos[ay] - oldPos[by];
496 <          rab[2] = oldPos[az] - oldPos[bz];
507 >        rabsq = constrainedDsqr[i];
508 >        diffsq = rabsq - pabsq;
509  
510 <          info->wrapVector( rab );
510 >        // the original rattle code from alan tidesley
511 >        if (fabs(diffsq) > (tol * rabsq * 2)){
512 >          rab[0] = oldPos[ax] - oldPos[bx];
513 >          rab[1] = oldPos[ay] - oldPos[by];
514 >          rab[2] = oldPos[az] - oldPos[bz];
515  
516 <          rpab = rab[0] * pab[0] + rab[1] * pab[1] + rab[2] * pab[2];
516 >          info->wrapVector(rab);
517  
518 <          rpabsq = rpab * rpab;
518 >          rpab = rab[0] * pab[0] + rab[1] * pab[1] + rab[2] * pab[2];
519  
520 +          rpabsq = rpab * rpab;
521  
505          if (rpabsq < (rabsq * -diffsq)){
522  
523 +          if (rpabsq < (rabsq * -diffsq)){
524   #ifdef IS_MPI
525 <            a = atoms[a]->getGlobalIndex();
526 <            b = atoms[b]->getGlobalIndex();
525 >            a = atoms[a]->getGlobalIndex();
526 >            b = atoms[b]->getGlobalIndex();
527   #endif //is_mpi
528 <            sprintf( painCave.errMsg,
529 <                     "Constraint failure in constrainA at atom %d and %d.\n",
530 <                     a, b );
531 <            painCave.isFatal = 1;
532 <            simError();
533 <          }
528 >            sprintf(painCave.errMsg,
529 >                    "Constraint failure in constrainA at atom %d and %d.\n", a,
530 >                    b);
531 >            painCave.isFatal = 1;
532 >            simError();
533 >          }
534  
535 <          rma = 1.0 / atoms[a]->getMass();
536 <          rmb = 1.0 / atoms[b]->getMass();
535 >          rma = 1.0 / atoms[a]->getMass();
536 >          rmb = 1.0 / atoms[b]->getMass();
537  
538 <          gab = diffsq / ( 2.0 * ( rma + rmb ) * rpab );
538 >          gab = diffsq / (2.0 * (rma + rmb) * rpab);
539  
540            dx = rab[0] * gab;
541            dy = rab[1] * gab;
542            dz = rab[2] * gab;
543  
544 <          posA[0] += rma * dx;
545 <          posA[1] += rma * dy;
546 <          posA[2] += rma * dz;
544 >          posA[0] += rma * dx;
545 >          posA[1] += rma * dy;
546 >          posA[2] += rma * dz;
547  
548 <          atoms[a]->setPos( posA );
548 >          atoms[a]->setPos(posA);
549  
550 <          posB[0] -= rmb * dx;
551 <          posB[1] -= rmb * dy;
552 <          posB[2] -= rmb * dz;
550 >          posB[0] -= rmb * dx;
551 >          posB[1] -= rmb * dy;
552 >          posB[2] -= rmb * dz;
553  
554 <          atoms[b]->setPos( posB );
554 >          atoms[b]->setPos(posB);
555  
556            dx = dx / dt;
557            dy = dy / dt;
558            dz = dz / dt;
559  
560 <          atoms[a]->getVel( velA );
560 >          atoms[a]->getVel(velA);
561  
562 <          velA[0] += rma * dx;
563 <          velA[1] += rma * dy;
564 <          velA[2] += rma * dz;
562 >          velA[0] += rma * dx;
563 >          velA[1] += rma * dy;
564 >          velA[2] += rma * dz;
565  
566 <          atoms[a]->setVel( velA );
566 >          atoms[a]->setVel(velA);
567  
568 <          atoms[b]->getVel( velB );
568 >          atoms[b]->getVel(velB);
569  
570 <          velB[0] -= rmb * dx;
571 <          velB[1] -= rmb * dy;
572 <          velB[2] -= rmb * dz;
570 >          velB[0] -= rmb * dx;
571 >          velB[1] -= rmb * dy;
572 >          velB[2] -= rmb * dz;
573  
574 <          atoms[b]->setVel( velB );
574 >          atoms[b]->setVel(velB);
575  
576 <          moving[a] = 1;
577 <          moving[b] = 1;
578 <          done = 0;
579 <        }
576 >          moving[a] = 1;
577 >          moving[b] = 1;
578 >          done = 0;
579 >        }
580        }
581      }
582 <    
583 <    for(i=0; i<nAtoms; i++){
567 <      
582 >
583 >    for (i = 0; i < nAtoms; i++){
584        moved[i] = moving[i];
585        moving[i] = 0;
586      }
# Line 572 | Line 588 | template<typename T> void Integrator<T>::constrainA(){
588      iteration++;
589    }
590  
591 <  if( !done ){
592 <
593 <    sprintf( painCave.errMsg,
594 <             "Constraint failure in constrainA, too many iterations: %d\n",
579 <             iteration );
591 >  if (!done){
592 >    sprintf(painCave.errMsg,
593 >            "Constraint failure in constrainA, too many iterations: %d\n",
594 >            iteration);
595      painCave.isFatal = 1;
596      simError();
597    }
598  
599   }
600  
601 < template<typename T> void Integrator<T>::constrainB( void ){
602 <  
588 <  int i,j,k;
601 > template<typename T> void Integrator<T>::constrainB(void){
602 >  int i, j;
603    int done;
604    double posA[3], posB[3];
605    double velA[3], velB[3];
# Line 594 | Line 608 | template<typename T> void Integrator<T>::constrainB( v
608    int a, b, ax, ay, az, bx, by, bz;
609    double rma, rmb;
610    double dx, dy, dz;
611 <  double rabsq, pabsq, rvab;
598 <  double diffsq;
611 >  double rvab;
612    double gab;
613    int iteration;
614  
615 <  for(i=0; i<nAtoms; i++){
615 >  for (i = 0; i < nAtoms; i++){
616      moving[i] = 0;
617      moved[i] = 1;
618    }
619  
620    done = 0;
621    iteration = 0;
622 <  while( !done && (iteration < maxIteration ) ){
610 <
622 >  while (!done && (iteration < maxIteration)){
623      done = 1;
624  
625 <    for(i=0; i<nConstrained; i++){
614 <      
625 >    for (i = 0; i < nConstrained; i++){
626        a = constrainedA[i];
627        b = constrainedB[i];
628  
629 <      ax = (a*3) + 0;
630 <      ay = (a*3) + 1;
631 <      az = (a*3) + 2;
629 >      ax = (a * 3) + 0;
630 >      ay = (a * 3) + 1;
631 >      az = (a * 3) + 2;
632  
633 <      bx = (b*3) + 0;
634 <      by = (b*3) + 1;
635 <      bz = (b*3) + 2;
633 >      bx = (b * 3) + 0;
634 >      by = (b * 3) + 1;
635 >      bz = (b * 3) + 2;
636  
637 <      if( moved[a] || moved[b] ){
637 >      if (moved[a] || moved[b]){
638 >        atoms[a]->getVel(velA);
639 >        atoms[b]->getVel(velB);
640  
641 <        atoms[a]->getVel( velA );
642 <        atoms[b]->getVel( velB );
643 <          
631 <        vxab = velA[0] - velB[0];
632 <        vyab = velA[1] - velB[1];
633 <        vzab = velA[2] - velB[2];
641 >        vxab = velA[0] - velB[0];
642 >        vyab = velA[1] - velB[1];
643 >        vzab = velA[2] - velB[2];
644  
645 <        atoms[a]->getPos( posA );
646 <        atoms[b]->getPos( posB );
645 >        atoms[a]->getPos(posA);
646 >        atoms[b]->getPos(posB);
647  
648 <        for (j = 0; j < 3; j++)
648 >        for (j = 0; j < 3; j++)
649            rab[j] = posA[j] - posB[j];
640          
641        info->wrapVector( rab );
642        
643        rma = 1.0 / atoms[a]->getMass();
644        rmb = 1.0 / atoms[b]->getMass();
650  
651 <        rvab = rab[0] * vxab + rab[1] * vyab + rab[2] * vzab;
647 <          
648 <        gab = -rvab / ( ( rma + rmb ) * constrainedDsqr[i] );
651 >        info->wrapVector(rab);
652  
653 <        if (fabs(gab) > tol) {
654 <          
652 <          dx = rab[0] * gab;
653 <          dy = rab[1] * gab;
654 <          dz = rab[2] * gab;
655 <        
656 <          velA[0] += rma * dx;
657 <          velA[1] += rma * dy;
658 <          velA[2] += rma * dz;
653 >        rma = 1.0 / atoms[a]->getMass();
654 >        rmb = 1.0 / atoms[b]->getMass();
655  
656 <          atoms[a]->setVel( velA );
656 >        rvab = rab[0] * vxab + rab[1] * vyab + rab[2] * vzab;
657  
658 <          velB[0] -= rmb * dx;
663 <          velB[1] -= rmb * dy;
664 <          velB[2] -= rmb * dz;
658 >        gab = -rvab / ((rma + rmb) * constrainedDsqr[i]);
659  
660 <          atoms[b]->setVel( velB );
661 <          
662 <          moving[a] = 1;
663 <          moving[b] = 1;
664 <          done = 0;
665 <        }
660 >        if (fabs(gab) > tol){
661 >          dx = rab[0] * gab;
662 >          dy = rab[1] * gab;
663 >          dz = rab[2] * gab;
664 >
665 >          velA[0] += rma * dx;
666 >          velA[1] += rma * dy;
667 >          velA[2] += rma * dz;
668 >
669 >          atoms[a]->setVel(velA);
670 >
671 >          velB[0] -= rmb * dx;
672 >          velB[1] -= rmb * dy;
673 >          velB[2] -= rmb * dz;
674 >
675 >          atoms[b]->setVel(velB);
676 >
677 >          moving[a] = 1;
678 >          moving[b] = 1;
679 >          done = 0;
680 >        }
681        }
682      }
683  
684 <    for(i=0; i<nAtoms; i++){
684 >    for (i = 0; i < nAtoms; i++){
685        moved[i] = moving[i];
686        moving[i] = 0;
687      }
688 <    
688 >
689      iteration++;
690    }
682  
683  if( !done ){
691  
692 <  
693 <    sprintf( painCave.errMsg,
694 <             "Constraint failure in constrainB, too many iterations: %d\n",
695 <             iteration );
692 >  if (!done){
693 >    sprintf(painCave.errMsg,
694 >            "Constraint failure in constrainB, too many iterations: %d\n",
695 >            iteration);
696      painCave.isFatal = 1;
697      simError();
698 <  }
692 <
698 >  }
699   }
700  
701 < template<typename T> void Integrator<T>::rotate( int axes1, int axes2, double angle, double ji[3],
702 <                         double A[3][3] ){
701 > template<typename T> void Integrator<T>::rotationPropagation
702 > ( StuntDouble* sd, double ji[3] ){
703  
704 <  int i,j,k;
704 >  double angle;
705 >  double A[3][3], I[3][3];
706 >  int i, j, k;
707 >
708 >  // use the angular velocities to propagate the rotation matrix a
709 >  // full time step
710 >
711 >  sd->getA(A);
712 >  sd->getI(I);
713 >
714 >  if (sd->isLinear()) {
715 >    i = sd->linearAxis();
716 >    j = (i+1)%3;
717 >    k = (i+2)%3;
718 >    
719 >    angle = dt2 * ji[j] / I[j][j];
720 >    this->rotate( k, i, angle, ji, A );
721 >
722 >    angle = dt * ji[k] / I[k][k];
723 >    this->rotate( i, j, angle, ji, A);
724 >
725 >    angle = dt2 * ji[j] / I[j][j];
726 >    this->rotate( k, i, angle, ji, A );
727 >
728 >  } else {
729 >    // rotate about the x-axis
730 >    angle = dt2 * ji[0] / I[0][0];
731 >    this->rotate( 1, 2, angle, ji, A );
732 >    
733 >    // rotate about the y-axis
734 >    angle = dt2 * ji[1] / I[1][1];
735 >    this->rotate( 2, 0, angle, ji, A );
736 >    
737 >    // rotate about the z-axis
738 >    angle = dt * ji[2] / I[2][2];
739 >    sd->addZangle(angle);
740 >    this->rotate( 0, 1, angle, ji, A);
741 >    
742 >    // rotate about the y-axis
743 >    angle = dt2 * ji[1] / I[1][1];
744 >    this->rotate( 2, 0, angle, ji, A );
745 >    
746 >    // rotate about the x-axis
747 >    angle = dt2 * ji[0] / I[0][0];
748 >    this->rotate( 1, 2, angle, ji, A );
749 >    
750 >  }
751 >  sd->setA( A  );
752 > }
753 >
754 > template<typename T> void Integrator<T>::rotate(int axes1, int axes2,
755 >                                                double angle, double ji[3],
756 >                                                double A[3][3]){
757 >  int i, j, k;
758    double sinAngle;
759    double cosAngle;
760    double angleSqr;
# Line 707 | Line 766 | template<typename T> void Integrator<T>::rotate( int a
766  
767    // initialize the tempA
768  
769 <  for(i=0; i<3; i++){
770 <    for(j=0; j<3; j++){
769 >  for (i = 0; i < 3; i++){
770 >    for (j = 0; j < 3; j++){
771        tempA[j][i] = A[i][j];
772      }
773    }
774  
775    // initialize the tempJ
776  
777 <  for( i=0; i<3; i++) tempJ[i] = ji[i];
778 <  
777 >  for (i = 0; i < 3; i++)
778 >    tempJ[i] = ji[i];
779 >
780    // initalize rot as a unit matrix
781  
782    rot[0][0] = 1.0;
# Line 726 | Line 786 | template<typename T> void Integrator<T>::rotate( int a
786    rot[1][0] = 0.0;
787    rot[1][1] = 1.0;
788    rot[1][2] = 0.0;
789 <  
789 >
790    rot[2][0] = 0.0;
791    rot[2][1] = 0.0;
792    rot[2][2] = 1.0;
793 <  
793 >
794    // use a small angle aproximation for sin and cosine
795  
796 <  angleSqr  = angle * angle;
796 >  angleSqr = angle * angle;
797    angleSqrOver4 = angleSqr / 4.0;
798    top = 1.0 - angleSqrOver4;
799    bottom = 1.0 + angleSqrOver4;
# Line 746 | Line 806 | template<typename T> void Integrator<T>::rotate( int a
806  
807    rot[axes1][axes2] = sinAngle;
808    rot[axes2][axes1] = -sinAngle;
809 <  
809 >
810    // rotate the momentum acoording to: ji[] = rot[][] * ji[]
811 <  
812 <  for(i=0; i<3; i++){
811 >
812 >  for (i = 0; i < 3; i++){
813      ji[i] = 0.0;
814 <    for(k=0; k<3; k++){
814 >    for (k = 0; k < 3; k++){
815        ji[i] += rot[i][k] * tempJ[k];
816      }
817    }
818  
819 <  // rotate the Rotation matrix acording to:
819 >  // rotate the Rotation matrix acording to:
820    //            A[][] = A[][] * transpose(rot[][])
821  
822  
# Line 764 | Line 824 | template<typename T> void Integrator<T>::rotate( int a
824    // calculation as:
825    //                transpose(A[][]) = transpose(A[][]) * transpose(rot[][])
826  
827 <  for(i=0; i<3; i++){
828 <    for(j=0; j<3; j++){
827 >  for (i = 0; i < 3; i++){
828 >    for (j = 0; j < 3; j++){
829        A[j][i] = 0.0;
830 <      for(k=0; k<3; k++){
831 <        A[j][i] += tempA[i][k] * rot[j][k];
830 >      for (k = 0; k < 3; k++){
831 >        A[j][i] += tempA[i][k] * rot[j][k];
832        }
833      }
834    }
835   }
836  
837 < template<typename T> void Integrator<T>::calcForce( int calcPot, int calcStress ){
838 <   myFF->doForces(calcPot,calcStress);
779 <  
837 > template<typename T> void Integrator<T>::calcForce(int calcPot, int calcStress){
838 >  myFF->doForces(calcPot, calcStress);
839   }
840  
841   template<typename T> void Integrator<T>::thermalize(){
842 <  tStats->velocitize();  
842 >  tStats->velocitize();
843   }
844 +
845 + template<typename T> double Integrator<T>::getConservedQuantity(void){
846 +  return tStats->getTotalE();
847 + }
848 + template<typename T> string Integrator<T>::getAdditionalParameters(void){
849 +  //By default, return a null string
850 +  //The reason we use string instead of char* is that if we use char*, we will
851 +  //return a pointer point to local variable which might cause problem
852 +  return string();
853 + }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines