ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/group/trunk/OOPSE/libmdtools/SimSetup.cpp
(Generate patch)

Comparing trunk/OOPSE/libmdtools/SimSetup.cpp (file contents):
Revision 707 by mmeineke, Wed Aug 20 19:42:31 2003 UTC vs.
Revision 845 by gezelter, Thu Oct 30 18:59:20 2003 UTC

# Line 1 | Line 1
1   #include <algorithm>
2 < #include <cstdlib>
2 > #include <stdlib.h>
3   #include <iostream>
4 < #include <cmath>
4 > #include <math.h>
5   #include <string>
6 <
6 > #include <sprng.h>
7   #include "SimSetup.hpp"
8   #include "ReadWrite.hpp"
9   #include "parse_me.h"
# Line 21 | Line 21
21   #define NVT_ENS        1
22   #define NPTi_ENS       2
23   #define NPTf_ENS       3
24 < #define NPTim_ENS      4
25 < #define NPTfm_ENS      5
24 > #define NPTxyz_ENS     4
25  
26 +
27   #define FF_DUFF 0
28   #define FF_LJ   1
29   #define FF_EAM  2
# Line 32 | Line 32 | SimSetup::SimSetup(){
32  
33   SimSetup::SimSetup(){
34    
35 +  initSuspend = false;
36    isInfoArray = 0;
37    nInfo = 1;
38 <  
38 >
39    stamps = new MakeStamps();
40    globals = new Globals();
41 <  
42 <  
41 >
42 >
43   #ifdef IS_MPI
44 <  strcpy( checkPointMsg, "SimSetup creation successful" );
44 >  strcpy(checkPointMsg, "SimSetup creation successful");
45    MPIcheckPoint();
46   #endif // IS_MPI
47   }
# Line 50 | Line 51 | void SimSetup::setSimInfo( SimInfo* the_info, int theN
51    delete globals;
52   }
53  
54 < void SimSetup::setSimInfo( SimInfo* the_info, int theNinfo ) {
55 <    info = the_info;
56 <    nInfo = theNinfo;
57 <    isInfoArray = 1;
54 > void SimSetup::setSimInfo(SimInfo* the_info, int theNinfo){
55 >  info = the_info;
56 >  nInfo = theNinfo;
57 >  isInfoArray = 1;
58 >  initSuspend = true;
59   }
60  
61  
62 < void SimSetup::parseFile( char* fileName ){
61 <
62 > void SimSetup::parseFile(char* fileName){
63   #ifdef IS_MPI
64 <  if( worldRank == 0 ){
64 >  if (worldRank == 0){
65   #endif // is_mpi
66 <    
66 >
67      inFileName = fileName;
68 <    set_interface_stamps( stamps, globals );
69 <    
68 >    set_interface_stamps(stamps, globals);
69 >
70   #ifdef IS_MPI
71      mpiEventInit();
72   #endif
73  
74 <    yacc_BASS( fileName );
74 >    yacc_BASS(fileName);
75  
76   #ifdef IS_MPI
77      throwMPIEvent(NULL);
78    }
79 <  else receiveParse();
79 >  else{
80 >    receiveParse();
81 >  }
82   #endif
83  
84   }
85  
86   #ifdef IS_MPI
87   void SimSetup::receiveParse(void){
88 <
89 <    set_interface_stamps( stamps, globals );
90 <    mpiEventInit();
91 <    MPIcheckPoint();
89 <    mpiEventLoop();
90 <
88 >  set_interface_stamps(stamps, globals);
89 >  mpiEventInit();
90 >  MPIcheckPoint();
91 >  mpiEventLoop();
92   }
93  
94   #endif // is_mpi
95  
96   void SimSetup::createSim(void){
97  
97  int i, j, k, globalAtomIndex;
98  
98    // gather all of the information from the Bass file
99  
100    gatherInfo();
# Line 104 | Line 103 | void SimSetup::createSim(void){
103  
104    sysObjectsCreation();
105  
106 <  // check on the post processing info
106 >  // initialize the system coordinates
107  
108 <  finalInfoCheck();
108 >  if ( !initSuspend ){
109 >    initSystemCoords();
110  
111 <  // initialize the system coordinates
111 >    if( !(globals->getUseInitTime()) )
112 >      info[0].currentTime = 0.0;
113 >  }  
114  
115 <  if( !isInfoArray ) initSystemCoords();  
115 >  // check on the post processing info
116  
117 +  finalInfoCheck();
118 +
119    // make the output filenames
120  
121    makeOutNames();
122 <  
122 >
123    // make the integrator
124 <  
124 >
125    makeIntegrator();
126 <  
126 >
127   #ifdef IS_MPI
128    mpiSim->mpiRefresh();
129   #endif
# Line 127 | Line 131 | void SimSetup::createSim(void){
131    // initialize the Fortran
132  
133    initFortran();
130
131
132
134   }
135  
136  
137 < void SimSetup::makeMolecules( void ){
138 <
138 <  int k,l;
137 > void SimSetup::makeMolecules(void){
138 >  int k;
139    int i, j, exI, exJ, tempEx, stampID, atomOffset, excludeOffset;
140    molInit molInfo;
141    DirectionalAtom* dAtom;
# Line 150 | Line 150 | void SimSetup::makeMolecules( void ){
150    bend_set* theBends;
151    torsion_set* theTorsions;
152  
153 <  
153 >
154    //init the forceField paramters
155  
156    the_ff->readParams();
157  
158 <  
158 >
159    // init the atoms
160  
161    double ux, uy, uz, u, uSqr;
162  
163  for(k=0; k<nInfo; k++){
164    
165    the_ff->setSimInfo( &(info[k]) );
162  
163 +  for (k = 0; k < nInfo; k++){
164 +    the_ff->setSimInfo(&(info[k]));
165 +
166      atomOffset = 0;
167      excludeOffset = 0;
168 <    for(i=0; i<info[k].n_mol; i++){
170 <    
168 >    for (i = 0; i < info[k].n_mol; i++){
169        stampID = info[k].molecules[i].getStampID();
170  
171 <      molInfo.nAtoms    = comp_stamps[stampID]->getNAtoms();
172 <      molInfo.nBonds    = comp_stamps[stampID]->getNBonds();
173 <      molInfo.nBends    = comp_stamps[stampID]->getNBends();
171 >      molInfo.nAtoms = comp_stamps[stampID]->getNAtoms();
172 >      molInfo.nBonds = comp_stamps[stampID]->getNBonds();
173 >      molInfo.nBends = comp_stamps[stampID]->getNBends();
174        molInfo.nTorsions = comp_stamps[stampID]->getNTorsions();
175        molInfo.nExcludes = molInfo.nBonds + molInfo.nBends + molInfo.nTorsions;
176 <      
176 >
177        molInfo.myAtoms = &(info[k].atoms[atomOffset]);
178        molInfo.myExcludes = &(info[k].excludes[excludeOffset]);
179 <      molInfo.myBonds = new Bond*[molInfo.nBonds];
180 <      molInfo.myBends = new Bend*[molInfo.nBends];
181 <      molInfo.myTorsions = new Torsion*[molInfo.nTorsions];
179 >      molInfo.myBonds = new Bond * [molInfo.nBonds];
180 >      molInfo.myBends = new Bend * [molInfo.nBends];
181 >      molInfo.myTorsions = new Torsion * [molInfo.nTorsions];
182  
183        theBonds = new bond_pair[molInfo.nBonds];
184        theBends = new bend_set[molInfo.nBends];
185        theTorsions = new torsion_set[molInfo.nTorsions];
186 <    
187 <      // make the Atoms
188 <    
189 <      for(j=0; j<molInfo.nAtoms; j++){
190 <  
191 <  currentAtom = comp_stamps[stampID]->getAtom( j );
192 <  if( currentAtom->haveOrientation() ){
193 <    
194 <    dAtom = new DirectionalAtom( (j + atomOffset),
195 <               info[k].getConfiguration() );
196 <    info[k].n_oriented++;
197 <    molInfo.myAtoms[j] = dAtom;
198 <    
199 <    ux = currentAtom->getOrntX();
200 <    uy = currentAtom->getOrntY();
201 <    uz = currentAtom->getOrntZ();
202 <    
203 <    uSqr = (ux * ux) + (uy * uy) + (uz * uz);
204 <    
205 <    u = sqrt( uSqr );
206 <    ux = ux / u;
207 <    uy = uy / u;
208 <    uz = uz / u;
209 <    
210 <    dAtom->setSUx( ux );
211 <    dAtom->setSUy( uy );
212 <    dAtom->setSUz( uz );
213 <  }
214 <  else{
215 <    molInfo.myAtoms[j] = new GeneralAtom( (j + atomOffset),
216 <            info[k].getConfiguration() );
217 <  }
220 <  molInfo.myAtoms[j]->setType( currentAtom->getType() );
221 <    
186 >
187 >      // make the Atoms
188 >
189 >      for (j = 0; j < molInfo.nAtoms; j++){
190 >        currentAtom = comp_stamps[stampID]->getAtom(j);
191 >        if (currentAtom->haveOrientation()){
192 >          dAtom = new DirectionalAtom((j + atomOffset),
193 >                                      info[k].getConfiguration());
194 >          info[k].n_oriented++;
195 >          molInfo.myAtoms[j] = dAtom;
196 >
197 >          ux = currentAtom->getOrntX();
198 >          uy = currentAtom->getOrntY();
199 >          uz = currentAtom->getOrntZ();
200 >
201 >          uSqr = (ux * ux) + (uy * uy) + (uz * uz);
202 >
203 >          u = sqrt(uSqr);
204 >          ux = ux / u;
205 >          uy = uy / u;
206 >          uz = uz / u;
207 >
208 >          dAtom->setSUx(ux);
209 >          dAtom->setSUy(uy);
210 >          dAtom->setSUz(uz);
211 >        }
212 >        else{
213 >          molInfo.myAtoms[j] = new GeneralAtom((j + atomOffset),
214 >                                               info[k].getConfiguration());
215 >        }
216 >        molInfo.myAtoms[j]->setType(currentAtom->getType());
217 >
218   #ifdef IS_MPI
219 <      
220 <  molInfo.myAtoms[j]->setGlobalIndex( globalIndex[j+atomOffset] );
221 <      
219 >
220 >        molInfo.myAtoms[j]->setGlobalIndex(globalIndex[j + atomOffset]);
221 >
222   #endif // is_mpi
223        }
224 <    
225 <    // make the bonds
226 <      for(j=0; j<molInfo.nBonds; j++){
227 <      
228 <  currentBond = comp_stamps[stampID]->getBond( j );
229 <  theBonds[j].a = currentBond->getA() + atomOffset;
230 <  theBonds[j].b = currentBond->getB() + atomOffset;
231 <  
232 <  exI = theBonds[j].a;
233 <  exJ = theBonds[j].b;
234 <  
235 <  // exclude_I must always be the smaller of the pair
236 <  if( exI > exJ ){
237 <    tempEx = exI;
238 <    exI = exJ;
239 <    exJ = tempEx;
244 <  }
224 >
225 >      // make the bonds
226 >      for (j = 0; j < molInfo.nBonds; j++){
227 >        currentBond = comp_stamps[stampID]->getBond(j);
228 >        theBonds[j].a = currentBond->getA() + atomOffset;
229 >        theBonds[j].b = currentBond->getB() + atomOffset;
230 >
231 >        exI = theBonds[j].a;
232 >        exJ = theBonds[j].b;
233 >
234 >        // exclude_I must always be the smaller of the pair
235 >        if (exI > exJ){
236 >          tempEx = exI;
237 >          exI = exJ;
238 >          exJ = tempEx;
239 >        }
240   #ifdef IS_MPI
241 <  tempEx = exI;
242 <  exI = info[k].atoms[tempEx]->getGlobalIndex() + 1;
243 <  tempEx = exJ;
244 <  exJ = info[k].atoms[tempEx]->getGlobalIndex() + 1;
245 <  
246 <  info[k].excludes[j+excludeOffset]->setPair( exI, exJ );
241 >        tempEx = exI;
242 >        exI = info[k].atoms[tempEx]->getGlobalIndex() + 1;
243 >        tempEx = exJ;
244 >        exJ = info[k].atoms[tempEx]->getGlobalIndex() + 1;
245 >
246 >        info[k].excludes[j + excludeOffset]->setPair(exI, exJ);
247   #else  // isn't MPI
248 <  
249 <  info[k].excludes[j+excludeOffset]->setPair( (exI+1), (exJ+1) );
248 >
249 >        info[k].excludes[j + excludeOffset]->setPair((exI + 1), (exJ + 1));
250   #endif  //is_mpi
251        }
252        excludeOffset += molInfo.nBonds;
253 <      
253 >
254        //make the bends
255 <      for(j=0; j<molInfo.nBends; j++){
256 <  
257 <  currentBend = comp_stamps[stampID]->getBend( j );
258 <  theBends[j].a = currentBend->getA() + atomOffset;
259 <  theBends[j].b = currentBend->getB() + atomOffset;
260 <  theBends[j].c = currentBend->getC() + atomOffset;
261 <  
262 <  if( currentBend->haveExtras() ){
263 <    
264 <    extras = currentBend->getExtras();
265 <    current_extra = extras;
266 <    
267 <    while( current_extra != NULL ){
268 <      if( !strcmp( current_extra->getlhs(), "ghostVectorSource" )){
269 <        
270 <        switch( current_extra->getType() ){
271 <    
272 <        case 0:
273 <    theBends[j].ghost =
274 <      current_extra->getInt() + atomOffset;
275 <    theBends[j].isGhost = 1;
276 <    break;
277 <    
278 <        case 1:
279 <    theBends[j].ghost =
280 <      (int)current_extra->getDouble() + atomOffset;
281 <    theBends[j].isGhost = 1;
282 <    break;
283 <    
284 <        default:
285 <    sprintf( painCave.errMsg,
286 <       "SimSetup Error: ghostVectorSource was neither a "
287 <       "double nor an int.\n"
288 <       "-->Bend[%d] in %s\n",
289 <       j, comp_stamps[stampID]->getID() );
290 <    painCave.isFatal = 1;
291 <    simError();
255 >      for (j = 0; j < molInfo.nBends; j++){
256 >        currentBend = comp_stamps[stampID]->getBend(j);
257 >        theBends[j].a = currentBend->getA() + atomOffset;
258 >        theBends[j].b = currentBend->getB() + atomOffset;
259 >        theBends[j].c = currentBend->getC() + atomOffset;
260 >
261 >        if (currentBend->haveExtras()){
262 >          extras = currentBend->getExtras();
263 >          current_extra = extras;
264 >
265 >          while (current_extra != NULL){
266 >            if (!strcmp(current_extra->getlhs(), "ghostVectorSource")){
267 >              switch (current_extra->getType()){
268 >                case 0:
269 >                  theBends[j].ghost = current_extra->getInt() + atomOffset;
270 >                  theBends[j].isGhost = 1;
271 >                  break;
272 >
273 >                case 1:
274 >                  theBends[j].ghost = (int) current_extra->getDouble() +
275 >                                      atomOffset;
276 >                  theBends[j].isGhost = 1;
277 >                  break;
278 >
279 >                default:
280 >                  sprintf(painCave.errMsg,
281 >                          "SimSetup Error: ghostVectorSource was neither a "
282 >                          "double nor an int.\n"
283 >                          "-->Bend[%d] in %s\n",
284 >                          j, comp_stamps[stampID]->getID());
285 >                  painCave.isFatal = 1;
286 >                  simError();
287 >              }
288 >            }
289 >            else{
290 >              sprintf(painCave.errMsg,
291 >                      "SimSetup Error: unhandled bend assignment:\n"
292 >                      "    -->%s in Bend[%d] in %s\n",
293 >                      current_extra->getlhs(), j, comp_stamps[stampID]->getID());
294 >              painCave.isFatal = 1;
295 >              simError();
296 >            }
297 >
298 >            current_extra = current_extra->getNext();
299 >          }
300          }
301 <      }
302 <      
303 <      else{
304 <        
305 <        sprintf( painCave.errMsg,
306 <           "SimSetup Error: unhandled bend assignment:\n"
307 <           "    -->%s in Bend[%d] in %s\n",
308 <           current_extra->getlhs(),
309 <           j, comp_stamps[stampID]->getID() );
310 <        painCave.isFatal = 1;
311 <        simError();
312 <      }
313 <      
314 <      current_extra = current_extra->getNext();
315 <    }
316 <  }
314 <  
315 <  if( !theBends[j].isGhost ){
316 <    
317 <    exI = theBends[j].a;
318 <    exJ = theBends[j].c;
319 <  }
320 <  else{
321 <    
322 <    exI = theBends[j].a;
323 <    exJ = theBends[j].b;
324 <  }
325 <  
326 <  // exclude_I must always be the smaller of the pair
327 <  if( exI > exJ ){
328 <    tempEx = exI;
329 <    exI = exJ;
330 <    exJ = tempEx;
331 <  }
301 >
302 >        if (!theBends[j].isGhost){
303 >          exI = theBends[j].a;
304 >          exJ = theBends[j].c;
305 >        }
306 >        else{
307 >          exI = theBends[j].a;
308 >          exJ = theBends[j].b;
309 >        }
310 >
311 >        // exclude_I must always be the smaller of the pair
312 >        if (exI > exJ){
313 >          tempEx = exI;
314 >          exI = exJ;
315 >          exJ = tempEx;
316 >        }
317   #ifdef IS_MPI
318 <  tempEx = exI;
319 <  exI = info[k].atoms[tempEx]->getGlobalIndex() + 1;
320 <  tempEx = exJ;
321 <  exJ = info[k].atoms[tempEx]->getGlobalIndex() + 1;
322 <      
323 <  info[k].excludes[j+excludeOffset]->setPair( exI, exJ );
318 >        tempEx = exI;
319 >        exI = info[k].atoms[tempEx]->getGlobalIndex() + 1;
320 >        tempEx = exJ;
321 >        exJ = info[k].atoms[tempEx]->getGlobalIndex() + 1;
322 >
323 >        info[k].excludes[j + excludeOffset]->setPair(exI, exJ);
324   #else  // isn't MPI
325 <  info[k].excludes[j+excludeOffset]->setPair( (exI+1), (exJ+1) );
325 >        info[k].excludes[j + excludeOffset]->setPair((exI + 1), (exJ + 1));
326   #endif  //is_mpi
327        }
328        excludeOffset += molInfo.nBends;
329 <      
330 <      for(j=0; j<molInfo.nTorsions; j++){
331 <  
332 <  currentTorsion = comp_stamps[stampID]->getTorsion( j );
333 <  theTorsions[j].a = currentTorsion->getA() + atomOffset;
334 <  theTorsions[j].b = currentTorsion->getB() + atomOffset;
335 <  theTorsions[j].c = currentTorsion->getC() + atomOffset;
336 <  theTorsions[j].d = currentTorsion->getD() + atomOffset;
337 <  
338 <  exI = theTorsions[j].a;
339 <  exJ = theTorsions[j].d;
340 <  
341 <  // exclude_I must always be the smaller of the pair
342 <  if( exI > exJ ){
343 <    tempEx = exI;
344 <    exI = exJ;
345 <    exJ = tempEx;
361 <  }
329 >
330 >      for (j = 0; j < molInfo.nTorsions; j++){
331 >        currentTorsion = comp_stamps[stampID]->getTorsion(j);
332 >        theTorsions[j].a = currentTorsion->getA() + atomOffset;
333 >        theTorsions[j].b = currentTorsion->getB() + atomOffset;
334 >        theTorsions[j].c = currentTorsion->getC() + atomOffset;
335 >        theTorsions[j].d = currentTorsion->getD() + atomOffset;
336 >
337 >        exI = theTorsions[j].a;
338 >        exJ = theTorsions[j].d;
339 >
340 >        // exclude_I must always be the smaller of the pair
341 >        if (exI > exJ){
342 >          tempEx = exI;
343 >          exI = exJ;
344 >          exJ = tempEx;
345 >        }
346   #ifdef IS_MPI
347 <  tempEx = exI;
348 <  exI = info[k].atoms[tempEx]->getGlobalIndex() + 1;
349 <  tempEx = exJ;
350 <  exJ = info[k].atoms[tempEx]->getGlobalIndex() + 1;
351 <  
352 <  info[k].excludes[j+excludeOffset]->setPair( exI, exJ );
347 >        tempEx = exI;
348 >        exI = info[k].atoms[tempEx]->getGlobalIndex() + 1;
349 >        tempEx = exJ;
350 >        exJ = info[k].atoms[tempEx]->getGlobalIndex() + 1;
351 >
352 >        info[k].excludes[j + excludeOffset]->setPair(exI, exJ);
353   #else  // isn't MPI
354 <  info[k].excludes[j+excludeOffset]->setPair( (exI+1), (exJ+1) );
354 >        info[k].excludes[j + excludeOffset]->setPair((exI + 1), (exJ + 1));
355   #endif  //is_mpi
356        }
357        excludeOffset += molInfo.nTorsions;
358 <      
359 <      
358 >
359 >
360        // send the arrays off to the forceField for init.
377      
378      the_ff->initializeAtoms( molInfo.nAtoms, molInfo.myAtoms );
379      the_ff->initializeBonds( molInfo.nBonds, molInfo.myBonds, theBonds );
380      the_ff->initializeBends( molInfo.nBends, molInfo.myBends, theBends );
381      the_ff->initializeTorsions( molInfo.nTorsions, molInfo.myTorsions, theTorsions );
382      
383      
384      info[k].molecules[i].initialize( molInfo );
361  
362 <      
362 >      the_ff->initializeAtoms(molInfo.nAtoms, molInfo.myAtoms);
363 >      the_ff->initializeBonds(molInfo.nBonds, molInfo.myBonds, theBonds);
364 >      the_ff->initializeBends(molInfo.nBends, molInfo.myBends, theBends);
365 >      the_ff->initializeTorsions(molInfo.nTorsions, molInfo.myTorsions,
366 >                                 theTorsions);
367 >
368 >
369 >      info[k].molecules[i].initialize(molInfo);
370 >
371 >
372        atomOffset += molInfo.nAtoms;
373        delete[] theBonds;
374        delete[] theBends;
375        delete[] theTorsions;
376      }
377    }
378 <  
378 >
379   #ifdef IS_MPI
380 <  sprintf( checkPointMsg, "all molecules initialized succesfully" );
380 >  sprintf(checkPointMsg, "all molecules initialized succesfully");
381    MPIcheckPoint();
382   #endif // is_mpi
383 <  
383 >
384    // clean up the forcefield
385  
386    the_ff->calcRcut();
387    the_ff->cleanMe();
403  
388   }
389  
390 < void SimSetup::initFromBass( void ){
407 <
390 > void SimSetup::initFromBass(void){
391    int i, j, k;
392    int n_cells;
393    double cellx, celly, cellz;
# Line 418 | Line 401 | void SimSetup::initFromBass( void ){
401    vel[1] = 0.0;
402    vel[2] = 0.0;
403  
404 <  temp1 = (double)tot_nmol / 4.0;
405 <  temp2 = pow( temp1, ( 1.0 / 3.0 ) );
406 <  temp3 = ceil( temp2 );
404 >  temp1 = (double) tot_nmol / 4.0;
405 >  temp2 = pow(temp1, (1.0 / 3.0));
406 >  temp3 = ceil(temp2);
407  
408 <  have_extra =0;
409 <  if( temp2 < temp3 ){ // we have a non-complete lattice
410 <    have_extra =1;
408 >  have_extra = 0;
409 >  if (temp2 < temp3){
410 >    // we have a non-complete lattice
411 >    have_extra = 1;
412  
413 <    n_cells = (int)temp3 - 1;
413 >    n_cells = (int) temp3 - 1;
414      cellx = info[0].boxL[0] / temp3;
415      celly = info[0].boxL[1] / temp3;
416      cellz = info[0].boxL[2] / temp3;
417 <    n_extra = tot_nmol - ( 4 * n_cells * n_cells * n_cells );
418 <    temp1 = ((double)n_extra) / ( pow( temp3, 3.0 ) - pow( n_cells, 3.0 ) );
419 <    n_per_extra = (int)ceil( temp1 );
417 >    n_extra = tot_nmol - (4 * n_cells * n_cells * n_cells);
418 >    temp1 = ((double) n_extra) / (pow(temp3, 3.0) - pow(n_cells, 3.0));
419 >    n_per_extra = (int) ceil(temp1);
420  
421 <    if( n_per_extra > 4){
422 <      sprintf( painCave.errMsg,
423 <         "SimSetup error. There has been an error in constructing"
424 <         " the non-complete lattice.\n" );
421 >    if (n_per_extra > 4){
422 >      sprintf(painCave.errMsg,
423 >              "SimSetup error. There has been an error in constructing"
424 >              " the non-complete lattice.\n");
425        painCave.isFatal = 1;
426        simError();
427      }
428    }
429    else{
430 <    n_cells = (int)temp3;
430 >    n_cells = (int) temp3;
431      cellx = info[0].boxL[0] / temp3;
432      celly = info[0].boxL[1] / temp3;
433      cellz = info[0].boxL[2] / temp3;
# Line 454 | Line 438 | void SimSetup::initFromBass( void ){
438    current_comp = 0;
439    current_atom_ndx = 0;
440  
441 <  for( i=0; i < n_cells ; i++ ){
442 <    for( j=0; j < n_cells; j++ ){
443 <      for( k=0; k < n_cells; k++ ){
441 >  for (i = 0; i < n_cells ; i++){
442 >    for (j = 0; j < n_cells; j++){
443 >      for (k = 0; k < n_cells; k++){
444 >        makeElement(i * cellx, j * celly, k * cellz);
445  
446 <  makeElement( i * cellx,
462 <         j * celly,
463 <         k * cellz );
446 >        makeElement(i * cellx + 0.5 * cellx, j * celly + 0.5 * celly, k * cellz);
447  
448 <  makeElement( i * cellx + 0.5 * cellx,
466 <         j * celly + 0.5 * celly,
467 <         k * cellz );
448 >        makeElement(i * cellx, j * celly + 0.5 * celly, k * cellz + 0.5 * cellz);
449  
450 <  makeElement( i * cellx,
470 <         j * celly + 0.5 * celly,
471 <         k * cellz + 0.5 * cellz );
472 <
473 <  makeElement( i * cellx + 0.5 * cellx,
474 <         j * celly,
475 <         k * cellz + 0.5 * cellz );
450 >        makeElement(i * cellx + 0.5 * cellx, j * celly, k * cellz + 0.5 * cellz);
451        }
452      }
453    }
454  
455 <  if( have_extra ){
455 >  if (have_extra){
456      done = 0;
457  
458      int start_ndx;
459 <    for( i=0; i < (n_cells+1) && !done; i++ ){
460 <      for( j=0; j < (n_cells+1) && !done; j++ ){
459 >    for (i = 0; i < (n_cells + 1) && !done; i++){
460 >      for (j = 0; j < (n_cells + 1) && !done; j++){
461 >        if (i < n_cells){
462 >          if (j < n_cells){
463 >            start_ndx = n_cells;
464 >          }
465 >          else
466 >            start_ndx = 0;
467 >        }
468 >        else
469 >          start_ndx = 0;
470  
471 <  if( i < n_cells ){
471 >        for (k = start_ndx; k < (n_cells + 1) && !done; k++){
472 >          makeElement(i * cellx, j * celly, k * cellz);
473 >          done = (current_mol >= tot_nmol);
474  
475 <    if( j < n_cells ){
476 <      start_ndx = n_cells;
477 <    }
478 <    else start_ndx = 0;
479 <  }
494 <  else start_ndx = 0;
495 <
496 <  for( k=start_ndx; k < (n_cells+1) && !done; k++ ){
475 >          if (!done && n_per_extra > 1){
476 >            makeElement(i * cellx + 0.5 * cellx, j * celly + 0.5 * celly,
477 >                        k * cellz);
478 >            done = (current_mol >= tot_nmol);
479 >          }
480  
481 <    makeElement( i * cellx,
482 <           j * celly,
483 <           k * cellz );
484 <    done = ( current_mol >= tot_nmol );
481 >          if (!done && n_per_extra > 2){
482 >            makeElement(i * cellx, j * celly + 0.5 * celly,
483 >                        k * cellz + 0.5 * cellz);
484 >            done = (current_mol >= tot_nmol);
485 >          }
486  
487 <    if( !done && n_per_extra > 1 ){
488 <      makeElement( i * cellx + 0.5 * cellx,
489 <       j * celly + 0.5 * celly,
490 <       k * cellz );
491 <      done = ( current_mol >= tot_nmol );
492 <    }
509 <
510 <    if( !done && n_per_extra > 2){
511 <      makeElement( i * cellx,
512 <       j * celly + 0.5 * celly,
513 <       k * cellz + 0.5 * cellz );
514 <      done = ( current_mol >= tot_nmol );
515 <    }
516 <
517 <    if( !done && n_per_extra > 3){
518 <      makeElement( i * cellx + 0.5 * cellx,
519 <       j * celly,
520 <       k * cellz + 0.5 * cellz );
521 <      done = ( current_mol >= tot_nmol );
522 <    }
523 <  }
487 >          if (!done && n_per_extra > 3){
488 >            makeElement(i * cellx + 0.5 * cellx, j * celly,
489 >                        k * cellz + 0.5 * cellz);
490 >            done = (current_mol >= tot_nmol);
491 >          }
492 >        }
493        }
494      }
495    }
496  
497 <  for( i=0; i<info[0].n_atoms; i++ ){
498 <    info[0].atoms[i]->setVel( vel );
497 >  for (i = 0; i < info[0].n_atoms; i++){
498 >    info[0].atoms[i]->setVel(vel);
499    }
500   }
501  
502 < void SimSetup::makeElement( double x, double y, double z ){
534 <
502 > void SimSetup::makeElement(double x, double y, double z){
503    int k;
504    AtomStamp* current_atom;
505    DirectionalAtom* dAtom;
506    double rotMat[3][3];
507    double pos[3];
508  
509 <  for( k=0; k<comp_stamps[current_comp]->getNAtoms(); k++ ){
510 <
511 <    current_atom = comp_stamps[current_comp]->getAtom( k );
512 <    if( !current_atom->havePosition() ){
513 <      sprintf( painCave.errMsg,
514 <         "SimSetup:initFromBass error.\n"
515 <         "\tComponent %s, atom %s does not have a position specified.\n"
516 <         "\tThe initialization routine is unable to give a start"
517 <         " position.\n",
550 <         comp_stamps[current_comp]->getID(),
551 <         current_atom->getType() );
509 >  for (k = 0; k < comp_stamps[current_comp]->getNAtoms(); k++){
510 >    current_atom = comp_stamps[current_comp]->getAtom(k);
511 >    if (!current_atom->havePosition()){
512 >      sprintf(painCave.errMsg,
513 >              "SimSetup:initFromBass error.\n"
514 >              "\tComponent %s, atom %s does not have a position specified.\n"
515 >              "\tThe initialization routine is unable to give a start"
516 >              " position.\n",
517 >              comp_stamps[current_comp]->getID(), current_atom->getType());
518        painCave.isFatal = 1;
519        simError();
520      }
521 <    
521 >
522      pos[0] = x + current_atom->getPosX();
523      pos[1] = y + current_atom->getPosY();
524      pos[2] = z + current_atom->getPosZ();
559    
560    info[0].atoms[current_atom_ndx]->setPos( pos );
525  
526 <    if( info[0].atoms[current_atom_ndx]->isDirectional() ){
526 >    info[0].atoms[current_atom_ndx]->setPos(pos);
527  
528 <      dAtom = (DirectionalAtom *)info[0].atoms[current_atom_ndx];
528 >    if (info[0].atoms[current_atom_ndx]->isDirectional()){
529 >      dAtom = (DirectionalAtom *) info[0].atoms[current_atom_ndx];
530  
531        rotMat[0][0] = 1.0;
532        rotMat[0][1] = 0.0;
# Line 575 | Line 540 | void SimSetup::makeElement( double x, double y, double
540        rotMat[2][1] = 0.0;
541        rotMat[2][2] = 1.0;
542  
543 <      dAtom->setA( rotMat );
543 >      dAtom->setA(rotMat);
544      }
545  
546      current_atom_ndx++;
# Line 584 | Line 549 | void SimSetup::makeElement( double x, double y, double
549    current_mol++;
550    current_comp_mol++;
551  
552 <  if( current_comp_mol >= components_nmol[current_comp] ){
588 <
552 >  if (current_comp_mol >= components_nmol[current_comp]){
553      current_comp_mol = 0;
554      current_comp++;
555    }
556   }
557  
558  
559 < void SimSetup::gatherInfo( void ){
560 <  int i,j,k;
559 > void SimSetup::gatherInfo(void){
560 >  int i;
561  
562    ensembleCase = -1;
563    ffCase = -1;
564  
565    // set the easy ones first
566  
567 <  for( i=0; i<nInfo; i++){
567 >  for (i = 0; i < nInfo; i++){
568      info[i].target_temp = globals->getTargetTemp();
569      info[i].dt = globals->getDt();
570      info[i].run_time = globals->getRunTime();
# Line 610 | Line 574 | void SimSetup::gatherInfo( void ){
574  
575    // get the forceField
576  
577 <  strcpy( force_field, globals->getForceField() );
577 >  strcpy(force_field, globals->getForceField());
578  
579 <  if( !strcasecmp( force_field, "DUFF" )) ffCase = FF_DUFF;
580 <  else if( !strcasecmp( force_field, "LJ" )) ffCase = FF_LJ;
581 <  else if( !strcasecmp( force_field, "EAM" )) ffCase = FF_EAM;
579 >  if (!strcasecmp(force_field, "DUFF")){
580 >    ffCase = FF_DUFF;
581 >  }
582 >  else if (!strcasecmp(force_field, "LJ")){
583 >    ffCase = FF_LJ;
584 >  }
585 >  else if (!strcasecmp(force_field, "EAM")){
586 >    ffCase = FF_EAM;
587 >  }
588    else{
589 <    sprintf( painCave.errMsg,
590 <       "SimSetup Error. Unrecognized force field -> %s\n",
591 <       force_field );
592 <    painCave.isFatal = 1;
623 <    simError();
589 >    sprintf(painCave.errMsg, "SimSetup Error. Unrecognized force field -> %s\n",
590 >            force_field);
591 >         painCave.isFatal = 1;
592 >         simError();
593    }
594  
595 <  // get the ensemble
595 >    // get the ensemble
596  
597 <  strcpy( ensemble, globals->getEnsemble() );
597 >  strcpy(ensemble, globals->getEnsemble());
598  
599 <  if( !strcasecmp( ensemble, "NVE" ))      ensembleCase = NVE_ENS;
600 <  else if( !strcasecmp( ensemble, "NVT" )) ensembleCase = NVT_ENS;
601 <  else if( !strcasecmp( ensemble, "NPTi" ) || !strcasecmp( ensemble, "NPT") )
599 >  if (!strcasecmp(ensemble, "NVE")){
600 >    ensembleCase = NVE_ENS;
601 >  }
602 >  else if (!strcasecmp(ensemble, "NVT")){
603 >    ensembleCase = NVT_ENS;
604 >  }
605 >  else if (!strcasecmp(ensemble, "NPTi") || !strcasecmp(ensemble, "NPT")){
606      ensembleCase = NPTi_ENS;
607 <  else if( !strcasecmp( ensemble, "NPTf" )) ensembleCase = NPTf_ENS;
608 <  else if( !strcasecmp( ensemble, "NPTim" )) ensembleCase = NPTim_ENS;
609 <  else if( !strcasecmp( ensemble, "NPTfm" )) ensembleCase = NPTfm_ENS;
607 >  }
608 >  else if (!strcasecmp(ensemble, "NPTf")){
609 >    ensembleCase = NPTf_ENS;
610 >  }
611 >  else if (!strcasecmp(ensemble, "NPTxyz")){
612 >    ensembleCase = NPTxyz_ENS;
613 >  }
614    else{
615 <    sprintf( painCave.errMsg,
616 <       "SimSetup Warning. Unrecognized Ensemble -> %s, "
617 <             "reverting to NVE for this simulation.\n",
618 <       ensemble );
619 <    painCave.isFatal = 0;
620 <    simError();
621 <    strcpy( ensemble, "NVE" );
622 <    ensembleCase = NVE_ENS;
615 >    sprintf(painCave.errMsg,
616 >            "SimSetup Warning. Unrecognized Ensemble -> %s, "
617 >            "reverting to NVE for this simulation.\n",
618 >            ensemble);
619 >         painCave.isFatal = 0;
620 >         simError();
621 >         strcpy(ensemble, "NVE");
622 >         ensembleCase = NVE_ENS;
623    }  
647  
648  for(i=0; i<nInfo; i++){
649    
650    strcpy( info[i].ensemble, ensemble );
624  
625 +  for (i = 0; i < nInfo; i++){
626 +    strcpy(info[i].ensemble, ensemble);
627 +
628      // get the mixing rule
629  
630 <    strcpy( info[i].mixingRule, globals->getMixingRule() );
630 >    strcpy(info[i].mixingRule, globals->getMixingRule());
631      info[i].usePBC = globals->getPBC();
632    }
633 <  
633 >
634    // get the components and calculate the tot_nMol and indvidual n_mol
635 <
635 >
636    the_components = globals->getComponents();
637    components_nmol = new int[n_components];
638  
639  
640 <  if( !globals->haveNMol() ){
640 >  if (!globals->haveNMol()){
641      // we don't have the total number of molecules, so we assume it is
642      // given in each component
643  
644      tot_nmol = 0;
645 <    for( i=0; i<n_components; i++ ){
646 <
647 <      if( !the_components[i]->haveNMol() ){
648 <  // we have a problem
649 <  sprintf( painCave.errMsg,
650 <     "SimSetup Error. No global NMol or component NMol"
651 <     " given. Cannot calculate the number of atoms.\n" );
652 <  painCave.isFatal = 1;
677 <  simError();
645 >    for (i = 0; i < n_components; i++){
646 >      if (!the_components[i]->haveNMol()){
647 >        // we have a problem
648 >        sprintf(painCave.errMsg,
649 >                "SimSetup Error. No global NMol or component NMol"
650 >                " given. Cannot calculate the number of atoms.\n");
651 >        painCave.isFatal = 1;
652 >        simError();
653        }
654  
655        tot_nmol += the_components[i]->getNMol();
# Line 682 | Line 657 | void SimSetup::gatherInfo( void ){
657      }
658    }
659    else{
660 <    sprintf( painCave.errMsg,
661 <       "SimSetup error.\n"
662 <       "\tSorry, the ability to specify total"
663 <       " nMols and then give molfractions in the components\n"
664 <       "\tis not currently supported."
665 <       " Please give nMol in the components.\n" );
660 >    sprintf(painCave.errMsg,
661 >            "SimSetup error.\n"
662 >            "\tSorry, the ability to specify total"
663 >            " nMols and then give molfractions in the components\n"
664 >            "\tis not currently supported."
665 >            " Please give nMol in the components.\n");
666      painCave.isFatal = 1;
667      simError();
668    }
669  
670    // set the status, sample, and thermal kick times
696  
697  for(i=0; i<nInfo; i++){
671  
672 <    if( globals->haveSampleTime() ){
672 >  for (i = 0; i < nInfo; i++){
673 >    if (globals->haveSampleTime()){
674        info[i].sampleTime = globals->getSampleTime();
675        info[i].statusTime = info[i].sampleTime;
676        info[i].thermalTime = info[i].sampleTime;
# Line 706 | Line 680 | void SimSetup::gatherInfo( void ){
680        info[i].statusTime = info[i].sampleTime;
681        info[i].thermalTime = info[i].sampleTime;
682      }
683 <    
684 <    if( globals->haveStatusTime() ){
683 >
684 >    if (globals->haveStatusTime()){
685        info[i].statusTime = globals->getStatusTime();
686      }
687 <    
688 <    if( globals->haveThermalTime() ){
687 >
688 >    if (globals->haveThermalTime()){
689        info[i].thermalTime = globals->getThermalTime();
690      }
691  
692 <    // check for the temperature set flag
692 >    info[i].resetIntegrator = 0;
693 >    if( globals->haveResetTime() ){
694 >      info[i].resetTime = globals->getResetTime();
695 >      info[i].resetIntegrator = 1;
696 >    }
697  
698 <    if( globals->haveTempSet() ) info[i].setTemp = globals->getTempSet();
698 >    // check for the temperature set flag
699      
700 <    // get some of the tricky things that may still be in the globals
700 >    if (globals->haveTempSet())
701 >      info[i].setTemp = globals->getTempSet();
702      
724    double boxVector[3];
725    if( globals->haveBox() ){
726      boxVector[0] = globals->getBox();
727      boxVector[1] = globals->getBox();
728      boxVector[2] = globals->getBox();
729      
730      info[i].setBox( boxVector );
731    }
732    else if( globals->haveDensity() ){
733      
734      double vol;
735      vol = (double)tot_nmol / globals->getDensity();
736      boxVector[0] = pow( vol, ( 1.0 / 3.0 ) );
737      boxVector[1] = boxVector[0];
738      boxVector[2] = boxVector[0];
739      
740      info[i].setBox( boxVector );
703    }
704 <    else{
705 <      if( !globals->haveBoxX() ){
706 <  sprintf( painCave.errMsg,
707 <     "SimSetup error, no periodic BoxX size given.\n" );
708 <  painCave.isFatal = 1;
709 <  simError();
710 <      }
711 <      boxVector[0] = globals->getBoxX();
712 <      
713 <      if( !globals->haveBoxY() ){
714 <  sprintf( painCave.errMsg,
715 <     "SimSetup error, no periodic BoxY size given.\n" );
716 <  painCave.isFatal = 1;
717 <  simError();
704 >  
705 >  //setup seed for random number generator
706 >  int seedValue;
707 >
708 >  if (globals->haveSeed()){
709 >    seedValue = globals->getSeed();
710 >
711 >    if(seedValue / 1E9 == 0){
712 >      sprintf(painCave.errMsg,
713 >              "Seed for sprng library should contain at least 9 digits\n"
714 >              "OOPSE will generate a seed for user\n");
715 >      painCave.isFatal = 0;
716 >      simError();
717 >
718 >      //using seed generated by system instead of invalid seed set by user
719 > #ifndef IS_MPI
720 >      seedValue = make_sprng_seed();
721 > #else
722 >      if (worldRank == 0){
723 >        seedValue = make_sprng_seed();
724        }
725 <      boxVector[1] = globals->getBoxY();
726 <      
759 <      if( !globals->haveBoxZ() ){
760 <  sprintf( painCave.errMsg,
761 <     "SimSetup error, no periodic BoxZ size given.\n" );
762 <  painCave.isFatal = 1;
763 <  simError();
764 <      }
765 <      boxVector[2] = globals->getBoxZ();
766 <      
767 <      info[i].setBox( boxVector );
725 >      MPI_Bcast(&seedValue, 1, MPI_INT, 0, MPI_COMM_WORLD);  
726 > #endif      
727      }
728 +  }//end of if branch of globals->haveSeed()
729 +  else{
730 +    
731 + #ifndef IS_MPI
732 +    seedValue = make_sprng_seed();
733 + #else
734 +    if (worldRank == 0){
735 +      seedValue = make_sprng_seed();
736 +    }
737 +    MPI_Bcast(&seedValue, 1, MPI_INT, 0, MPI_COMM_WORLD);  
738 + #endif
739 +  }//end of globals->haveSeed()
740  
741 +  for (int i = 0; i < nInfo; i++){
742 +    info[i].setSeed(seedValue);
743    }
744 <    
744 >
745   #ifdef IS_MPI
746 <  strcpy( checkPointMsg, "Succesfully gathered all information from Bass\n" );
746 >  strcpy(checkPointMsg, "Succesfully gathered all information from Bass\n");
747    MPIcheckPoint();
748   #endif // is_mpi
776
749   }
750  
751  
752 < void SimSetup::finalInfoCheck( void ){
752 > void SimSetup::finalInfoCheck(void){
753    int index;
754    int usesDipoles;
755    int i;
756  
757 <  for(i=0; i<nInfo; i++){
757 >  for (i = 0; i < nInfo; i++){
758      // check electrostatic parameters
759 <    
759 >
760      index = 0;
761      usesDipoles = 0;
762 <    while( (index < info[i].n_atoms) && !usesDipoles ){
762 >    while ((index < info[i].n_atoms) && !usesDipoles){
763        usesDipoles = (info[i].atoms[index])->hasDipole();
764        index++;
765      }
766 <    
766 >
767   #ifdef IS_MPI
768      int myUse = usesDipoles;
769 <    MPI_Allreduce( &myUse, &usesDipoles, 1, MPI_INT, MPI_LOR, MPI_COMM_WORLD );
769 >    MPI_Allreduce(&myUse, &usesDipoles, 1, MPI_INT, MPI_LOR, MPI_COMM_WORLD);
770   #endif //is_mpi
771 <    
771 >
772      double theEcr, theEst;
773 <  
774 <    if (globals->getUseRF() ) {
773 >
774 >    if (globals->getUseRF()){
775        info[i].useReactionField = 1;
776 <      
777 <      if( !globals->haveECR() ){
778 <  sprintf( painCave.errMsg,
779 <     "SimSetup Warning: using default value of 1/2 the smallest "
780 <     "box length for the electrostaticCutoffRadius.\n"
781 <     "I hope you have a very fast processor!\n");
782 <  painCave.isFatal = 0;
783 <  simError();
784 <  double smallest;
785 <  smallest = info[i].boxL[0];
786 <  if (info[i].boxL[1] <= smallest) smallest = info[i].boxL[1];
787 <  if (info[i].boxL[2] <= smallest) smallest = info[i].boxL[2];
788 <  theEcr = 0.5 * smallest;
789 <      } else {
790 <  theEcr = globals->getECR();
776 >
777 >      if (!globals->haveECR()){
778 >        sprintf(painCave.errMsg,
779 >                "SimSetup Warning: using default value of 1/2 the smallest "
780 >                "box length for the electrostaticCutoffRadius.\n"
781 >                "I hope you have a very fast processor!\n");
782 >        painCave.isFatal = 0;
783 >        simError();
784 >        double smallest;
785 >        smallest = info[i].boxL[0];
786 >        if (info[i].boxL[1] <= smallest)
787 >          smallest = info[i].boxL[1];
788 >        if (info[i].boxL[2] <= smallest)
789 >          smallest = info[i].boxL[2];
790 >        theEcr = 0.5 * smallest;
791        }
792 <      
793 <      if( !globals->haveEST() ){
822 <  sprintf( painCave.errMsg,
823 <     "SimSetup Warning: using default value of 0.05 * the "
824 <     "electrostaticCutoffRadius for the electrostaticSkinThickness\n"
825 <     );
826 <  painCave.isFatal = 0;
827 <  simError();
828 <  theEst = 0.05 * theEcr;
829 <      } else {
830 <  theEst= globals->getEST();
792 >      else{
793 >        theEcr = globals->getECR();
794        }
795 <      
796 <      info[i].setEcr( theEcr, theEst );
797 <      
798 <      if(!globals->haveDielectric() ){
799 <  sprintf( painCave.errMsg,
800 <     "SimSetup Error: You are trying to use Reaction Field without"
801 <     "setting a dielectric constant!\n"
802 <     );
840 <  painCave.isFatal = 1;
841 <  simError();
795 >
796 >      if (!globals->haveEST()){
797 >        sprintf(painCave.errMsg,
798 >                "SimSetup Warning: using default value of 0.05 * the "
799 >                "electrostaticCutoffRadius for the electrostaticSkinThickness\n");
800 >        painCave.isFatal = 0;
801 >        simError();
802 >        theEst = 0.05 * theEcr;
803        }
804 <      info[i].dielectric = globals->getDielectric();  
805 <    }
845 <    else {
846 <      if (usesDipoles) {
847 <  
848 <  if( !globals->haveECR() ){
849 <    sprintf( painCave.errMsg,
850 <       "SimSetup Warning: using default value of 1/2 the smallest "
851 <       "box length for the electrostaticCutoffRadius.\n"
852 <       "I hope you have a very fast processor!\n");
853 <    painCave.isFatal = 0;
854 <    simError();
855 <    double smallest;
856 <    smallest = info[i].boxL[0];
857 <    if (info[i].boxL[1] <= smallest) smallest = info[i].boxL[1];
858 <    if (info[i].boxL[2] <= smallest) smallest = info[i].boxL[2];
859 <    theEcr = 0.5 * smallest;
860 <  } else {
861 <    theEcr = globals->getECR();
862 <  }
863 <  
864 <  if( !globals->haveEST() ){
865 <    sprintf( painCave.errMsg,
866 <       "SimSetup Warning: using default value of 0.05 * the "
867 <       "electrostaticCutoffRadius for the "
868 <       "electrostaticSkinThickness\n"
869 <       );
870 <    painCave.isFatal = 0;
871 <    simError();
872 <    theEst = 0.05 * theEcr;
873 <  } else {
874 <    theEst= globals->getEST();
875 <  }
876 <  
877 <  info[i].setEcr( theEcr, theEst );
804 >      else{
805 >        theEst = globals->getEST();
806        }
807 <    }  
807 >
808 >      info[i].setDefaultEcr(theEcr, theEst);
809 >
810 >      if (!globals->haveDielectric()){
811 >        sprintf(painCave.errMsg,
812 >                "SimSetup Error: You are trying to use Reaction Field without"
813 >                "setting a dielectric constant!\n");
814 >        painCave.isFatal = 1;
815 >        simError();
816 >      }
817 >      info[i].dielectric = globals->getDielectric();
818 >    }
819 >    else{
820 >      if (usesDipoles){
821 >        if (!globals->haveECR()){
822 >          sprintf(painCave.errMsg,
823 >                  "SimSetup Warning: using default value of 1/2 the smallest "
824 >                  "box length for the electrostaticCutoffRadius.\n"
825 >                  "I hope you have a very fast processor!\n");
826 >          painCave.isFatal = 0;
827 >          simError();
828 >          double smallest;
829 >          smallest = info[i].boxL[0];
830 >          if (info[i].boxL[1] <= smallest)
831 >            smallest = info[i].boxL[1];
832 >          if (info[i].boxL[2] <= smallest)
833 >            smallest = info[i].boxL[2];
834 >          theEcr = 0.5 * smallest;
835 >        }
836 >        else{
837 >          theEcr = globals->getECR();
838 >        }
839 >
840 >        if (!globals->haveEST()){
841 >          sprintf(painCave.errMsg,
842 >                  "SimSetup Warning: using default value of 0.05 * the "
843 >                  "electrostaticCutoffRadius for the "
844 >                  "electrostaticSkinThickness\n");
845 >          painCave.isFatal = 0;
846 >          simError();
847 >          theEst = 0.05 * theEcr;
848 >        }
849 >        else{
850 >          theEst = globals->getEST();
851 >        }
852 >
853 >        info[i].setDefaultEcr(theEcr, theEst);
854 >      }
855 >    }
856 >    info[i].checkCutOffs();
857    }
858  
859   #ifdef IS_MPI
860 <  strcpy( checkPointMsg, "post processing checks out" );
860 >  strcpy(checkPointMsg, "post processing checks out");
861    MPIcheckPoint();
862   #endif // is_mpi
886
863   }
864  
865 < void SimSetup::initSystemCoords( void ){
865 > void SimSetup::initSystemCoords(void){
866    int i;
867 <  
867 >
868    char* inName;
869  
870 <  (info[0].getConfiguration())->createArrays( info[0].n_atoms );
870 >  (info[0].getConfiguration())->createArrays(info[0].n_atoms);
871  
872 <  for(i=0; i<info[0].n_atoms; i++) info[0].atoms[i]->setCoords();
873 <  
874 <  if( globals->haveInitialConfig() ){
875 <    
876 <    InitializeFromFile* fileInit;
872 >  for (i = 0; i < info[0].n_atoms; i++)
873 >    info[0].atoms[i]->setCoords();
874 >
875 >  if (globals->haveInitialConfig()){
876 >    InitializeFromFile* fileInit;
877   #ifdef IS_MPI // is_mpi
878 <    if( worldRank == 0 ){
878 >    if (worldRank == 0){
879   #endif //is_mpi
880        inName = globals->getInitialConfig();
881 <      double* tempDouble = new double[1000000];
906 <      fileInit = new InitializeFromFile( inName );
881 >      fileInit = new InitializeFromFile(inName);
882   #ifdef IS_MPI
883 <    }else fileInit = new InitializeFromFile( NULL );
883 >    }
884 >    else
885 >      fileInit = new InitializeFromFile(NULL);
886   #endif
887 <    fileInit->readInit( info ); // default velocities on
888 <    
887 >    fileInit->readInit(info); // default velocities on
888 >
889      delete fileInit;
890    }
891    else{
915    
892   #ifdef IS_MPI
893 <    
893 >
894      // no init from bass
895 <    
896 <    sprintf( painCave.errMsg,
897 <       "Cannot intialize a parallel simulation without an initial configuration file.\n" );
898 <    painCave.isFatal;
895 >
896 >    sprintf(painCave.errMsg,
897 >            "Cannot intialize a parallel simulation without an initial configuration file.\n");
898 >    painCave.isFatal = 1;;
899      simError();
900 <    
900 >
901   #else
902 <    
902 >
903      initFromBass();
904 <    
905 <    
904 >
905 >
906   #endif
907    }
908 <  
908 >
909   #ifdef IS_MPI
910 <  strcpy( checkPointMsg, "Successfully read in the initial configuration" );
910 >  strcpy(checkPointMsg, "Successfully read in the initial configuration");
911    MPIcheckPoint();
912   #endif // is_mpi
937  
913   }
914  
915  
916 < void SimSetup::makeOutNames( void ){
942 <  
916 > void SimSetup::makeOutNames(void){
917    int k;
918  
945  
946  for(k=0; k<nInfo; k++){
919  
920 +  for (k = 0; k < nInfo; k++){
921   #ifdef IS_MPI
922 <    if( worldRank == 0 ){
922 >    if (worldRank == 0){
923   #endif // is_mpi
924 <      
925 <      if( globals->haveFinalConfig() ){
926 <  strcpy( info[k].finalName, globals->getFinalConfig() );
924 >
925 >      if (globals->haveFinalConfig()){
926 >        strcpy(info[k].finalName, globals->getFinalConfig());
927        }
928        else{
929 <  strcpy( info[k].finalName, inFileName );
930 <  char* endTest;
931 <  int nameLength = strlen( info[k].finalName );
932 <  endTest = &(info[k].finalName[nameLength - 5]);
933 <  if( !strcmp( endTest, ".bass" ) ){
934 <    strcpy( endTest, ".eor" );
935 <  }
936 <  else if( !strcmp( endTest, ".BASS" ) ){
937 <    strcpy( endTest, ".eor" );
938 <  }
939 <  else{
940 <    endTest = &(info[k].finalName[nameLength - 4]);
941 <    if( !strcmp( endTest, ".bss" ) ){
942 <      strcpy( endTest, ".eor" );
943 <    }
944 <    else if( !strcmp( endTest, ".mdl" ) ){
945 <      strcpy( endTest, ".eor" );
946 <    }
947 <    else{
948 <      strcat( info[k].finalName, ".eor" );
949 <    }
950 <  }
929 >        strcpy(info[k].finalName, inFileName);
930 >        char* endTest;
931 >        int nameLength = strlen(info[k].finalName);
932 >        endTest = &(info[k].finalName[nameLength - 5]);
933 >        if (!strcmp(endTest, ".bass")){
934 >          strcpy(endTest, ".eor");
935 >        }
936 >        else if (!strcmp(endTest, ".BASS")){
937 >          strcpy(endTest, ".eor");
938 >        }
939 >        else{
940 >          endTest = &(info[k].finalName[nameLength - 4]);
941 >          if (!strcmp(endTest, ".bss")){
942 >            strcpy(endTest, ".eor");
943 >          }
944 >          else if (!strcmp(endTest, ".mdl")){
945 >            strcpy(endTest, ".eor");
946 >          }
947 >          else{
948 >            strcat(info[k].finalName, ".eor");
949 >          }
950 >        }
951        }
952 <      
952 >
953        // make the sample and status out names
954 <      
955 <      strcpy( info[k].sampleName, inFileName );
954 >
955 >      strcpy(info[k].sampleName, inFileName);
956        char* endTest;
957 <      int nameLength = strlen( info[k].sampleName );
957 >      int nameLength = strlen(info[k].sampleName);
958        endTest = &(info[k].sampleName[nameLength - 5]);
959 <      if( !strcmp( endTest, ".bass" ) ){
960 <  strcpy( endTest, ".dump" );
959 >      if (!strcmp(endTest, ".bass")){
960 >        strcpy(endTest, ".dump");
961        }
962 <      else if( !strcmp( endTest, ".BASS" ) ){
963 <  strcpy( endTest, ".dump" );
962 >      else if (!strcmp(endTest, ".BASS")){
963 >        strcpy(endTest, ".dump");
964        }
965        else{
966 <  endTest = &(info[k].sampleName[nameLength - 4]);
967 <  if( !strcmp( endTest, ".bss" ) ){
968 <    strcpy( endTest, ".dump" );
969 <  }
970 <  else if( !strcmp( endTest, ".mdl" ) ){
971 <    strcpy( endTest, ".dump" );
972 <  }
973 <  else{
974 <    strcat( info[k].sampleName, ".dump" );
975 <  }
966 >        endTest = &(info[k].sampleName[nameLength - 4]);
967 >        if (!strcmp(endTest, ".bss")){
968 >          strcpy(endTest, ".dump");
969 >        }
970 >        else if (!strcmp(endTest, ".mdl")){
971 >          strcpy(endTest, ".dump");
972 >        }
973 >        else{
974 >          strcat(info[k].sampleName, ".dump");
975 >        }
976        }
977 <      
978 <      strcpy( info[k].statusName, inFileName );
979 <      nameLength = strlen( info[k].statusName );
977 >
978 >      strcpy(info[k].statusName, inFileName);
979 >      nameLength = strlen(info[k].statusName);
980        endTest = &(info[k].statusName[nameLength - 5]);
981 <      if( !strcmp( endTest, ".bass" ) ){
982 <  strcpy( endTest, ".stat" );
981 >      if (!strcmp(endTest, ".bass")){
982 >        strcpy(endTest, ".stat");
983        }
984 <      else if( !strcmp( endTest, ".BASS" ) ){
985 <  strcpy( endTest, ".stat" );
984 >      else if (!strcmp(endTest, ".BASS")){
985 >        strcpy(endTest, ".stat");
986        }
987        else{
988 <  endTest = &(info[k].statusName[nameLength - 4]);
989 <  if( !strcmp( endTest, ".bss" ) ){
990 <    strcpy( endTest, ".stat" );
991 <  }
992 <  else if( !strcmp( endTest, ".mdl" ) ){
993 <    strcpy( endTest, ".stat" );
994 <  }
995 <  else{
996 <    strcat( info[k].statusName, ".stat" );
997 <  }
988 >        endTest = &(info[k].statusName[nameLength - 4]);
989 >        if (!strcmp(endTest, ".bss")){
990 >          strcpy(endTest, ".stat");
991 >        }
992 >        else if (!strcmp(endTest, ".mdl")){
993 >          strcpy(endTest, ".stat");
994 >        }
995 >        else{
996 >          strcat(info[k].statusName, ".stat");
997 >        }
998        }
999 <      
999 >
1000   #ifdef IS_MPI
1001 +
1002      }
1003   #endif // is_mpi
1004    }
1005   }
1006  
1007  
1008 < void SimSetup::sysObjectsCreation( void ){
1009 <  
1010 <  int i,k;
1037 <  
1008 > void SimSetup::sysObjectsCreation(void){
1009 >  int i, k;
1010 >
1011    // create the forceField
1012  
1013    createFF();
# Line 1049 | Line 1022 | void SimSetup::sysObjectsCreation( void ){
1022  
1023   #ifdef IS_MPI
1024    // divide the molecules among the processors
1025 <  
1025 >
1026    mpiMolDivide();
1027   #endif //is_mpi
1028 <  
1028 >
1029    // create the atom and SRI arrays. Also initialize Molecule Stamp ID's
1030 <
1030 >
1031    makeSysArrays();
1032  
1033    // make and initialize the molecules (all but atomic coordinates)
1034 <
1034 >
1035    makeMolecules();
1036 <  
1037 <  for(k=0; k<nInfo; k++){
1036 >
1037 >  for (k = 0; k < nInfo; k++){
1038      info[k].identArray = new int[info[k].n_atoms];
1039 <    for(i=0; i<info[k].n_atoms; i++){
1039 >    for (i = 0; i < info[k].n_atoms; i++){
1040        info[k].identArray[i] = info[k].atoms[i]->getIdent();
1041      }
1042    }
1043   }
1044  
1045  
1046 < void SimSetup::createFF( void ){
1046 > void SimSetup::createFF(void){
1047 >  switch (ffCase){
1048 >    case FF_DUFF:
1049 >      the_ff = new DUFF();
1050 >      break;
1051  
1052 <  switch( ffCase ){
1052 >    case FF_LJ:
1053 >      the_ff = new LJFF();
1054 >      break;
1055  
1056 <  case FF_DUFF:
1057 <    the_ff = new DUFF();
1058 <    break;
1056 >    case FF_EAM:
1057 >      the_ff = new EAM_FF();
1058 >      break;
1059  
1060 <  case FF_LJ:
1061 <    the_ff = new LJFF();
1062 <    break;
1063 <
1064 <  case FF_EAM:
1086 <    the_ff = new EAM_FF();
1087 <    break;
1088 <
1089 <  default:
1090 <    sprintf( painCave.errMsg,
1091 <       "SimSetup Error. Unrecognized force field in case statement.\n");
1092 <    painCave.isFatal = 1;
1093 <    simError();
1060 >    default:
1061 >      sprintf(painCave.errMsg,
1062 >              "SimSetup Error. Unrecognized force field in case statement.\n");
1063 >      painCave.isFatal = 1;
1064 >      simError();
1065    }
1066  
1067   #ifdef IS_MPI
1068 <  strcpy( checkPointMsg, "ForceField creation successful" );
1068 >  strcpy(checkPointMsg, "ForceField creation successful");
1069    MPIcheckPoint();
1070   #endif // is_mpi
1100
1071   }
1072  
1073  
1074 < void SimSetup::compList( void ){
1105 <
1074 > void SimSetup::compList(void){
1075    int i;
1076    char* id;
1077    LinkedMolStamp* headStamp = new LinkedMolStamp();
1078    LinkedMolStamp* currentStamp = NULL;
1079 <  comp_stamps = new MoleculeStamp*[n_components];
1080 <  
1079 >  comp_stamps = new MoleculeStamp * [n_components];
1080 >
1081    // make an array of molecule stamps that match the components used.
1082    // also extract the used stamps out into a separate linked list
1083 <  
1084 <  for(i=0; i<nInfo; i++){
1083 >
1084 >  for (i = 0; i < nInfo; i++){
1085      info[i].nComponents = n_components;
1086      info[i].componentsNmol = components_nmol;
1087      info[i].compStamps = comp_stamps;
1088      info[i].headStamp = headStamp;
1089    }
1121  
1090  
1123  for( i=0; i<n_components; i++ ){
1091  
1092 +  for (i = 0; i < n_components; i++){
1093      id = the_components[i]->getType();
1094      comp_stamps[i] = NULL;
1095 <    
1095 >
1096      // check to make sure the component isn't already in the list
1097  
1098 <    comp_stamps[i] = headStamp->match( id );
1099 <    if( comp_stamps[i] == NULL ){
1132 <      
1098 >    comp_stamps[i] = headStamp->match(id);
1099 >    if (comp_stamps[i] == NULL){
1100        // extract the component from the list;
1101 <      
1102 <      currentStamp = stamps->extractMolStamp( id );
1103 <      if( currentStamp == NULL ){
1104 <  sprintf( painCave.errMsg,
1105 <     "SimSetup error: Component \"%s\" was not found in the "
1106 <     "list of declared molecules\n",
1107 <     id );
1108 <  painCave.isFatal = 1;
1109 <  simError();
1101 >
1102 >      currentStamp = stamps->extractMolStamp(id);
1103 >      if (currentStamp == NULL){
1104 >        sprintf(painCave.errMsg,
1105 >                "SimSetup error: Component \"%s\" was not found in the "
1106 >                "list of declared molecules\n",
1107 >                id);
1108 >        painCave.isFatal = 1;
1109 >        simError();
1110        }
1111 <      
1112 <      headStamp->add( currentStamp );
1113 <      comp_stamps[i] = headStamp->match( id );
1111 >
1112 >      headStamp->add(currentStamp);
1113 >      comp_stamps[i] = headStamp->match(id);
1114      }
1115    }
1116  
1117   #ifdef IS_MPI
1118 <  strcpy( checkPointMsg, "Component stamps successfully extracted\n" );
1118 >  strcpy(checkPointMsg, "Component stamps successfully extracted\n");
1119    MPIcheckPoint();
1120   #endif // is_mpi
1121 + }
1122  
1123 + void SimSetup::calcSysValues(void){
1124 +  int i;
1125  
1126 < }
1126 >  int* molMembershipArray;
1127  
1158 void SimSetup::calcSysValues( void ){
1159  int i, j, k;
1160  
1161  int *molMembershipArray;
1162  
1128    tot_atoms = 0;
1129    tot_bonds = 0;
1130    tot_bends = 0;
1131    tot_torsions = 0;
1132 <  for( i=0; i<n_components; i++ ){
1133 <    
1134 <    tot_atoms +=    components_nmol[i] * comp_stamps[i]->getNAtoms();
1135 <    tot_bonds +=    components_nmol[i] * comp_stamps[i]->getNBonds();
1171 <    tot_bends +=    components_nmol[i] * comp_stamps[i]->getNBends();
1132 >  for (i = 0; i < n_components; i++){
1133 >    tot_atoms += components_nmol[i] * comp_stamps[i]->getNAtoms();
1134 >    tot_bonds += components_nmol[i] * comp_stamps[i]->getNBonds();
1135 >    tot_bends += components_nmol[i] * comp_stamps[i]->getNBends();
1136      tot_torsions += components_nmol[i] * comp_stamps[i]->getNTorsions();
1137    }
1138 <  
1138 >
1139    tot_SRI = tot_bonds + tot_bends + tot_torsions;
1140    molMembershipArray = new int[tot_atoms];
1141 <  
1142 <  for(i=0; i<nInfo; i++){
1141 >
1142 >  for (i = 0; i < nInfo; i++){
1143      info[i].n_atoms = tot_atoms;
1144      info[i].n_bonds = tot_bonds;
1145      info[i].n_bends = tot_bends;
1146      info[i].n_torsions = tot_torsions;
1147      info[i].n_SRI = tot_SRI;
1148      info[i].n_mol = tot_nmol;
1149 <    
1149 >
1150      info[i].molMembershipArray = molMembershipArray;
1151 <  }
1151 >  }
1152   }
1153  
1154   #ifdef IS_MPI
1155  
1156 < void SimSetup::mpiMolDivide( void ){
1193 <  
1156 > void SimSetup::mpiMolDivide(void){
1157    int i, j, k;
1158    int localMol, allMol;
1159    int local_atoms, local_bonds, local_bends, local_torsions, local_SRI;
1160  
1161 <  mpiSim = new mpiSimulation( info );
1162 <  
1161 >  mpiSim = new mpiSimulation(info);
1162 >
1163    globalIndex = mpiSim->divideLabor();
1164  
1165    // set up the local variables
1166 <  
1166 >
1167    mol2proc = mpiSim->getMolToProcMap();
1168    molCompType = mpiSim->getMolComponentType();
1169 <  
1169 >
1170    allMol = 0;
1171    localMol = 0;
1172    local_atoms = 0;
# Line 1213 | Line 1176 | void SimSetup::mpiMolDivide( void ){
1176    globalAtomIndex = 0;
1177  
1178  
1179 <  for( i=0; i<n_components; i++ ){
1180 <
1181 <    for( j=0; j<components_nmol[i]; j++ ){
1182 <      
1183 <      if( mol2proc[allMol] == worldRank ){
1184 <  
1185 <  local_atoms +=    comp_stamps[i]->getNAtoms();
1186 <  local_bonds +=    comp_stamps[i]->getNBonds();
1224 <  local_bends +=    comp_stamps[i]->getNBends();
1225 <  local_torsions += comp_stamps[i]->getNTorsions();
1226 <  localMol++;
1179 >  for (i = 0; i < n_components; i++){
1180 >    for (j = 0; j < components_nmol[i]; j++){
1181 >      if (mol2proc[allMol] == worldRank){
1182 >        local_atoms += comp_stamps[i]->getNAtoms();
1183 >        local_bonds += comp_stamps[i]->getNBonds();
1184 >        local_bends += comp_stamps[i]->getNBends();
1185 >        local_torsions += comp_stamps[i]->getNTorsions();
1186 >        localMol++;
1187        }      
1188 <      for (k = 0; k < comp_stamps[i]->getNAtoms(); k++) {
1188 >      for (k = 0; k < comp_stamps[i]->getNAtoms(); k++){
1189          info[0].molMembershipArray[globalAtomIndex] = allMol;
1190          globalAtomIndex++;
1191        }
1192  
1193 <      allMol++;      
1193 >      allMol++;
1194      }
1195    }
1196    local_SRI = local_bonds + local_bends + local_torsions;
1197 <  
1197 >
1198    info[0].n_atoms = mpiSim->getMyNlocal();  
1199 <  
1200 <  if( local_atoms != info[0].n_atoms ){
1201 <    sprintf( painCave.errMsg,
1202 <       "SimSetup error: mpiSim's localAtom (%d) and SimSetup's"
1203 <       " localAtom (%d) are not equal.\n",
1204 <       info[0].n_atoms,
1245 <       local_atoms );
1199 >
1200 >  if (local_atoms != info[0].n_atoms){
1201 >    sprintf(painCave.errMsg,
1202 >            "SimSetup error: mpiSim's localAtom (%d) and SimSetup's"
1203 >            " localAtom (%d) are not equal.\n",
1204 >            info[0].n_atoms, local_atoms);
1205      painCave.isFatal = 1;
1206      simError();
1207    }
# Line 1253 | Line 1212 | void SimSetup::mpiMolDivide( void ){
1212    info[0].n_SRI = local_SRI;
1213    info[0].n_mol = localMol;
1214  
1215 <  strcpy( checkPointMsg, "Passed nlocal consistency check." );
1215 >  strcpy(checkPointMsg, "Passed nlocal consistency check.");
1216    MPIcheckPoint();
1217   }
1218 <
1218 >
1219   #endif // is_mpi
1220  
1221  
1222 < void SimSetup::makeSysArrays( void ){
1223 <  int i, j, k, l;
1222 > void SimSetup::makeSysArrays(void){
1223 >
1224 > #ifndef IS_MPI
1225 >  int k, j;
1226 > #endif // is_mpi
1227 >  int i, l;
1228  
1229    Atom** the_atoms;
1230    Molecule* the_molecules;
1231    Exclude** the_excludes;
1232  
1233 <  
1234 <  for(l=0; l<nInfo; l++){
1272 <    
1233 >
1234 >  for (l = 0; l < nInfo; l++){
1235      // create the atom and short range interaction arrays
1236 <    
1237 <    the_atoms = new Atom*[info[l].n_atoms];
1236 >
1237 >    the_atoms = new Atom * [info[l].n_atoms];
1238      the_molecules = new Molecule[info[l].n_mol];
1239      int molIndex;
1240  
1241      // initialize the molecule's stampID's
1242 <    
1242 >
1243   #ifdef IS_MPI
1244 <    
1245 <    
1244 >
1245 >
1246      molIndex = 0;
1247 <    for(i=0; i<mpiSim->getTotNmol(); i++){
1248 <    
1249 <      if(mol2proc[i] == worldRank ){
1250 <  the_molecules[molIndex].setStampID( molCompType[i] );
1251 <  the_molecules[molIndex].setMyIndex( molIndex );
1252 <  the_molecules[molIndex].setGlobalIndex( i );
1291 <  molIndex++;
1247 >    for (i = 0; i < mpiSim->getTotNmol(); i++){
1248 >      if (mol2proc[i] == worldRank){
1249 >        the_molecules[molIndex].setStampID(molCompType[i]);
1250 >        the_molecules[molIndex].setMyIndex(molIndex);
1251 >        the_molecules[molIndex].setGlobalIndex(i);
1252 >        molIndex++;
1253        }
1254      }
1255 <    
1255 >
1256   #else // is_mpi
1257 <    
1257 >
1258      molIndex = 0;
1259      globalAtomIndex = 0;
1260 <    for(i=0; i<n_components; i++){
1261 <      for(j=0; j<components_nmol[i]; j++ ){
1262 <  the_molecules[molIndex].setStampID( i );
1263 <  the_molecules[molIndex].setMyIndex( molIndex );
1264 <  the_molecules[molIndex].setGlobalIndex( molIndex );
1265 <  for (k = 0; k < comp_stamps[i]->getNAtoms(); k++) {
1266 <    info[l].molMembershipArray[globalAtomIndex] = molIndex;
1267 <    globalAtomIndex++;
1268 <  }
1269 <  molIndex++;
1260 >    for (i = 0; i < n_components; i++){
1261 >      for (j = 0; j < components_nmol[i]; j++){
1262 >        the_molecules[molIndex].setStampID(i);
1263 >        the_molecules[molIndex].setMyIndex(molIndex);
1264 >        the_molecules[molIndex].setGlobalIndex(molIndex);
1265 >        for (k = 0; k < comp_stamps[i]->getNAtoms(); k++){
1266 >          info[l].molMembershipArray[globalAtomIndex] = molIndex;
1267 >          globalAtomIndex++;
1268 >        }
1269 >        molIndex++;
1270        }
1271      }
1272 <    
1273 <    
1272 >
1273 >
1274   #endif // is_mpi
1275  
1276  
1277 <    if( info[l].n_SRI ){
1317 <    
1277 >    if (info[l].n_SRI){
1278        Exclude::createArray(info[l].n_SRI);
1279 <      the_excludes = new Exclude*[info[l].n_SRI];
1280 <      for( int ex=0; ex<info[l].n_SRI; ex++){
1281 <  the_excludes[ex] = new Exclude(ex);
1279 >      the_excludes = new Exclude * [info[l].n_SRI];
1280 >      for (int ex = 0; ex < info[l].n_SRI; ex++){
1281 >        the_excludes[ex] = new Exclude(ex);
1282        }
1283        info[l].globalExcludes = new int;
1284        info[l].n_exclude = info[l].n_SRI;
1285      }
1286      else{
1287 <    
1288 <      Exclude::createArray( 1 );
1329 <      the_excludes = new Exclude*;
1287 >      Exclude::createArray(1);
1288 >      the_excludes = new Exclude * ;
1289        the_excludes[0] = new Exclude(0);
1290 <      the_excludes[0]->setPair( 0,0 );
1290 >      the_excludes[0]->setPair(0, 0);
1291        info[l].globalExcludes = new int;
1292        info[l].globalExcludes[0] = 0;
1293        info[l].n_exclude = 0;
# Line 1341 | Line 1300 | void SimSetup::makeSysArrays( void ){
1300      info[l].nGlobalExcludes = 0;
1301      info[l].excludes = the_excludes;
1302  
1303 <    the_ff->setSimInfo( info );
1345 <    
1303 >    the_ff->setSimInfo(info);
1304    }
1305   }
1306  
1307 < void SimSetup::makeIntegrator( void ){
1350 <
1307 > void SimSetup::makeIntegrator(void){
1308    int k;
1309  
1310 <  NVT<RealIntegrator>*  myNVT = NULL;
1311 <  NPTi<RealIntegrator>* myNPTi = NULL;
1312 <  NPTf<RealIntegrator>* myNPTf = NULL;
1313 <  NPTim<RealIntegrator>* myNPTim = NULL;
1314 <  NPTfm<RealIntegrator>* myNPTfm = NULL;
1315 <        
1316 <  for(k=0; k<nInfo; k++){
1317 <    
1318 <    switch( ensembleCase ){
1319 <      
1320 <    case NVE_ENS:
1321 <      if (globals->haveZconstraints()){
1322 <        setupZConstraint(info[k]);
1323 <        new ZConstraint<NVE<RealIntegrator> >( &(info[k]), the_ff );
1324 <     }
1310 >  NVE<RealIntegrator>* myNVE = NULL;
1311 >  NVT<RealIntegrator>* myNVT = NULL;
1312 >  NPTi<NPT<RealIntegrator> >* myNPTi = NULL;
1313 >  NPTf<NPT<RealIntegrator> >* myNPTf = NULL;
1314 >  NPTxyz<NPT<RealIntegrator> >* myNPTxyz = NULL;
1315 >  
1316 >  for (k = 0; k < nInfo; k++){
1317 >    switch (ensembleCase){
1318 >      case NVE_ENS:
1319 >        if (globals->haveZconstraints()){
1320 >          setupZConstraint(info[k]);
1321 >          myNVE = new ZConstraint<NVE<RealIntegrator> >(&(info[k]), the_ff);
1322 >        }
1323 >        else{
1324 >          myNVE = new NVE<RealIntegrator>(&(info[k]), the_ff);
1325 >        }
1326 >        
1327 >        info->the_integrator = myNVE;
1328 >        break;
1329  
1330 <     else
1331 <        new NVE<RealIntegrator>( &(info[k]), the_ff );
1332 <      break;
1333 <      
1334 <    case NVT_ENS:
1335 <      if (globals->haveZconstraints()){
1336 <        setupZConstraint(info[k]);
1376 <        myNVT = new ZConstraint<NVT<RealIntegrator> >( &(info[k]), the_ff );
1377 <      }
1378 <      else
1379 <        myNVT = new NVT<RealIntegrator>( &(info[k]), the_ff );
1330 >      case NVT_ENS:
1331 >        if (globals->haveZconstraints()){
1332 >          setupZConstraint(info[k]);
1333 >          myNVT = new ZConstraint<NVT<RealIntegrator> >(&(info[k]), the_ff);
1334 >        }
1335 >        else
1336 >          myNVT = new NVT<RealIntegrator>(&(info[k]), the_ff);
1337  
1338          myNVT->setTargetTemp(globals->getTargetTemp());
1339 <      
1340 <        if (globals->haveTauThermostat())
1339 >
1340 >        if (globals->haveTauThermostat())
1341            myNVT->setTauThermostat(globals->getTauThermostat());
1342 <      
1343 <        else {
1344 <          sprintf( painCave.errMsg,
1345 <                    "SimSetup error: If you use the NVT\n"
1389 <                    "    ensemble, you must set tauThermostat.\n");
1342 >        else{
1343 >          sprintf(painCave.errMsg,
1344 >                  "SimSetup error: If you use the NVT\n"
1345 >                  "    ensemble, you must set tauThermostat.\n");
1346            painCave.isFatal = 1;
1347            simError();
1348          }
1349 +
1350 +        info->the_integrator = myNVT;
1351          break;
1394      
1395    case NPTi_ENS:
1396      if (globals->haveZconstraints()){
1397             setupZConstraint(info[k]);
1398         myNPTi = new ZConstraint<NPTi<RealIntegrator> >( &(info[k]), the_ff );
1399      }
1400      else
1401        myNPTi = new NPTi<RealIntegrator>( &(info[k]), the_ff );
1352  
1353 <      myNPTi->setTargetTemp( globals->getTargetTemp() );
1354 <          
1355 <      if (globals->haveTargetPressure())
1356 <        myNPTi->setTargetPressure(globals->getTargetPressure());
1357 <      else {
1358 <         sprintf( painCave.errMsg,
1359 <                   "SimSetup error: If you use a constant pressure\n"
1410 <                   "    ensemble, you must set targetPressure in the BASS file.\n");
1411 <         painCave.isFatal = 1;
1412 <         simError();
1413 <      }
1414 <          
1415 <      if( globals->haveTauThermostat() )
1416 <        myNPTi->setTauThermostat( globals->getTauThermostat() );
1417 <      else{
1418 <         sprintf( painCave.errMsg,
1419 <                   "SimSetup error: If you use an NPT\n"
1420 <                  "    ensemble, you must set tauThermostat.\n");
1421 <         painCave.isFatal = 1;
1422 <         simError();
1423 <      }
1424 <          
1425 <      if( globals->haveTauBarostat() )
1426 <        myNPTi->setTauBarostat( globals->getTauBarostat() );
1427 <      else{
1428 <        sprintf( painCave.errMsg,
1429 <                  "SimSetup error: If you use an NPT\n"
1430 <                  "    ensemble, you must set tauBarostat.\n");
1431 <        painCave.isFatal = 1;
1432 <        simError();
1433 <       }
1434 <       break;
1435 <      
1436 <    case NPTf_ENS:
1437 <      if (globals->haveZconstraints()){
1438 <        setupZConstraint(info[k]);
1439 <        myNPTf = new ZConstraint<NPTf<RealIntegrator> >( &(info[k]), the_ff );
1440 <      }
1441 <      else
1442 <        myNPTf = new NPTf<RealIntegrator>( &(info[k]), the_ff );
1353 >      case NPTi_ENS:
1354 >        if (globals->haveZconstraints()){
1355 >          setupZConstraint(info[k]);
1356 >          myNPTi = new ZConstraint<NPTi<NPT <RealIntegrator> > >(&(info[k]), the_ff);
1357 >        }
1358 >        else
1359 >          myNPTi = new NPTi<NPT<RealIntegrator> >(&(info[k]), the_ff);
1360  
1361 <      myNPTf->setTargetTemp( globals->getTargetTemp());
1445 <          
1446 <      if (globals->haveTargetPressure())
1447 <        myNPTf->setTargetPressure(globals->getTargetPressure());
1448 <      else {
1449 <        sprintf( painCave.errMsg,
1450 <                  "SimSetup error: If you use a constant pressure\n"
1451 <                  "    ensemble, you must set targetPressure in the BASS file.\n");
1452 <        painCave.isFatal = 1;
1453 <        simError();
1454 <      }    
1455 <          
1456 <      if( globals->haveTauThermostat() )
1457 <        myNPTf->setTauThermostat( globals->getTauThermostat() );
1458 <      else{
1459 <        sprintf( painCave.errMsg,
1460 <         "SimSetup error: If you use an NPT\n"
1461 <                   "    ensemble, you must set tauThermostat.\n");
1462 <        painCave.isFatal = 1;
1463 <        simError();
1464 <      }
1465 <          
1466 <      if( globals->haveTauBarostat() )
1467 <        myNPTf->setTauBarostat( globals->getTauBarostat() );
1468 <      else{
1469 <        sprintf( painCave.errMsg,
1470 <                  "SimSetup error: If you use an NPT\n"
1471 <                  "    ensemble, you must set tauBarostat.\n");
1472 <        painCave.isFatal = 1;
1473 <        simError();
1474 <      }
1475 <      break;
1476 <      
1477 <    case NPTim_ENS:
1478 <      if (globals->haveZconstraints()){
1479 <        setupZConstraint(info[k]);
1480 <        myNPTim = new ZConstraint<NPTim<RealIntegrator> >( &(info[k]), the_ff );
1481 <      }
1482 <      else
1483 <        myNPTim = new NPTim<RealIntegrator>( &(info[k]), the_ff );
1361 >        myNPTi->setTargetTemp(globals->getTargetTemp());
1362  
1363 <        myNPTim->setTargetTemp( globals->getTargetTemp());
1364 <          
1365 <      if (globals->haveTargetPressure())
1366 <        myNPTim->setTargetPressure(globals->getTargetPressure());
1489 <      else {
1490 <        sprintf( painCave.errMsg,
1363 >        if (globals->haveTargetPressure())
1364 >          myNPTi->setTargetPressure(globals->getTargetPressure());
1365 >        else{
1366 >          sprintf(painCave.errMsg,
1367                    "SimSetup error: If you use a constant pressure\n"
1368                    "    ensemble, you must set targetPressure in the BASS file.\n");
1369 <        painCave.isFatal = 1;
1370 <        simError();
1371 <      }
1372 <          
1373 <      if( globals->haveTauThermostat() )
1374 <        myNPTim->setTauThermostat( globals->getTauThermostat() );
1375 <      else{
1376 <        sprintf( painCave.errMsg,
1369 >          painCave.isFatal = 1;
1370 >          simError();
1371 >        }
1372 >
1373 >        if (globals->haveTauThermostat())
1374 >          myNPTi->setTauThermostat(globals->getTauThermostat());
1375 >        else{
1376 >          sprintf(painCave.errMsg,
1377                    "SimSetup error: If you use an NPT\n"
1378                    "    ensemble, you must set tauThermostat.\n");
1379 <        painCave.isFatal = 1;
1380 <        simError();
1381 <      }
1506 <          
1507 <      if( globals->haveTauBarostat() )
1508 <        myNPTim->setTauBarostat( globals->getTauBarostat() );
1509 <      else{
1510 <        sprintf( painCave.errMsg,
1511 <                   "SimSetup error: If you use an NPT\n"
1512 <                   "    ensemble, you must set tauBarostat.\n");
1513 <        painCave.isFatal = 1;
1514 <        simError();
1515 <      }
1516 <      break;
1517 <      
1518 <    case NPTfm_ENS:
1519 <      if (globals->haveZconstraints()){
1520 <        setupZConstraint(info[k]);
1521 <        myNPTfm = new ZConstraint<NPTfm<RealIntegrator> >( &(info[k]), the_ff );
1522 <      }
1523 <      else
1524 <        myNPTfm = new NPTfm<RealIntegrator>( &(info[k]), the_ff );
1379 >          painCave.isFatal = 1;
1380 >          simError();
1381 >        }
1382  
1383 <      myNPTfm->setTargetTemp( globals->getTargetTemp());
1383 >        if (globals->haveTauBarostat())
1384 >          myNPTi->setTauBarostat(globals->getTauBarostat());
1385 >        else{
1386 >          sprintf(painCave.errMsg,
1387 >                  "SimSetup error: If you use an NPT\n"
1388 >                  "    ensemble, you must set tauBarostat.\n");
1389 >          painCave.isFatal = 1;
1390 >          simError();
1391 >        }
1392  
1393 <      if (globals->haveTargetPressure())
1394 <        myNPTfm->setTargetPressure(globals->getTargetPressure());
1530 <      else {
1531 <        sprintf( painCave.errMsg,
1532 <                  "SimSetup error: If you use a constant pressure\n"
1533 <                  "    ensemble, you must set targetPressure in the BASS file.\n");
1534 <        painCave.isFatal = 1;
1535 <        simError();
1536 <      }
1393 >        info->the_integrator = myNPTi;
1394 >        break;
1395  
1396 <      if( globals->haveTauThermostat() )
1397 <        myNPTfm->setTauThermostat( globals->getTauThermostat() );
1398 <      else{
1399 <        sprintf( painCave.errMsg,
1400 <                  "SimSetup error: If you use an NPT\n"
1401 <                  "    ensemble, you must set tauThermostat.\n");
1402 <        painCave.isFatal = 1;
1545 <        simError();
1546 <      }
1396 >      case NPTf_ENS:
1397 >        if (globals->haveZconstraints()){
1398 >          setupZConstraint(info[k]);
1399 >          myNPTf = new ZConstraint<NPTf<NPT <RealIntegrator> > >(&(info[k]), the_ff);
1400 >        }
1401 >        else
1402 >          myNPTf = new NPTf<NPT <RealIntegrator> >(&(info[k]), the_ff);
1403  
1404 <      if( globals->haveTauBarostat() )
1405 <        myNPTfm->setTauBarostat( globals->getTauBarostat() );
1406 <      else{
1407 <        sprintf( painCave.errMsg,
1404 >        myNPTf->setTargetTemp(globals->getTargetTemp());
1405 >
1406 >        if (globals->haveTargetPressure())
1407 >          myNPTf->setTargetPressure(globals->getTargetPressure());
1408 >        else{
1409 >          sprintf(painCave.errMsg,
1410 >                  "SimSetup error: If you use a constant pressure\n"
1411 >                  "    ensemble, you must set targetPressure in the BASS file.\n");
1412 >          painCave.isFatal = 1;
1413 >          simError();
1414 >        }    
1415 >
1416 >        if (globals->haveTauThermostat())
1417 >          myNPTf->setTauThermostat(globals->getTauThermostat());
1418 >
1419 >        else{
1420 >          sprintf(painCave.errMsg,
1421                    "SimSetup error: If you use an NPT\n"
1422 +                  "    ensemble, you must set tauThermostat.\n");
1423 +          painCave.isFatal = 1;
1424 +          simError();
1425 +        }
1426 +
1427 +        if (globals->haveTauBarostat())
1428 +          myNPTf->setTauBarostat(globals->getTauBarostat());
1429 +
1430 +        else{
1431 +          sprintf(painCave.errMsg,
1432 +                  "SimSetup error: If you use an NPT\n"
1433                    "    ensemble, you must set tauBarostat.\n");
1434 +          painCave.isFatal = 1;
1435 +          simError();
1436 +        }
1437 +
1438 +        info->the_integrator = myNPTf;
1439 +        break;
1440 +
1441 +      case NPTxyz_ENS:
1442 +        if (globals->haveZconstraints()){
1443 +          setupZConstraint(info[k]);
1444 +          myNPTxyz = new ZConstraint<NPTxyz<NPT <RealIntegrator> > >(&(info[k]), the_ff);
1445 +        }
1446 +        else
1447 +          myNPTxyz = new NPTxyz<NPT <RealIntegrator> >(&(info[k]), the_ff);
1448 +
1449 +        myNPTxyz->setTargetTemp(globals->getTargetTemp());
1450 +
1451 +        if (globals->haveTargetPressure())
1452 +          myNPTxyz->setTargetPressure(globals->getTargetPressure());
1453 +        else{
1454 +          sprintf(painCave.errMsg,
1455 +                  "SimSetup error: If you use a constant pressure\n"
1456 +                  "    ensemble, you must set targetPressure in the BASS file.\n");
1457 +          painCave.isFatal = 1;
1458 +          simError();
1459 +        }    
1460 +
1461 +        if (globals->haveTauThermostat())
1462 +          myNPTxyz->setTauThermostat(globals->getTauThermostat());
1463 +        else{
1464 +          sprintf(painCave.errMsg,
1465 +                  "SimSetup error: If you use an NPT\n"
1466 +                  "    ensemble, you must set tauThermostat.\n");
1467 +          painCave.isFatal = 1;
1468 +          simError();
1469 +        }
1470 +
1471 +        if (globals->haveTauBarostat())
1472 +          myNPTxyz->setTauBarostat(globals->getTauBarostat());
1473 +        else{
1474 +          sprintf(painCave.errMsg,
1475 +                  "SimSetup error: If you use an NPT\n"
1476 +                  "    ensemble, you must set tauBarostat.\n");
1477 +          painCave.isFatal = 1;
1478 +          simError();
1479 +        }
1480 +
1481 +        info->the_integrator = myNPTxyz;
1482 +        break;
1483 +
1484 +      default:
1485 +        sprintf(painCave.errMsg,
1486 +                "SimSetup Error. Unrecognized ensemble in case statement.\n");
1487          painCave.isFatal = 1;
1488          simError();
1556      }
1557      break;
1558      
1559    default:
1560      sprintf( painCave.errMsg,
1561                 "SimSetup Error. Unrecognized ensemble in case statement.\n");
1562      painCave.isFatal = 1;
1563      simError();
1489      }
1490    }
1491   }
1492  
1493 < void SimSetup::initFortran( void ){
1569 <
1493 > void SimSetup::initFortran(void){
1494    info[0].refreshSim();
1495 <  
1496 <  if( !strcmp( info[0].mixingRule, "standard") ){
1497 <    the_ff->initForceField( LB_MIXING_RULE );
1495 >
1496 >  if (!strcmp(info[0].mixingRule, "standard")){
1497 >    the_ff->initForceField(LB_MIXING_RULE);
1498    }
1499 <  else if( !strcmp( info[0].mixingRule, "explicit") ){
1500 <    the_ff->initForceField( EXPLICIT_MIXING_RULE );
1499 >  else if (!strcmp(info[0].mixingRule, "explicit")){
1500 >    the_ff->initForceField(EXPLICIT_MIXING_RULE);
1501    }
1502    else{
1503 <    sprintf( painCave.errMsg,
1504 <       "SimSetup Error: unknown mixing rule -> \"%s\"\n",
1581 <       info[0].mixingRule );
1503 >    sprintf(painCave.errMsg, "SimSetup Error: unknown mixing rule -> \"%s\"\n",
1504 >            info[0].mixingRule);
1505      painCave.isFatal = 1;
1506      simError();
1507    }
1508  
1509  
1510   #ifdef IS_MPI
1511 <  strcpy( checkPointMsg,
1589 <    "Successfully intialized the mixingRule for Fortran." );
1511 >  strcpy(checkPointMsg, "Successfully intialized the mixingRule for Fortran.");
1512    MPIcheckPoint();
1513   #endif // is_mpi
1592
1514   }
1515  
1516 < void SimSetup::setupZConstraint(SimInfo& theInfo)
1596 < {
1516 > void SimSetup::setupZConstraint(SimInfo& theInfo){
1517    int nZConstraints;
1518    ZconStamp** zconStamp;
1519  
1520 <  if(globals->haveZconstraintTime()){  
1601 <    
1520 >  if (globals->haveZconstraintTime()){
1521      //add sample time of z-constraint  into SimInfo's property list                    
1522      DoubleData* zconsTimeProp = new DoubleData();
1523      zconsTimeProp->setID(ZCONSTIME_ID);
# Line 1606 | Line 1525 | void SimSetup::setupZConstraint(SimInfo& theInfo)
1525      theInfo.addProperty(zconsTimeProp);
1526    }
1527    else{
1528 <    sprintf( painCave.errMsg,
1529 <       "ZConstraint error: If you use an ZConstraint\n"
1530 <       " , you must set sample time.\n");
1528 >    sprintf(painCave.errMsg,
1529 >            "ZConstraint error: If you use an ZConstraint\n"
1530 >            " , you must set sample time.\n");
1531      painCave.isFatal = 1;
1532 <    simError();      
1532 >    simError();
1533    }
1534  
1535    //push zconsTol into siminfo, if user does not specify
1536    //value for zconsTol, a default value will be used
1537    DoubleData* zconsTol = new DoubleData();
1538    zconsTol->setID(ZCONSTOL_ID);
1539 <  if(globals->haveZconsTol()){
1539 >  if (globals->haveZconsTol()){
1540      zconsTol->setData(globals->getZconsTol());
1541    }
1542    else{
1543 <  double defaultZConsTol = 0.01;
1544 <    sprintf( painCave.errMsg,
1545 <       "ZConstraint Waring: Tolerance for z-constraint methodl is not specified\n"
1546 <       " , default value %f is used.\n", defaultZConsTol);
1543 >    double defaultZConsTol = 0.01;
1544 >    sprintf(painCave.errMsg,
1545 >            "ZConstraint Waring: Tolerance for z-constraint methodl is not specified\n"
1546 >            " , default value %f is used.\n",
1547 >            defaultZConsTol);
1548      painCave.isFatal = 0;
1549      simError();      
1550  
# Line 1632 | Line 1552 | void SimSetup::setupZConstraint(SimInfo& theInfo)
1552    }
1553    theInfo.addProperty(zconsTol);
1554  
1555 <  //set Force Substraction Policy
1556 <  StringData* zconsForcePolicy =  new StringData();
1555 >  //set Force Subtraction Policy
1556 >  StringData* zconsForcePolicy = new StringData();
1557    zconsForcePolicy->setID(ZCONSFORCEPOLICY_ID);
1558 <  
1559 <  if(globals->haveZconsForcePolicy()){
1558 >
1559 >  if (globals->haveZconsForcePolicy()){
1560      zconsForcePolicy->setData(globals->getZconsForcePolicy());
1561 <  }  
1561 >  }
1562    else{
1563 <     sprintf( painCave.errMsg,
1564 <             "ZConstraint Warning: User does not set force substraction policy, "
1565 <             "average force substraction policy is used\n");
1566 <     painCave.isFatal = 0;
1567 <     simError();
1568 <     zconsForcePolicy->setData("BYNUMBER");
1563 >    sprintf(painCave.errMsg,
1564 >            "ZConstraint Warning: User does not set force Subtraction policy, "
1565 >            "PolicyByMass is used\n");
1566 >    painCave.isFatal = 0;
1567 >    simError();
1568 >    zconsForcePolicy->setData("BYMASS");
1569    }
1570 <
1571 < theInfo.addProperty(zconsForcePolicy);
1572 <
1570 >
1571 >  theInfo.addProperty(zconsForcePolicy);
1572 >
1573    //Determine the name of ouput file and add it into SimInfo's property list
1574    //Be careful, do not use inFileName, since it is a pointer which
1575    //point to a string at master node, and slave nodes do not contain that string
1576 <  
1576 >
1577    string zconsOutput(theInfo.finalName);
1578 <  
1578 >
1579    zconsOutput = zconsOutput.substr(0, zconsOutput.rfind(".")) + ".fz";
1580 <  
1580 >
1581    StringData* zconsFilename = new StringData();
1582    zconsFilename->setID(ZCONSFILENAME_ID);
1583    zconsFilename->setData(zconsOutput);
1584 <  
1584 >
1585    theInfo.addProperty(zconsFilename);
1586 <  
1586 >
1587    //setup index, pos and other parameters of z-constraint molecules
1588    nZConstraints = globals->getNzConstraints();
1589    theInfo.nZconstraints = nZConstraints;
# Line 1673 | Line 1593 | void SimSetup::setupZConstraint(SimInfo& theInfo)
1593  
1594    ZConsParaData* zconsParaData = new ZConsParaData();
1595    zconsParaData->setID(ZCONSPARADATA_ID);
1596 <
1597 <  for(int i = 0; i < nZConstraints; i++){
1596 >
1597 >  for (int i = 0; i < nZConstraints; i++){
1598      tempParaItem.havingZPos = zconStamp[i]->haveZpos();
1599      tempParaItem.zPos = zconStamp[i]->getZpos();
1600      tempParaItem.zconsIndex = zconStamp[i]->getMolIndex();
# Line 1683 | Line 1603 | void SimSetup::setupZConstraint(SimInfo& theInfo)
1603      zconsParaData->addItem(tempParaItem);
1604    }
1605  
1606 +  //check the uniqueness of index  
1607 +  if(!zconsParaData->isIndexUnique()){
1608 +    sprintf(painCave.errMsg,
1609 +            "ZConstraint Error: molIndex is not unique\n");
1610 +    painCave.isFatal = 1;
1611 +    simError();
1612 +  }
1613 +
1614    //sort the parameters by index of molecules
1615    zconsParaData->sortByIndex();
1616    
1617    //push data into siminfo, therefore, we can retrieve later
1618    theInfo.addProperty(zconsParaData);
1691      
1619   }

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines